From: Juergen Gross <jgross@suse.com>
To: Anoob Soman <anoob.soman@citrix.com>, xen-devel@lists.xenproject.org
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: Check for irqs_disabled in evtchn_fifo_unmask
Date: Fri, 2 Jun 2017 17:08:56 +0200 [thread overview]
Message-ID: <ce29e03f-22a6-a961-2d2d-38b9515c7e2d@suse.com> (raw)
In-Reply-To: <7c28fccb-fb5a-8796-cd86-3f9eecb19856@citrix.com>
On 01/06/17 19:01, Anoob Soman wrote:
> Hi,
>
> Can someone explain, why evtchn_fifo_unmask() requires irqs_disabled().
> What happens, if irqs are not disabled ?
evtchn_fifo_unmask() seems to be not critical, but evtchn_2l_unmask()
might be racy if another event is coming in in the middle. The
BUG_ON() in evtchn_fifo_unmask() just makes sure adding a new caller
not obeying the restriction of evtchn_2l_unmask() won't be unnoticed.
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2017-06-02 15:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 17:01 Check for irqs_disabled in evtchn_fifo_unmask Anoob Soman
2017-06-02 15:08 ` Juergen Gross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce29e03f-22a6-a961-2d2d-38b9515c7e2d@suse.com \
--to=jgross@suse.com \
--cc=anoob.soman@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).