xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: xen-devel@lists.xen.org
Subject: [PATCH 8 of 8] hotplug/Linux: install sysconfig files as data files
Date: Mon, 15 Oct 2012 15:44:26 +0200	[thread overview]
Message-ID: <ce697a3171e3d49675e2.1350308666@probook.site> (raw)
In-Reply-To: <patchbomb.1350308658@probook.site>

# HG changeset patch
# User Olaf Hering <olaf@aepfle.de>
# Date 1350307814 -7200
# Node ID ce697a3171e3d49675e2d46ca27e74c9710ba8c8
# Parent  588061a50040df5f1b65c4538697e2161e99e37d
hotplug/Linux: install sysconfig files as data files

rpmlint complains about wrong permissions of config files:

[  455s] xen-tools.i586: W: script-without-shebang /var/adm/fillup-templates/sysconfig.xendomains
[  455s] xen-tools.i586: W: script-without-shebang /var/adm/fillup-templates/sysconfig.xencommons
[  455s] This text file has executable bits set or is located in a path dedicated for
[  455s] executables, but lacks a shebang and cannot thus be executed.  If the file is
[  455s] meant to be an executable script, add the shebang, otherwise remove the
[  455s] executable bits or move the file elsewhere.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

diff -r 588061a50040 -r ce697a3171e3 tools/hotplug/Linux/Makefile
--- a/tools/hotplug/Linux/Makefile
+++ b/tools/hotplug/Linux/Makefile
@@ -69,9 +69,9 @@ install-initd:
 	[ -d $(DESTDIR)$(SYSCONFIG_DIR) ] || $(INSTALL_DIR) $(DESTDIR)$(SYSCONFIG_DIR)
 	$(INSTALL_PROG) $(XEND_INITD) $(DESTDIR)$(INITD_DIR)
 	$(INSTALL_PROG) $(XENDOMAINS_INITD) $(DESTDIR)$(INITD_DIR)
-	$(INSTALL_PROG) $(XENDOMAINS_SYSCONFIG) $(DESTDIR)$(SYSCONFIG_DIR)/xendomains
+	$(INSTALL_DATA) $(XENDOMAINS_SYSCONFIG) $(DESTDIR)$(SYSCONFIG_DIR)/xendomains
 	$(INSTALL_PROG) $(XENCOMMONS_INITD) $(DESTDIR)$(INITD_DIR)
-	$(INSTALL_PROG) $(XENCOMMONS_SYSCONFIG) $(DESTDIR)$(SYSCONFIG_DIR)/xencommons
+	$(INSTALL_DATA) $(XENCOMMONS_SYSCONFIG) $(DESTDIR)$(SYSCONFIG_DIR)/xencommons
 	$(INSTALL_PROG) init.d/xen-watchdog $(DESTDIR)$(INITD_DIR)
 
 .PHONY: install-scripts

  parent reply	other threads:[~2012-10-15 13:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-15 13:44 [PATCH 0 of 8] tools: various packaging fixes Olaf Hering
2012-10-15 13:44 ` [PATCH 1 of 8] stubdom: fix rpmlint warning spurious-executable-perm Olaf Hering
2012-10-15 13:44 ` [PATCH 2 of 8] blktap2/libvhd: " Olaf Hering
2012-10-15 13:44 ` [PATCH 3 of 8] blktap: " Olaf Hering
2012-10-15 13:44 ` [PATCH 4 of 8] hotplug/Linux: add sysconfig tags to xencommons Olaf Hering
2012-10-18  8:18   ` Ian Campbell
2012-10-18  8:48     ` Olaf Hering
2012-10-15 13:44 ` [PATCH 5 of 8] hotplug: install hotplugpath.sh as data file Olaf Hering
2012-10-15 13:44 ` [PATCH 6 of 8] stubdom: install stubdompath.sh " Olaf Hering
2012-10-15 13:44 ` [PATCH 7 of 8] hotplug/Linux: correct sysconfig tag in xendomains Olaf Hering
2012-10-15 13:44 ` Olaf Hering [this message]
2012-10-18  8:35 ` [PATCH 0 of 8] tools: various packaging fixes Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce697a3171e3d49675e2.1350308666@probook.site \
    --to=olaf@aepfle.de \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).