From: Julien Grall <julien.grall@arm.com>
To: Tamas K Lengyel <tamas.lengyel@zentific.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Razvan Cojocaru <rcojocaru@bitdefender.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] mem_access: Use monitor_traps instead of mem_access_send_req
Date: Mon, 1 Aug 2016 11:33:08 +0100 [thread overview]
Message-ID: <cee7e9fb-883c-9d74-6858-1d467b6d3930@arm.com> (raw)
In-Reply-To: <CAErYnsjW0JGV-CLcZq8jDnRC2YYxyL9nDZDXL_frtXfOz-hs1A@mail.gmail.com>
Hello Tamas,
On 29/07/16 23:26, Tamas K Lengyel wrote:
> However, as this patch really only touches
> things that belong to mem_access/monitor components maybe we should
> split these from the generic ARM code altogether to avoid such
> conflicts in the future.
I am not against moving part of mem_access outside of the P2M. However,
the ARM (32-bit and 64-bit) code needs a lot more attention to make it
work in *all* the case. I was able to break memaccess quite easily on
various platform (include models).
For instance p2m_mem_access_check_and_get_page is using the hardware to
translate a VA to an IPA. This only works if the memory where the
stage-1 page tables reside is not protected. The upcoming support of
altp2m will make things trickier.
The interface of p2m_mem_access_check_and_get_page should also be
updated to take a VCPU in parameter.
Lastly getting/setting access in the the mem_access_settings radix tree
should stay in the p2m code as it is tight to stage-2 page table
implementation.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-08-01 10:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 19:35 [PATCH] mem_access: Use monitor_traps instead of mem_access_send_req Tamas K Lengyel
2016-07-28 20:38 ` Julien Grall
2016-07-28 22:54 ` Tamas K Lengyel
2016-07-29 8:50 ` Julien Grall
[not found] ` <CAErYnshxhSzg2n0327z8P9U_Y-K88De0v1j7W82SPH25eCQuTg@mail.gmail.com>
[not found] ` <CAErYnsj+zv7h_sFR7y28xF3TVoytPZOQDG-oR2mEaJG7ZHYthA@mail.gmail.com>
2016-07-29 14:21 ` Tamas K Lengyel
2016-07-29 16:27 ` Andrew Cooper
2016-07-29 20:52 ` Tamas K Lengyel
2016-07-29 17:38 ` Stefano Stabellini
2016-07-29 21:02 ` Tamas K Lengyel
2016-07-29 21:38 ` Julien Grall
2016-07-29 22:26 ` Tamas K Lengyel
2016-08-01 10:33 ` Julien Grall [this message]
2016-08-01 16:10 ` Tamas K Lengyel
2016-07-28 20:54 ` Andrew Cooper
2016-07-28 22:48 ` Tamas K Lengyel
2016-07-29 7:29 ` Razvan Cojocaru
[not found] ` <CAErYnsjM4-5oX2P5A8z-LHcKqTR0pJ+hBcaKDk-57Bt50tzG7g@mail.gmail.com>
[not found] ` <CAErYnsjNjuH7N6feGA+kjMZK+z5oWMtM=94aZt2J0zN718C_4Q@mail.gmail.com>
2016-07-29 14:27 ` Tamas K Lengyel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cee7e9fb-883c-9d74-6858-1d467b6d3930@arm.com \
--to=julien.grall@arm.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=rcojocaru@bitdefender.com \
--cc=sstabellini@kernel.org \
--cc=tamas.lengyel@zentific.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).