xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
	Julien Grall <julien.grall@arm.com>
Subject: Re: [PATCH] x86/mm: add temporary debugging code to get_page_from_gfn_p2m()
Date: Thu, 4 May 2017 10:39:37 +0100	[thread overview]
Message-ID: <cf6ff36c-5837-d831-6c4d-c6c2bb429fbf@citrix.com> (raw)
In-Reply-To: <590B0BDB0200007800156A92@prv-mh.provo.novell.com>

On 04/05/17 10:09, Jan Beulich wrote:
> See the code comment.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

>
> --- a/xen/arch/x86/mm/p2m.c
> +++ b/xen/arch/x86/mm/p2m.c
> @@ -480,6 +480,22 @@ struct page_info *get_page_from_gfn_p2m(
>      p2m_access_t _a;
>      p2m_type_t _t;
>      mfn_t mfn;
> +#ifndef NDEBUG
> +    /*
> +     * Temporary debugging code, added in the hope of finding the origin
> +     * of calls to get_page(..., dom_cow) as observed during osstest
> +     * migration failures (see
> +     * lists.xenproject.org/archives/html/xen-devel/2017-04/msg03331.html).
> +     */
> +    static unsigned long cnt, thr;
> +
> +    if ( d->is_dying && ++cnt > thr )
> +    {
> +        thr |= cnt;
> +        printk("%pv: d%d dying (looking up %lx)\n", current, d->domain_id, gfn);
> +        dump_execution_state();
> +    }
> +#endif
>  
>      /* Allow t or a to be NULL */
>      t = t ?: &_t;
>
>
>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-05-04  9:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-04  9:09 [PATCH] x86/mm: add temporary debugging code to get_page_from_gfn_p2m() Jan Beulich
2017-05-04  9:39 ` Andrew Cooper [this message]
2017-05-04  9:42   ` Julien Grall
2017-05-04 12:07     ` Jan Beulich
2017-05-04 12:49       ` Julien Grall
2017-05-08 15:00 ` George Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf6ff36c-5837-d831-6c4d-c6c2bb429fbf@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=julien.grall@arm.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).