From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Marczykowski Subject: [PATCH 08 of 10] xen.lowlevel.xl: Return None on empty domain name Date: Fri, 03 Jun 2011 00:35:38 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: marmarek@mimuw.edu.pl List-Id: xen-devel@lists.xenproject.org # HG changeset patch # User Marek Marczykowski # Date 1306963128 -7200 # Node ID d03bd7a830bff8162b6b0564d27b3f36ca52d8bb # Parent 6811aa543e69379557ff7391ea3db8a5e7f7dde0 xen.lowlevel.xl: Return None on empty domain name Previously PyString_FromString(NULL) was called, which caused assertion failure. Signed-off-by: Marek Marczykowski diff --git a/tools/python/xen/lowlevel/xl/xl.c b/tools/python/xen/lowlevel/xl/xl.c --- a/tools/python/xen/lowlevel/xl/xl.c +++ b/tools/python/xen/lowlevel/xl/xl.c @@ -418,8 +418,11 @@ return NULL; domname = libxl_domid_to_name(&self->ctx, domid); - ret = PyString_FromString(domname); - free(domname); + if (domname) { + ret = PyString_FromString(domname); + free(domname); + } else + return Py_None; return ret; }