From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 1/3] xen/arm: io: Distinguish unhandled IO from aborted one Date: Tue, 30 Jan 2018 18:31:53 +0000 Message-ID: References: <20180130161433.6910-1-julien.grall@arm.com> <20180130161433.6910-2-julien.grall@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Stefano Stabellini Cc: andrew.cooper3@citrix.com, andre.przywara@linaro.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org SGkgU3RlZmFubywKCk9uIDMwLzAxLzE4IDE4OjE0LCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6 Cj4gT24gVHVlLCAzMCBKYW4gMjAxOCwgSnVsaWVuIEdyYWxsIHdyb3RlOgo+PiBDdXJyZW50bHks IFhlbiBpcyBjb25zaWRlcmluZyB0aGF0IGFuIElPIGNvdWxkIGVpdGhlciBiZSBoYW5kbGVkIG9y Cj4+IHVuaGFuZGxlZC4gV2hlbiB1bmhhbmRsZWQsIHRoZSBzdGFnZS0yIGFib3J0IGZ1bmN0aW9u IHdpbGwgdHJ5IGFub3RoZXIKPj4gd2F5IHRvIHJlc29sdmUgdGhlIGFib3J0Lgo+Pgo+PiBIb3dl dmVyLCB0aGUgTU1JTyBlbXVsYXRpb24gbWF5IHJldHVybiB1bmhhbmRsZWQgd2hlbiB0aGUgYWRk cmVzcwo+PiBiZWxvbmdzIHRvIGFuIGVtdWxhdGVkIHJhbmdlIGJ1dCB3YXMgbm90IGNvcnJlY3Qu IEluIHRoYXQgY2FzZSwgWGVuCj4+IHNob3VsZCBhdm9kaSB0byB0cnkgYW5vdGhlciB3YXkgYW5k IGRpcmVjdGx5IGluamVjdCBhIGd1ZXN0IGRhdGEgYWJvcnQuCj4gICAgICAgICAgIF4gYXZvaWQK PiAKPiAKPj4gSW50cm9kdWNlIGEgdHJpLXN0YXRlIHJldHVybiB0byBkaXN0aW5ndWlzaCB0aGUg Zm9sbG93aW5nIHN0YXRlOgo+PiAgICAgICogSU9fQUJPUlQ6IFRoZSBJTyB3YXMgaGFuZGxlZCBi dXQgcmVzdWx0ZWQgdG8gYW4gYWJvcnQKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBeIGluIGFuIGFib3J0Cj4gCj4gCj4+ICAgICAgKiBJT19IQU5E TEVEOiBUaGUgSU8gd2FzIGhhbmRsZWQKPj4gICAgICAqIElPX1VOSEFORExFRDogVGhlIElPIHdh cyB1bmhhbmRsZWQKPj4KPj4gRm9yIG5vdywgaXQgaXMgY29uc2lkZXJlZCB0aGF0IGFuIElPIGJl bG9uZ2luZyB0byBhbiBlbXVsYXRlZCByYW5nZQo+PiBjb3VsZCBlaXRoZXIgYmUgaGFuZGxlZCBv ciBpbmplY3QgYW4gYWJvcnQuIFRoaXMgY291bGQgYmUgcmV2aXNpdCBpbiB0aGUKPj4gZnV0dXJl IGlmIG92ZXJsYXBwZWQgcmVnaW9uIGV4aXN0IChvciB3ZSB3YW50IHRvIHRyeSBhbm90aGVyIHdh eSB0bwo+PiByZXNvbHZlIHRoZSBhYm9ydCkuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IEp1bGllbiBH cmFsbCA8anVsaWVuLmdyYWxsQGFybS5jb20+Cj4+IC0tLQo+PiAgIHhlbi9hcmNoL2FybS9pby5j ICAgICAgICAgIHwgMjQgKysrKysrKysrKysrKystLS0tLS0tLS0tCj4+ICAgeGVuL2FyY2gvYXJt L3RyYXBzLmMgICAgICAgfCAzNCArKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tCj4+ ICAgeGVuL2luY2x1ZGUvYXNtLWFybS9tbWlvLmggfCAgOSArKysrKysrKy0KPj4gICAzIGZpbGVz IGNoYW5nZWQsIDQ1IGluc2VydGlvbnMoKyksIDIyIGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0t Z2l0IGEveGVuL2FyY2gvYXJtL2lvLmMgYi94ZW4vYXJjaC9hcm0vaW8uYwo+PiBpbmRleCBjNzQ4 ZDhmNWJmLi5hNzRlYzIxYjg2IDEwMDY0NAo+PiAtLS0gYS94ZW4vYXJjaC9hcm0vaW8uYwo+PiAr KysgYi94ZW4vYXJjaC9hcm0vaW8uYwo+PiBAQCAtMjMsOCArMjMsOSBAQAo+PiAgICNpbmNsdWRl IDxhc20vY3VycmVudC5oPgo+PiAgICNpbmNsdWRlIDxhc20vbW1pby5oPgo+PiAgIAo+PiAtc3Rh dGljIGludCBoYW5kbGVfcmVhZChjb25zdCBzdHJ1Y3QgbW1pb19oYW5kbGVyICpoYW5kbGVyLCBz dHJ1Y3QgdmNwdSAqdiwKPj4gLSAgICAgICAgICAgICAgICAgICAgICAgbW1pb19pbmZvX3QgKmlu Zm8pCj4+ICtzdGF0aWMgZW51bSBpb19zdGF0ZSBoYW5kbGVfcmVhZChjb25zdCBzdHJ1Y3QgbW1p b19oYW5kbGVyICpoYW5kbGVyLAo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg c3RydWN0IHZjcHUgKnYsCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtbWlv X2luZm9fdCAqaW5mbykKPj4gICB7Cj4+ICAgICAgIGNvbnN0IHN0cnVjdCBoc3JfZGFidCBkYWJ0 ID0gaW5mby0+ZGFidDsKPj4gICAgICAgc3RydWN0IGNwdV91c2VyX3JlZ3MgKnJlZ3MgPSBndWVz dF9jcHVfdXNlcl9yZWdzKCk7Cj4+IEBAIC0zNyw3ICszOCw3IEBAIHN0YXRpYyBpbnQgaGFuZGxl X3JlYWQoY29uc3Qgc3RydWN0IG1taW9faGFuZGxlciAqaGFuZGxlciwgc3RydWN0IHZjcHUgKnYs Cj4+ICAgICAgIHVpbnQ4X3Qgc2l6ZSA9ICgxIDw8IGRhYnQuc2l6ZSkgKiA4Owo+PiAgIAo+PiAg ICAgICBpZiAoICFoYW5kbGVyLT5vcHMtPnJlYWQodiwgaW5mbywgJnIsIGhhbmRsZXItPnByaXYp ICkKPj4gLSAgICAgICAgcmV0dXJuIDA7Cj4+ICsgICAgICAgIHJldHVybiBJT19BQk9SVDsKPj4g ICAKPj4gICAgICAgLyoKPj4gICAgICAgICogU2lnbiBleHRlbmQgaWYgcmVxdWlyZWQuCj4+IEBA IC01NywxNyArNTgsMjAgQEAgc3RhdGljIGludCBoYW5kbGVfcmVhZChjb25zdCBzdHJ1Y3QgbW1p b19oYW5kbGVyICpoYW5kbGVyLCBzdHJ1Y3QgdmNwdSAqdiwKPj4gICAKPj4gICAgICAgc2V0X3Vz ZXJfcmVnKHJlZ3MsIGRhYnQucmVnLCByKTsKPj4gICAKPj4gLSAgICByZXR1cm4gMTsKPj4gKyAg ICByZXR1cm4gSU9fSEFORExFRDsKPj4gICB9Cj4+ICAgCj4+IC1zdGF0aWMgaW50IGhhbmRsZV93 cml0ZShjb25zdCBzdHJ1Y3QgbW1pb19oYW5kbGVyICpoYW5kbGVyLCBzdHJ1Y3QgdmNwdSAqdiwK Pj4gLSAgICAgICAgICAgICAgICAgICAgICAgIG1taW9faW5mb190ICppbmZvKQo+PiArc3RhdGlj IGVudW0gaW9fc3RhdGUgaGFuZGxlX3dyaXRlKGNvbnN0IHN0cnVjdCBtbWlvX2hhbmRsZXIgKmhh bmRsZXIsCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IHZjcHUg KnYsCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbW1pb19pbmZvX3QgKmlu Zm8pCj4+ICAgewo+PiAgICAgICBjb25zdCBzdHJ1Y3QgaHNyX2RhYnQgZGFidCA9IGluZm8tPmRh YnQ7Cj4+ICAgICAgIHN0cnVjdCBjcHVfdXNlcl9yZWdzICpyZWdzID0gZ3Vlc3RfY3B1X3VzZXJf cmVncygpOwo+PiArICAgIGludCByZXQ7Cj4+ICAgCj4+IC0gICAgcmV0dXJuIGhhbmRsZXItPm9w cy0+d3JpdGUodiwgaW5mbywgZ2V0X3VzZXJfcmVnKHJlZ3MsIGRhYnQucmVnKSwKPj4gLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBoYW5kbGVyLT5wcml2KTsKPj4gKyAgICByZXQgPSBo YW5kbGVyLT5vcHMtPndyaXRlKHYsIGluZm8sIGdldF91c2VyX3JlZyhyZWdzLCBkYWJ0LnJlZyks Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBoYW5kbGVyLT5wcml2KTsKPj4gKyAg ICByZXR1cm4gKCByZXQgKSA/IElPX0hBTkRMRUQgOiBJT19BQk9SVDsKPj4gICB9Cj4+ICAgCj4+ ICAgLyogVGhpcyBmdW5jdGlvbiBhc3N1bWVzIHRoYXQgbW1pbyByZWdpb25zIGFyZSBub3Qgb3Zl cmxhcHBlZCAqLwo+PiBAQCAtMTAwLDE0ICsxMDQsMTQgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBt bWlvX2hhbmRsZXIgKmZpbmRfbW1pb19oYW5kbGVyKHN0cnVjdCBkb21haW4gKmQsCj4+ICAgICAg IHJldHVybiBoYW5kbGVyOwo+PiAgIH0KPj4gICAKPj4gLWludCBoYW5kbGVfbW1pbyhtbWlvX2lu Zm9fdCAqaW5mbykKPj4gK2VudW0gaW9fc3RhdGUgaGFuZGxlX21taW8obW1pb19pbmZvX3QgKmlu Zm8pCj4+ICAgewo+PiAgICAgICBzdHJ1Y3QgdmNwdSAqdiA9IGN1cnJlbnQ7Cj4+ICAgICAgIGNv bnN0IHN0cnVjdCBtbWlvX2hhbmRsZXIgKmhhbmRsZXIgPSBOVUxMOwo+PiAgIAo+PiAgICAgICBo YW5kbGVyID0gZmluZF9tbWlvX2hhbmRsZXIodi0+ZG9tYWluLCBpbmZvLT5ncGEpOwo+PiAgICAg ICBpZiAoICFoYW5kbGVyICkKPj4gLSAgICAgICAgcmV0dXJuIDA7Cj4+ICsgICAgICAgIHJldHVy biBJT19VTkhBTkRMRUQ7Cj4+ICAgCj4+ICAgICAgIGlmICggaW5mby0+ZGFidC53cml0ZSApCj4+ ICAgICAgICAgICByZXR1cm4gaGFuZGxlX3dyaXRlKGhhbmRsZXIsIHYsIGluZm8pOwo+PiBkaWZm IC0tZ2l0IGEveGVuL2FyY2gvYXJtL3RyYXBzLmMgYi94ZW4vYXJjaC9hcm0vdHJhcHMuYwo+PiBp bmRleCBjODUzNGQ2Y2ZmLi44NDNhZGY0OTU5IDEwMDY0NAo+PiAtLS0gYS94ZW4vYXJjaC9hcm0v dHJhcHMuYwo+PiArKysgYi94ZW4vYXJjaC9hcm0vdHJhcHMuYwo+PiBAQCAtMTg2NCwxMCArMTg2 NCwxMCBAQCBzdGF0aWMgaW5saW5lIGJvb2wgaHBmYXJfaXNfdmFsaWQoYm9vbCBzMXB0dywgdWlu dDhfdCBmc2MpCj4+ICAgICAgIHJldHVybiBzMXB0dyB8fCAoZnNjID09IEZTQ19GTFRfVFJBTlMg JiYgIWNoZWNrX3dvcmthcm91bmRfODM0MjIwKCkpOwo+PiAgIH0KPj4gICAKPj4gLXN0YXRpYyBi b29sIHRyeV9oYW5kbGVfbW1pbyhzdHJ1Y3QgY3B1X3VzZXJfcmVncyAqcmVncywKPj4gLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICBjb25zdCB1bmlvbiBoc3IgaHNyLAo+PiAtICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHBhZGRyX3QgZ3BhKQo+PiAtewo+PiArc3RhdGljIGVudW0gaW9f c3RhdGUgdHJ5X2hhbmRsZV9tbWlvKHN0cnVjdCBjcHVfdXNlcl9yZWdzICpyZWdzLAo+PiArICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHVuaW9uIGhzciBoc3IsCj4+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGFkZHJfdCBncGEpCj4+ICsg ewo+PiAgICAgICBjb25zdCBzdHJ1Y3QgaHNyX2RhYnQgZGFidCA9IGhzci5kYWJ0Owo+PiAgICAg ICBtbWlvX2luZm9fdCBpbmZvID0gewo+PiAgICAgICAgICAgLmdwYSA9IGdwYSwKPj4gQEAgLTE4 NzksMTEgKzE4NzksMTEgQEAgc3RhdGljIGJvb2wgdHJ5X2hhbmRsZV9tbWlvKHN0cnVjdCBjcHVf dXNlcl9yZWdzICpyZWdzLAo+PiAgIAo+PiAgICAgICAvKiBzdGFnZS0xIHBhZ2UgdGFibGUgc2hv dWxkIG5ldmVyIGxpdmUgaW4gYW4gZW11bGF0ZWQgTU1JTyByZWdpb24gKi8KPj4gICAgICAgaWYg KCBkYWJ0LnMxcHR3ICkKPj4gLSAgICAgICAgcmV0dXJuIGZhbHNlOwo+PiArICAgICAgICByZXR1 cm4gSU9fVU5IQU5ETEVEOwo+PiAgIAo+PiAgICAgICAvKiBBbGwgdGhlIGluc3RydWN0aW9ucyB1 c2VkIG9uIGVtdWxhdGVkIE1NSU8gcmVnaW9uIHNob3VsZCBiZSB2YWxpZCAqLwo+PiAgICAgICBp ZiAoICFkYWJ0LnZhbGlkICkKPj4gLSAgICAgICAgcmV0dXJuIGZhbHNlOwo+PiArICAgICAgICBy ZXR1cm4gSU9fVU5IQU5ETEVEOwo+PiAgIAo+PiAgICAgICAvKgo+PiAgICAgICAgKiBFcnJhdHVt IDc2NjQyMjogVGh1bWIgc3RvcmUgdHJhbnNsYXRpb24gZmF1bHQgdG8gSHlwZXJ2aXNvciBtYXkK Pj4gQEAgLTE4OTYsMTEgKzE4OTYsMTEgQEAgc3RhdGljIGJvb2wgdHJ5X2hhbmRsZV9tbWlvKHN0 cnVjdCBjcHVfdXNlcl9yZWdzICpyZWdzLAo+PiAgICAgICAgICAgaWYgKCByYyApCj4+ICAgICAg ICAgICB7Cj4+ICAgICAgICAgICAgICAgZ3ByaW50ayhYRU5MT0dfREVCVUcsICJVbmFibGUgdG8g ZGVjb2RlIGluc3RydWN0aW9uXG4iKTsKPj4gLSAgICAgICAgICAgIHJldHVybiBmYWxzZTsKPj4g KyAgICAgICAgICAgIHJldHVybiBJT19BQk9SVDsKPj4gICAgICAgICAgIH0KPj4gICAgICAgfQo+ IAo+IFdoeSBkbyB0aGUgZmlyc3QgdHdvIGVycm9yIGNoZWNrcyByZXN1bHQgaW4gSU9fVU5IQU5E TEVELCB3aGlsZSB0aGUKPiB0aGlyZCByZXN1bHQgaW4gSU9fQUJPUlQ/IFNwZWNpZmljYWxseSBp biByZWxhdGlvbiB0byBwYWdldGFibGUgd2Fsawo+IGZhaWx1cmVzIGR1ZSB0byBzb21lb25lIGVs c2UgY2hhbmdpbmcgc3RhZ2UtMiBlbnRyeSBzaW11bHRhbmVvdXNseSAoc2VlCj4gY29tbWVudCB0 b3dhcmQgdGhlIGVuZCBvZiBkb190cmFwX3N0YWdlMl9hYm9ydF9ndWVzdCk/CgpHb29kIHF1ZXN0 aW9uLiBTb21laG93IEkgY29uc2lkZXJlZCB0aGUgZmlyc3QgdHdvIGFzIHBhcnQgb2YgbG9va2lu ZyB1cCAKdGhlIHByb3BlciBoYW5kbGVyIGFuZCBub3QgdGhlIGRldmljZSBpdHNlbGYuCgpCdXQg SSBndWVzcyB0aGF0IGF0IHRoaXMgc3RhZ2Ugd2Uga25vdyB0aGF0IElPIHdhcyB0YXJnZXRpbmcg YW4gZW11bGF0ZWQgCnJlZ2lvbi4gU28gd2UgY2FuIHJldHVybiBJT19BQk9SVC4KCk9uIGEgc2lk ZSBub3RlLCBpdCBsb29rcyBsaWtlIHRoZSBjaGVjayBkYWJ0LnMxcHR3IGlzIHVubmVjZXNzYXJ5 IApiZWNhdXNlIGEgc3RhZ2UgMiBhYm9ydCBvbiBzdGFnZSAxIHRyYW5zbGF0aW9uIHRhYmxlIGxv b2t1cCB3aWxsIG5vdCAKcmV0dXJuIGEgdmFsaWQgaW5zdHJ1Y3Rpb24gc3luZHJvbWUgKHNlZSBC My0xNDMzIGluIERESSAwNDA2Qy5jIGFuZCAKRDEwLTI0NjAgaW4gRERJIDA0ODdDLmEpLgoKQ2hl ZXJzLAoKLS0gCkp1bGllbiBHcmFsbAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVu cHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZv L3hlbi1kZXZlbA==