From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: Re: [PATCH 5/5] xen/ARM: Restrict access to most HVM_PARAM's Date: Thu, 6 Sep 2018 10:40:25 +0000 Message-ID: References: <1536171124-27053-1-git-send-email-andrew.cooper3@citrix.com> <1536171124-27053-6-git-send-email-andrew.cooper3@citrix.com> <7b4f42e4-69ae-08f6-989f-b8e111d51419@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <7b4f42e4-69ae-08f6-989f-b8e111d51419@arm.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: 'Julien Grall' , Andrew Cooper , Xen-devel Cc: Stefano Stabellini , Wei Liu , Jan Beulich , Roger Pau Monne List-Id: xen-devel@lists.xenproject.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBKdWxpZW4gR3JhbGwgW21haWx0 bzpqdWxpZW4uZ3JhbGxAYXJtLmNvbV0NCj4gU2VudDogMDYgU2VwdGVtYmVyIDIwMTggMTE6MzcN Cj4gVG86IFBhdWwgRHVycmFudCA8UGF1bC5EdXJyYW50QGNpdHJpeC5jb20+OyBBbmRyZXcgQ29v cGVyDQo+IDxBbmRyZXcuQ29vcGVyM0BjaXRyaXguY29tPjsgWGVuLWRldmVsIDx4ZW4tZGV2ZWxA bGlzdHMueGVuLm9yZz4NCj4gQ2M6IEphbiBCZXVsaWNoIDxKQmV1bGljaEBzdXNlLmNvbT47IFdl aSBMaXUgPHdlaS5saXUyQGNpdHJpeC5jb20+OyBSb2dlcg0KPiBQYXUgTW9ubmUgPHJvZ2VyLnBh dUBjaXRyaXguY29tPjsgU3RlZmFubyBTdGFiZWxsaW5pDQo+IDxzc3RhYmVsbGluaUBrZXJuZWwu b3JnPg0KPiBTdWJqZWN0OiBSZTogW1BBVENIIDUvNV0geGVuL0FSTTogUmVzdHJpY3QgYWNjZXNz IHRvIG1vc3QgSFZNX1BBUkFNJ3MNCj4gDQo+IEhpIFBhdWwsDQo+IA0KPiBPbiAwNi8wOS8xOCAx MDoyOSwgUGF1bCBEdXJyYW50IHdyb3RlOg0KPiA+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0t LQ0KPiA+PiBGcm9tOiBBbmRyZXcgQ29vcGVyIFttYWlsdG86YW5kcmV3LmNvb3BlcjNAY2l0cml4 LmNvbV0NCj4gPj4gU2VudDogMDUgU2VwdGVtYmVyIDIwMTggMTk6MTINCj4gPj4gVG86IFhlbi1k ZXZlbCA8eGVuLWRldmVsQGxpc3RzLnhlbi5vcmc+DQo+ID4+IENjOiBBbmRyZXcgQ29vcGVyIDxB bmRyZXcuQ29vcGVyM0BjaXRyaXguY29tPjsgSmFuIEJldWxpY2gNCj4gPj4gPEpCZXVsaWNoQHN1 c2UuY29tPjsgV2VpIExpdSA8d2VpLmxpdTJAY2l0cml4LmNvbT47IFJvZ2VyIFBhdSBNb25uZQ0K PiA+PiA8cm9nZXIucGF1QGNpdHJpeC5jb20+OyBQYXVsIER1cnJhbnQgPFBhdWwuRHVycmFudEBj aXRyaXguY29tPjsNCj4gU3RlZmFubw0KPiA+PiBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJu ZWwub3JnPjsgSnVsaWVuIEdyYWxsIDxqdWxpZW4uZ3JhbGxAYXJtLmNvbT4NCj4gPj4gU3ViamVj dDogW1BBVENIIDUvNV0geGVuL0FSTTogUmVzdHJpY3QgYWNjZXNzIHRvIG1vc3QgSFZNX1BBUkFN J3MNCj4gPj4NCj4gPj4gQVJNIGN1cnJlbnRseSBoYXMgbm8gcmVzdHJpY3Rpb25zIG9uIHRvb2xz dGFjayBhbmQgZ3Vlc3QgYWNjZXNzIHRvIHRoZQ0KPiBlbnRpcmUNCj4gPj4gSFZNX1BBUkFNIGJs b2NrLiAgQXMgdGhlIHBhZ2luZy9tb25pdG9yL3NoYXJpbmcgZmVhdHVyZXMgYXJlbid0DQo+IHVu ZGVyDQo+ID4+IHNlY3VyaXR5DQo+ID4+IHN1cHBvcnQsIHRoaXMgZG9lc24ndCBuZWVkIGFuIFhT QS4NCj4gPj4NCj4gPj4gVGhlIENBTExCQUNLX0lSUSBhbmQge1NUT1JFLENPTlNPTEV9X3tQRk4s RVZUQ0hOfSBkZXRhaWxzDQo+IGV4cG9zZWQNCj4gPj4gcmVhZC1vbmx5IHRvDQo+ID4+IHRoZSBn dWVzdCwgd2hpbGUgdGhlICpfUklOR19QRk4gZGV0YWlscyBhcmUgcmVzdHJpY3RlZCB0byBvbmx5 IHRvb2xzdGFjaw0KPiA+PiBhY2Nlc3MuICBObyBvdGhlciBwYXJhbWV0ZXJzIGFyZSB1c2VkLg0K PiA+Pg0KPiA+PiBTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0Bj aXRyaXguY29tPg0KPiA+PiAtLS0NCj4gPj4gQ0M6IEphbiBCZXVsaWNoIDxKQmV1bGljaEBzdXNl LmNvbT4NCj4gPj4gQ0M6IFdlaSBMaXUgPHdlaS5saXUyQGNpdHJpeC5jb20+DQo+ID4+IENDOiBS b2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCj4gPj4gQ0M6IFBhdWwgRHVy cmFudCA8cGF1bC5kdXJyYW50QGNpdHJpeC5jb20+DQo+ID4+IENDOiBTdGVmYW5vIFN0YWJlbGxp bmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+ID4+IENDOiBKdWxpZW4gR3JhbGwgPGp1bGll bi5ncmFsbEBhcm0uY29tPg0KPiA+Pg0KPiA+PiBUaGlzIGlzIG9ubHkgY29tcGlsZSB0ZXN0ZWQs IGFuZCBiYXNlZCBvbiBteSByZWFkaW5nIG9mIHRoZSBzb3VyY2UuICBUaGVyZQ0KPiA+PiBtaWdo dCBiZSBvdGhlciBQQVJBTVMgbmVlZGluZyBpbmNsdWRpbmcuDQo+ID4+IC0tLQ0KPiA+PiAgIHhl bi9hcmNoL2FybS9odm0uYyB8IDYyDQo+ID4+ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKy0tLQ0KPiA+PiAgIDEgZmlsZSBjaGFuZ2VkLCA1OSBpbnNl cnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQ0KPiA+Pg0KPiA+PiBkaWZmIC0tZ2l0IGEveGVuL2Fy Y2gvYXJtL2h2bS5jIGIveGVuL2FyY2gvYXJtL2h2bS5jDQo+ID4+IGluZGV4IDc2YjI3YzkuLjM1 ODFiYTIgMTAwNjQ0DQo+ID4+IC0tLSBhL3hlbi9hcmNoL2FybS9odm0uYw0KPiA+PiArKysgYi94 ZW4vYXJjaC9hcm0vaHZtLmMNCj4gPj4gQEAgLTMxLDYgKzMxLDU3IEBADQo+ID4+DQo+ID4+ICAg I2luY2x1ZGUgPGFzbS9oeXBlcmNhbGwuaD4NCj4gPj4NCj4gPj4gK3N0YXRpYyBpbnQgaHZtX2Fs bG93X3NldF9wYXJhbShjb25zdCBzdHJ1Y3QgZG9tYWluICpkLCB1bnNpZ25lZCBpbnQNCj4gPj4g cGFyYW0pDQo+ID4+ICt7DQo+ID4+ICsgICAgc3dpdGNoICggcGFyYW0gKQ0KPiA+PiArICAgIHsN Cj4gPj4gKyAgICAgICAgLyoNCj4gPj4gKyAgICAgICAgICogVGhlIGZvbGxvd2luZyBwYXJhbWV0 ZXJzIGFyZSBpbnRlbmRlZCBmb3IgdG9vbHN0YWNrIHVzYWdlIG9ubHkuDQo+ID4+ICsgICAgICAg ICAqIFRoZXkgbWF5IG5vdCBiZSBzZXQgYnkgdGhlIGRvbWFpbi4NCj4gPj4gKyAgICAgICAgICov DQo+ID4+ICsgICAgY2FzZSBIVk1fUEFSQU1fQ0FMTEJBQ0tfSVJROg0KPiA+PiArICAgIGNhc2Ug SFZNX1BBUkFNX1NUT1JFX1BGTjoNCj4gPj4gKyAgICBjYXNlIEhWTV9QQVJBTV9TVE9SRV9FVlRD SE46DQo+ID4+ICsgICAgY2FzZSBIVk1fUEFSQU1fQ09OU09MRV9QRk46DQo+ID4+ICsgICAgY2Fz ZSBIVk1fUEFSQU1fQ09OU09MRV9FVlRDSE46DQo+ID4NCj4gPiBQcm9iYWJseSBzaG91bGQgcmVt b3ZlIHRoZSBFVlRDSE4gcGFyYW1zIGZyb20gdGhpcyBsaXN0IGFmdGVyIGZpeGluZyBwYXRjaA0K PiAjMy4NCj4gPg0KPiA+PiArICAgIGNhc2UgSFZNX1BBUkFNX1BBR0lOR19SSU5HX1BGTjoNCj4g Pj4gKyAgICBjYXNlIEhWTV9QQVJBTV9NT05JVE9SX1JJTkdfUEZOOg0KPiA+PiArICAgIGNhc2Ug SFZNX1BBUkFNX1NIQVJJTkdfUklOR19QRk46DQo+ID4+ICsgICAgICAgIHJldHVybiBkID09IGN1 cnJlbnQtPmRvbWFpbiA/IC1FUEVSTSA6IDA7DQo+ID4+ICsNCj4gPj4gKyAgICAgICAgLyogV3Jp dGVhYmxlIG9ubHkgYnkgWGVuLCBob2xlLCBkZXByZWNhdGVkLCBvciBvdXQtb2YtcmFuZ2UuICov DQo+ID4+ICsgICAgZGVmYXVsdDoNCj4gPj4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ID4+ ICsgICAgfQ0KPiA+PiArfQ0KPiA+PiArDQo+ID4+ICtzdGF0aWMgaW50IGh2bV9hbGxvd19nZXRf cGFyYW0oY29uc3Qgc3RydWN0IGRvbWFpbiAqZCwgdW5zaWduZWQgaW50DQo+ID4+IHBhcmFtKQ0K PiA+PiArew0KPiA+PiArICAgIHN3aXRjaCAoIHBhcmFtICkNCj4gPj4gKyAgICB7DQo+ID4+ICsg ICAgICAgIC8qIFRoZSBmb2xsb3dpbmcgcGFyYW1ldGVycyBjYW4gYmUgcmVhZCBieSB0aGUgZ3Vl c3QgYW5kIHRvb2xzdGFjay4NCj4gKi8NCj4gPj4gKyAgICBjYXNlIEhWTV9QQVJBTV9DQUxMQkFD S19JUlE6DQo+ID4+ICsgICAgY2FzZSBIVk1fUEFSQU1fU1RPUkVfUEZOOg0KPiA+PiArICAgIGNh c2UgSFZNX1BBUkFNX1NUT1JFX0VWVENITjoNCj4gPj4gKyAgICBjYXNlIEhWTV9QQVJBTV9DT05T T0xFX1BGTjoNCj4gPj4gKyAgICBjYXNlIEhWTV9QQVJBTV9DT05TT0xFX0VWVENITjoNCj4gPj4g KyAgICAgICAgcmV0dXJuIDA7DQo+ID4+ICsNCj4gPj4gKyAgICAgICAgLyoNCj4gPj4gKyAgICAg ICAgICogVGhlIGZvbGxvd2luZyBwYXJhbWV0ZXJzIGFyZSBpbnRlbmRlZCBmb3IgdG9vbHN0YWNr IHVzYWdlIG9ubHkuDQo+ID4+ICsgICAgICAgICAqIFRoZXkgbWF5IG5vdCBiZSByZWFkIGJ5IHRo ZSBkb21haW4uDQo+ID4+ICsgICAgICAgICAqLw0KPiA+PiArICAgIGNhc2UgSFZNX1BBUkFNX1BB R0lOR19SSU5HX1BGTjoNCj4gPj4gKyAgICBjYXNlIEhWTV9QQVJBTV9NT05JVE9SX1JJTkdfUEZO Og0KPiA+PiArICAgIGNhc2UgSFZNX1BBUkFNX1NIQVJJTkdfUklOR19QRk46DQo+ID4+ICsgICAg ICAgIHJldHVybiBkID09IGN1cnJlbnQtPmRvbWFpbiA/IC1FUEVSTSA6IDA7DQo+ID4+ICsNCj4g Pj4gKyAgICAgICAgLyogSG9sZSwgZGVwcmVjYXRlZCwgb3Igb3V0LW9mLXJhbmdlLiAqLw0KPiA+ PiArICAgIGRlZmF1bHQ6DQo+ID4+ICsgICAgICAgIHJldHVybiAtRUlOVkFMOw0KPiA+PiArICAg IH0NCj4gPj4gK30NCj4gPj4gKw0KPiA+PiAgIGxvbmcgZG9faHZtX29wKHVuc2lnbmVkIGxvbmcg b3AsIFhFTl9HVUVTVF9IQU5ETEVfUEFSQU0odm9pZCkNCj4gPj4gYXJnKQ0KPiA+PiAgIHsNCj4g Pj4gICAgICAgbG9uZyByYyA9IDA7DQo+ID4+IEBAIC00Niw5ICs5Nyw2IEBAIGxvbmcgZG9faHZt X29wKHVuc2lnbmVkIGxvbmcgb3AsDQo+ID4+IFhFTl9HVUVTVF9IQU5ETEVfUEFSQU0odm9pZCkg YXJnKQ0KPiA+PiAgICAgICAgICAgaWYgKCBjb3B5X2Zyb21fZ3Vlc3QoJmEsIGFyZywgMSkgKQ0K PiA+PiAgICAgICAgICAgICAgIHJldHVybiAtRUZBVUxUOw0KPiA+Pg0KPiA+PiAtICAgICAgICBp ZiAoIGEuaW5kZXggPj0gSFZNX05SX1BBUkFNUyApDQo+ID4+IC0gICAgICAgICAgICByZXR1cm4g LUVJTlZBTDsNCj4gPj4gLQ0KPiA+DQo+ID4gQVNTRVJUIGhlcmUuDQo+IA0KPiBJIGRvbid0IHRo aW5rIHRoaXMgd291bGQgYmUgY29ycmVjdC4gVGhpcyBpcyBhbiBpbnB1dCBmcm9tIHRoZSBndWVz dCwgc28NCj4gaWYgeW91IGRvIGZ1enppbmcgeW91IHdpbGwgZW5kIHVwIHRvIGdldCBhbiBoeXBl cnZpc29yIGNyYXNoIHJhdGhlciB0aGFuDQo+IHJldHVybmluZyBhbiBlcnJvci4NCg0KQWgsIHRy dWUuDQoNCj4gDQo+IEEgcG90ZW50aWFsIHBsYWNlIGZvciBhbiBBU1NFUlQgd291bGQgYmUganVz dCBiZWZvcmUgYWNjZXNzaW5nDQo+IGh2bS5wYXJhbXMuIEJ1dCB0aGVuLCB0ZWNobmljYWxseSB0 aGUgaW5kZXggc2hvdWxkIGhhdmUgYmVlbiBzYW5pdGl6ZWQNCj4gYnkgaHZtX2FsbG93X3tnZXQs c2V0fV9wYXJhbS4NCj4gDQoNClllcywgdGhhdCdzIHdoZXJlIEkgbWVhbnQgdG8gc3VnZ2VzdCBh ZGRpbmcgdGhlIEFTU0VSVC4gSSB3YW50ZWQgaXQgdG8gdmVyaWZ5IHRoYXQgc2FuaXRpemF0aW9u Lg0KDQogIFBhdWwNCg0KPiBDaGVlcnMsDQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3JhbGwNCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWls aW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVu cHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw=