From: Corneliu ZUZU <czuzu@bitdefender.com>
To: Razvan Cojocaru <rcojocaru@bitdefender.com>, xen-devel@lists.xen.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH 4/8] x86/vm-event/monitor: turn monitor_write_data.do_write into enum
Date: Fri, 1 Jul 2016 09:59:47 +0300 [thread overview]
Message-ID: <d16ae7f5-d984-ec80-3bcd-94e2ae9ad697@bitdefender.com> (raw)
In-Reply-To: <4b57d294-9d4d-0d13-507b-6c109c4afff1@bitdefender.com>
On 7/1/2016 9:53 AM, Razvan Cojocaru wrote:
> On 06/30/16 21:44, Corneliu ZUZU wrote:
>> After trapping a control-register write vm-event and -until- deciding if that
>> write is to be permitted or not (VM_EVENT_FLAG_DENY) and doing the actual write,
>> there cannot and should not be another trapped control-register write event.
>> That is, currently -only one- of the fields of monitor_write_data.do_write can
>> be true at any given moment and therefore it would be more appropriate to
>> replace those fields with an enum value.
>>
>> Signed-off-by: Corneliu ZUZU <czuzu@bitdefender.com>
>> ---
>> xen/arch/x86/hvm/hvm.c | 18 +++++++++++-------
>> xen/arch/x86/monitor.c | 37 ++++++++++++++++++-------------------
>> xen/arch/x86/vm_event.c | 25 ++-----------------------
>> xen/include/asm-x86/domain.h | 20 ++++++++++----------
>> 4 files changed, 41 insertions(+), 59 deletions(-)
> I'm not sure why neither Tamas' or my email address are in the CC list
> (I would have assumed either monitor.c or vm_event.c would trigger a
> response from get_maintainters.pl). In any case:
>
> Acked-by: Razvan Cojocaru <rcojocaru@bitdefender.com>
>
>
> Thanks,
> Razvan
>
I only now notice, it seems there's a problem with MAINTAINERS, the 2
files are listed:
F: xen/*/vm_event.c
F: xen/*/monitor.c
there and the listing should have been:
F: xen/arch/*/vm_event.c
F: xen/arch/*/monitor.c
Will submit a separate patch ASAP with that adjustment.
Corneliu.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-01 6:59 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 18:40 [PATCH 0/8] x86/vm-event: Adjustments & fixes Corneliu ZUZU
2016-06-30 18:41 ` [PATCH 1/8] x86/vm-event: proper vCPU-paused checks at resume Corneliu ZUZU
2016-07-01 7:14 ` Razvan Cojocaru
2016-07-01 16:51 ` Tamas K Lengyel
2016-06-30 18:42 ` [PATCH 2/8] x86/vmx_update_guest_cr: minor optimization Corneliu ZUZU
2016-06-30 18:43 ` [PATCH 3/8] x86/vm-event/monitor: relocate code-motion more appropriately Corneliu ZUZU
2016-07-01 7:54 ` Razvan Cojocaru
2016-07-04 10:22 ` Jan Beulich
2016-07-04 11:02 ` Corneliu ZUZU
2016-07-04 14:58 ` Jan Beulich
2016-07-04 16:00 ` Corneliu ZUZU
2016-07-04 16:12 ` Jan Beulich
2016-07-04 13:22 ` Razvan Cojocaru
2016-07-04 14:05 ` Jan Beulich
2016-07-04 14:16 ` Razvan Cojocaru
2016-07-04 14:35 ` Corneliu ZUZU
2016-06-30 18:44 ` [PATCH 4/8] x86/vm-event/monitor: turn monitor_write_data.do_write into enum Corneliu ZUZU
2016-07-01 6:53 ` Razvan Cojocaru
2016-07-01 6:59 ` Corneliu ZUZU [this message]
2016-07-04 12:37 ` Jan Beulich
2016-07-04 12:47 ` Corneliu ZUZU
2016-07-04 13:07 ` Jan Beulich
2016-07-04 13:21 ` Corneliu ZUZU
2016-07-04 14:08 ` Jan Beulich
2016-07-04 14:23 ` Razvan Cojocaru
2016-07-04 14:24 ` Corneliu ZUZU
2016-07-04 15:03 ` Jan Beulich
2016-07-04 15:10 ` Corneliu ZUZU
2016-06-30 18:45 ` [PATCH 5/8] x86/vm-event/monitor: don't compromise monitor_write_data on domain cleanup Corneliu ZUZU
2016-07-01 6:47 ` Razvan Cojocaru
2016-07-01 6:56 ` Corneliu ZUZU
2016-07-01 6:59 ` Razvan Cojocaru
2016-07-04 12:47 ` Jan Beulich
2016-07-04 13:03 ` Corneliu ZUZU
2016-07-04 13:11 ` Jan Beulich
2016-07-04 13:28 ` Corneliu ZUZU
2016-07-04 14:13 ` Jan Beulich
2016-07-04 14:31 ` Corneliu ZUZU
2016-07-04 15:09 ` Jan Beulich
2016-07-04 15:24 ` Corneliu ZUZU
2016-07-04 13:50 ` Razvan Cojocaru
2016-07-04 14:05 ` Corneliu ZUZU
2016-07-04 14:17 ` Jan Beulich
2016-07-04 14:21 ` Razvan Cojocaru
2016-07-04 15:07 ` Jan Beulich
2016-07-04 15:21 ` Corneliu ZUZU
2016-07-04 15:57 ` Jan Beulich
2016-07-04 16:09 ` Corneliu ZUZU
2016-07-04 16:16 ` Jan Beulich
2016-07-04 16:26 ` Corneliu ZUZU
2016-07-04 14:45 ` Corneliu ZUZU
2016-06-30 18:46 ` [PATCH 6/8] x86/vm_event_resume: surround VM_EVENT_REASON_MOV_TO_MSR w/ CONFIG_X86 Corneliu ZUZU
2016-07-01 7:02 ` Razvan Cojocaru
2016-06-30 18:47 ` [PATCH 7/8] minor fixes (formatting, comments, unused includes etc.) Corneliu ZUZU
2016-06-30 18:47 ` [PATCH 8/8] minor #include change Corneliu ZUZU
2016-07-01 6:56 ` Razvan Cojocaru
2016-07-01 7:02 ` Corneliu ZUZU
2016-07-01 7:31 ` Jan Beulich
2016-07-01 7:44 ` Corneliu ZUZU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d16ae7f5-d984-ec80-3bcd-94e2ae9ad697@bitdefender.com \
--to=czuzu@bitdefender.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=rcojocaru@bitdefender.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).