From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: Re: [PATCH v2] iommu / p2m: add a page_order parameter to iommu_map/unmap_page() Date: Tue, 30 Oct 2018 17:10:23 +0000 Message-ID: References: <20181029132928.13031-1-paul.durrant@citrix.com> <5BD881CD02000078001F6698@prv1-mh.provo.novell.com> <5BD88F4C02000078001F680E@prv1-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gHXXA-0003S1-Tc for xen-devel@lists.xenproject.org; Tue, 30 Oct 2018 17:10:28 +0000 In-Reply-To: <5BD88F4C02000078001F680E@prv1-mh.provo.novell.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: 'Jan Beulich' Cc: Kevin Tian , Stefano Stabellini , Wei Liu , Konrad Rzeszutek Wilk , Andrew Cooper , "Tim (Xen.org)" , George Dunlap , Julien Grall , Jun Nakajima , xen-devel , Ian Jackson List-Id: xen-devel@lists.xenproject.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+IEZyb206IEphbiBCZXVsaWNoIFttYWlsdG86 SkJldWxpY2hAc3VzZS5jb21dCj4gU2VudDogMzAgT2N0b2JlciAyMDE4IDE3OjA1Cj4gVG86IFBh dWwgRHVycmFudCA8UGF1bC5EdXJyYW50QGNpdHJpeC5jb20+Cj4gQ2M6IEp1bGllbiBHcmFsbCA8 anVsaWVuLmdyYWxsQGFybS5jb20+OyBBbmRyZXcgQ29vcGVyCj4gPEFuZHJldy5Db29wZXIzQGNp dHJpeC5jb20+OyBHZW9yZ2UgRHVubGFwIDxHZW9yZ2UuRHVubGFwQGNpdHJpeC5jb20+OyBJYW4K PiBKYWNrc29uIDxJYW4uSmFja3NvbkBjaXRyaXguY29tPjsgV2VpIExpdSA8d2VpLmxpdTJAY2l0 cml4LmNvbT47IEp1bgo+IE5ha2FqaW1hIDxqdW4ubmFrYWppbWFAaW50ZWwuY29tPjsgS2V2aW4g VGlhbiA8a2V2aW4udGlhbkBpbnRlbC5jb20+Owo+IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJl bGxpbmlAa2VybmVsLm9yZz47IHhlbi1kZXZlbCA8eGVuLQo+IGRldmVsQGxpc3RzLnhlbnByb2pl Y3Qub3JnPjsgS29ucmFkIFJ6ZXN6dXRlayBXaWxrCj4gPGtvbnJhZC53aWxrQG9yYWNsZS5jb20+ OyBUaW0gKFhlbi5vcmcpIDx0aW1AeGVuLm9yZz4KPiBTdWJqZWN0OiBSRTogW1BBVENIIHYyXSBp b21tdSAvIHAybTogYWRkIGEgcGFnZV9vcmRlciBwYXJhbWV0ZXIgdG8KPiBpb21tdV9tYXAvdW5t YXBfcGFnZSgpCj4gCj4gPj4+IE9uIDMwLjEwLjE4IGF0IDE3OjU2LCA8UGF1bC5EdXJyYW50QGNp dHJpeC5jb20+IHdyb3RlOgo+ID4+IEZyb206IEphbiBCZXVsaWNoIFttYWlsdG86SkJldWxpY2hA c3VzZS5jb21dCj4gPj4gU2VudDogMzAgT2N0b2JlciAyMDE4IDE2OjA4Cj4gPj4KPiA+PiA+Pj4g T24gMjkuMTAuMTggYXQgMTQ6MjksIDxwYXVsLmR1cnJhbnRAY2l0cml4LmNvbT4gd3JvdGU6Cj4g Pj4gPiAtLS0gYS94ZW4vY29tbW9uL2dyYW50X3RhYmxlLmMKPiA+PiA+ICsrKyBiL3hlbi9jb21t b24vZ3JhbnRfdGFibGUuYwo+ID4+ID4gQEAgLTExNDIsMTIgKzExNDIsMTQgQEAgbWFwX2dyYW50 X3JlZigKPiA+PiA+ICAgICAgICAgIHsKPiA+PiA+ICAgICAgICAgICAgICBpZiAoICEoa2luZCAm IE1BUEtJTkRfV1JJVEUpICkKPiA+PiA+ICAgICAgICAgICAgICAgICAgZXJyID0gaW9tbXVfbWFw X3BhZ2UobGQsIF9kZm4obWZuX3gobWZuKSksIG1mbiwKPiA+PiA+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgUEFHRV9PUkRFUl80SywKPiA+PiA+ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgSU9NTVVGX3JlYWRhYmxlIHwKPiA+PiBJT01NVUZfd3Jp dGFibGUpOwo+ID4+ID4gICAgICAgICAgfQo+ID4+ID4gICAgICAgICAgZWxzZSBpZiAoIGFjdF9w aW4gJiYgIW9sZF9waW4gKQo+ID4+ID4gICAgICAgICAgewo+ID4+ID4gICAgICAgICAgICAgIGlm ICggIWtpbmQgKQo+ID4+ID4gICAgICAgICAgICAgICAgICBlcnIgPSBpb21tdV9tYXBfcGFnZShs ZCwgX2RmbihtZm5feChtZm4pKSwgbWZuLAo+ID4+ID4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBQQUdFX09SREVSXzRLLAo+ID4+ID4gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBJT01NVUZfcmVhZGFibGUpOwo+ID4+ID4gICAgICAgICAgfQo+ID4+ ID4gICAgICAgICAgaWYgKCBlcnIgKQo+ID4+ID4gQEAgLTEzOTYsMTAgKzEzOTgsMTEgQEAgdW5t YXBfY29tbW9uKAo+ID4+ID4KPiA+PiA+ICAgICAgICAgIGtpbmQgPSBtYXBraW5kKGxndCwgcmQs IG9wLT5tZm4pOwo+ID4+ID4gICAgICAgICAgaWYgKCAha2luZCApCj4gPj4gPiAtICAgICAgICAg ICAgZXJyID0gaW9tbXVfdW5tYXBfcGFnZShsZCwgX2RmbihtZm5feChvcC0+bWZuKSkpOwo+ID4+ ID4gKyAgICAgICAgICAgIGVyciA9IGlvbW11X3VubWFwX3BhZ2UobGQsIF9kZm4obWZuX3gob3At Pm1mbikpLAo+ID4+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUEFHRV9P UkRFUl80Syk7Cj4gPj4gPiAgICAgICAgICBlbHNlIGlmICggIShraW5kICYgTUFQS0lORF9XUklU RSkgKQo+ID4+ID4gICAgICAgICAgICAgIGVyciA9IGlvbW11X21hcF9wYWdlKGxkLCBfZGZuKG1m bl94KG9wLT5tZm4pKSwgb3AtPm1mbiwKPiA+PiA+IC0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBJT01NVUZfcmVhZGFibGUpOwo+ID4+ID4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIFBBR0VfT1JERVJfNEssIElPTU1VRl9yZWFkYWJsZSk7Cj4gPj4gPgo+ID4+ID4g ICAgICAgICAgZG91YmxlX2d0X3VubG9jayhsZ3QsIHJndCk7Cj4gPj4KPiA+PiBJIGFtLCBidHcs IHVuY2VydGFpbiB0aGF0IHVzaW5nIFBBR0VfT1JERVJfNEsgaXMgY29ycmVjdCBoZXJlOgo+ID4+ IE90aGVyIHRoYW4gaW4gdGhlIElPTU1VIGNvZGUsIGdyYW50IHRhYmxlIGNvZGUgaXNuJ3QgdGll ZCB0byBhCj4gPj4gcGFydGljdWxhciBhcmNoaXRlY3R1cmUsIGFuZCBoZW5jZSBvdWdodCB0byB3 b3JrIGZpbmUgb24gYSBwb3J0Cj4gPj4gdG8gYW4gYXJjaGl0ZWN0dXJlIHdpdGggOGssIDE2aywg b3IgMzJrIHBhZ2VzLgo+ID4KPiA+IFdvdWxkIHlvdSBzdWdnZXN0IEkgYWRkIGFuIGFyY2ggc3Bl Y2lmaWMgI2RlZmluZSBmb3IgYSBncmFudCB0YWJsZSBwYWdlCj4gPiBvcmRlciBhbmQgdGhlbiB1 c2UgdGhhdD8KPiAKPiBObywgSSdkIHByZWZlciBpZiB5b3UgdXNlZCBsaXRlciAwIHplcm8gaGVy ZS4KPiAKCk9rLgoKPiA+PiA+IC0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2lvbW11LmMK PiA+PiA+ICsrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2lvbW11LmMKPiA+PiA+IEBAIC0z MDUsNDcgKzMwNSw3NiBAQCB2b2lkIGlvbW11X2RvbWFpbl9kZXN0cm95KHN0cnVjdCBkb21haW4g KmQpCj4gPj4gPiAgfQo+ID4+ID4KPiA+PiA+ICBpbnQgaW9tbXVfbWFwX3BhZ2Uoc3RydWN0IGRv bWFpbiAqZCwgZGZuX3QgZGZuLCBtZm5fdCBtZm4sCj4gPj4gPiAtICAgICAgICAgICAgICAgICAg IHVuc2lnbmVkIGludCBmbGFncykKPiA+PiA+ICsgICAgICAgICAgICAgICAgICAgdW5zaWduZWQg aW50IHBhZ2Vfb3JkZXIsIHVuc2lnbmVkIGludCBmbGFncykKPiA+PiA+ICB7Cj4gPj4gPiAgICAg IGNvbnN0IHN0cnVjdCBkb21haW5faW9tbXUgKmhkID0gZG9tX2lvbW11KGQpOwo+ID4+ID4gLSAg ICBpbnQgcmM7Cj4gPj4gPiArICAgIHVuc2lnbmVkIGxvbmcgaTsKPiA+PiA+Cj4gPj4gPiAgICAg IGlmICggIWlvbW11X2VuYWJsZWQgfHwgIWhkLT5wbGF0Zm9ybV9vcHMgKQo+ID4+ID4gICAgICAg ICAgcmV0dXJuIDA7Cj4gPj4gPgo+ID4+ID4gLSAgICByYyA9IGhkLT5wbGF0Zm9ybV9vcHMtPm1h cF9wYWdlKGQsIGRmbiwgbWZuLCBmbGFncyk7Cj4gPj4gPiAtICAgIGlmICggdW5saWtlbHkocmMp ICkKPiA+PiA+ICsgICAgQVNTRVJUKCEoZGZuX3goZGZuKSAmICgoMXVsIDw8IHBhZ2Vfb3JkZXIp IC0gMSkpKTsKPiA+PiA+ICsgICAgQVNTRVJUKCEobWZuX3gobWZuKSAmICgoMXVsIDw8IHBhZ2Vf b3JkZXIpIC0gMSkpKTsKPiA+PiA+ICsKPiA+PiA+ICsgICAgZm9yICggaSA9IDA7IGkgPCAoMXVs IDw8IHBhZ2Vfb3JkZXIpOyBpKysgKQo+ID4+ID4gICAgICB7Cj4gPj4gPiArICAgICAgICBpbnQg aWdub3JlZCwgZXJyID0gaGQtPnBsYXRmb3JtX29wcy0+bWFwX3BhZ2UoZCwKPiBkZm5fYWRkKGRm biwKPiA+PiBpKSwKPiA+PiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBtZm5fYWRkKG1mbiwKPiBpKSwKPiA+PiA+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmbGFncyk7Cj4gPj4gPiAr Cj4gPj4gPiArICAgICAgICBpZiAoIGxpa2VseSghZXJyKSApCj4gPj4gPiArICAgICAgICAgICAg Y29udGludWU7Cj4gPj4gPiArCj4gPj4gPiAgICAgICAgICBpZiAoICFkLT5pc19zaHV0dGluZ19k b3duICYmIHByaW50a19yYXRlbGltaXQoKSApCj4gPj4gPiAgICAgICAgICAgICAgcHJpbnRrKFhF TkxPR19FUlIKPiA+PiA+ICAgICAgICAgICAgICAgICAgICAgImQlZDogSU9NTVUgbWFwcGluZyBk Zm4gJSJQUklfZGZuIiB0byBtZm4KPiAlIlBSSV9tZm4iCj4gPj4gZmFpbGVkOiAlZFxuIiwKPiA+ PiA+IC0gICAgICAgICAgICAgICAgICAgZC0+ZG9tYWluX2lkLCBkZm5feChkZm4pLCBtZm5feCht Zm4pLCByYyk7Cj4gPj4gPiArICAgICAgICAgICAgICAgICAgIGQtPmRvbWFpbl9pZCwgZGZuX3go ZGZuX2FkZChkZm4sIGkpKSwKPiA+PiA+ICsgICAgICAgICAgICAgICAgICAgbWZuX3gobWZuX2Fk ZChtZm4sIGkpKSwgZXJyKTsKPiA+PiA+ICsKPiA+PiA+ICsgICAgICAgIHdoaWxlIChpLS0pCj4g Pj4gPiArICAgICAgICAgICAgLyogYXNzaWduIHRvIHNvbWV0aGluZyB0byBhdm9pZCBjb21waWxl ciB3YXJuaW5nICovCj4gPj4gPiArICAgICAgICAgICAgaWdub3JlZCA9IGhkLT5wbGF0Zm9ybV9v cHMtPnVubWFwX3BhZ2UoZCwgZGZuX2FkZChkZm4sCj4gaSkpOwo+ID4+Cj4gPj4gSG1tLCBhcyBz YWlkIG9uIHYxIC0gcGxlYXNlIHVzZSB0aGUgb3JpZ2luYWwgbW9kZSAod2hpbGUtaWYtY29udGlu dWUpCj4gPj4gaGVyZS4gVGhpcyBsZXRzIHlvdSBnZXQgYXdheSB3aXRob3V0IGEgbG9jYWwgdmFy aWFibGUgdGhhdCdzIG5ldmVyCj4gPj4gcmVhZCwgYW5kIHdoaWNoIGhlbmNlIGZ1dHVyZSBjb21w aWxlciB2ZXJzaW9ucyBtYXkgbGVnaXRpbWF0ZWx5IHdhcm4KPiA+PiBhYm91dC4KPiA+Pgo+ID4K PiA+IE9rLCBJIGNsZWFybHkgZG9uJ3QgdW5kZXJzdGFuZCB3aGF0IHlvdSBtZWFuIGJ5ICd3aGls ZS1pZi1jb250aW51ZScKPiB0aGVuLgo+ID4gQWJvdmUgSSBoYXZlIGZvci1pZi1jb250aW51ZSwg d2hpY2ggaXMgd2hhdCBJIHRob3VnaHQgeW91IHdhbnRlZC4gV2hhdAo+IGNvZGUKPiA+IHN0cnVj dHVyZSBhcmUgeW91IGFjdHVhbGx5IGxvb2tpbmcgZm9yPwo+IAo+IFRoZSBvbmUgeW91ciBwYXRj aCByZW1vdmVzIGVsc2V3aGVyZToKPiAKPiAtICAgICAgICAgICAgICAgICAgICAgICAgd2hpbGUg KCBpLS0gKQo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgLyogSWYgc3RhdGVtZW50IHRv IHNhdGlzZnkgX19tdXN0X2NoZWNrLiAqLwo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAg aWYgKCBpb21tdV91bm1hcF9wYWdlKHAybS0+ZG9tYWluLAo+IC0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRmbl9hZGQoZGZuLCBpKSkgKQo+IC0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwoKT2gsIG9rLiBUaGFua3MuIEkn bGwgY2hhbmdlIGl0LgoKICBQYXVsCgo+IAo+IEphbgoKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVs QGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1h bi9saXN0aW5mby94ZW4tZGV2ZWw=