From: Stewart Hildebrand <Stewart.Hildebrand@dornerworks.com>
To: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Cc: Julien Grall <julien.grall@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH] xen/arm: domain_builder: irq sanity check logic fix
Date: Tue, 28 Nov 2017 14:42:03 +0000 [thread overview]
Message-ID: <d3628bc5f8914628ad02c80f178ef9b2@dornerworks.com> (raw)
It's not possible for an irq to be both below 16 and greater/equal than 32.
Also fix the reference to linux documentation while we're at it.
Signed-off-by: Stewart Hildebrand <stewart.hildebrand@dornerworks.com>
---
xen/arch/arm/domain_build.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index c74f4dd..f50f8b9 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -501,9 +501,10 @@ static void set_interrupt_ppi(gic_interrupt_t interrupt, unsigned int irq,
{
__be32 *cells = interrupt;
- BUG_ON(irq < 16 && irq >= 32);
+ BUG_ON(irq < 16);
+ BUG_ON(irq >= 32);
- /* See linux Documentation/devictree/bindings/arm/gic.txt */
+ /* See linux Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt */
dt_set_cell(&cells, 1, 1); /* is a PPI */
dt_set_cell(&cells, 1, irq - 16); /* PPIs start at 16 */
dt_set_cell(&cells, 1, (cpumask << 8) | level);
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next reply other threads:[~2017-11-28 14:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 14:42 Stewart Hildebrand [this message]
2017-11-28 19:03 ` [PATCH] xen/arm: domain_builder: irq sanity check logic fix Julien Grall
2017-11-29 11:58 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3628bc5f8914628ad02c80f178ef9b2@dornerworks.com \
--to=stewart.hildebrand@dornerworks.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).