Re: [PATCH v3 35/38] arm/p2m: Adjust debug information to altp2m

[Sergej Proskurin <proskurin@sec.in.tum.de>]

Hi Julien,


On 09/12/2016 04:29 PM, Julien Grall wrote:
> Hello Sergej,
>
> On 16/08/16 23:17, Sergej Proskurin wrote:
>> Signed-off-by: Sergej Proskurin <proskurin@sec.in.tum.de>
>> ---
>> Cc: Stefano Stabellini <sstabellini@kernel.org>
>> Cc: Julien Grall <julien.grall@arm.com>
>> ---
>> v2: Dump p2m information of the hostp2m and all altp2m views.
>> ---
>>  xen/arch/arm/p2m.c | 20 ++++++++++++++++++++
>>  1 file changed, 20 insertions(+)
>>
>> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
>> index dea3038..86e2a1d 100644
>> --- a/xen/arch/arm/p2m.c
>> +++ b/xen/arch/arm/p2m.c
>> @@ -162,6 +162,26 @@ void dump_p2m_lookup(struct domain *d, paddr_t
>> addr)
>>
>>      dump_pt_walk(page_to_maddr(p2m->root), addr,
>>                   P2M_ROOT_LEVEL, P2M_ROOT_PAGES);
>> +    printk("\n");
>> +
>> +    if ( altp2m_active(d) )
>> +    {
>> +        unsigned int i;
>> +
>> +        for ( i = 0; i < MAX_ALTP2M; i++ )
>> +        {
>> +            if ( d->arch.altp2m_p2m[i] == NULL )
>> +                continue;
>> +
>> +            p2m = d->arch.altp2m_p2m[i];
>> +
>> +            printk("AP2M[%d] @ %p mfn:0x%lx\n",
>
> s/%d/%u/ as the p2m index is unsigned
> s/0x%lx/%#PRI_mfn/ because we should avoid open format from now.
>

Thank you.

>> +                    i, p2m->root, page_to_mfn(p2m->root));
>> +
>> +            dump_pt_walk(page_to_maddr(p2m->root), addr,
>> P2M_ROOT_LEVEL, P2M_ROOT_PAGES);
>> +            printk("\n");
>> +        }
>> +    }
>>  }
>>
>>  void p2m_save_state(struct vcpu *p)
>>

Cheers,
~Sergej

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel