From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Andres Lagar-Cavilla" <andres@lagarcavilla.org>
Subject: Re: [PATCH 1 of 4] Improve ring management for memory
	events
Date: Wed, 23 Nov 2011 10:52:48 -0800
Message-ID: <d78fe2c45f3dec05bb9d525ea3f06d6d.squirrel@webmail.lagarcavilla.org>
References: <patchbomb.1321307910@xdev.gridcentric.ca>
	<ee909e5a9d8555d7dd4d.1321307911@xdev.gridcentric.ca>
	<20111123183511.GA26144@aepfle.de>
Reply-To: andres@lagarcavilla.org
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20111123183511.GA26144@aepfle.de>
List-Unsubscribe: <http://lists.xensource.com/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Olaf Hering <olaf@aepfle.de>
Cc: andres@gridcentric.ca, xen-devel@lists.xensource.com, tim@xen.org, keir.xen@gmail.com, adin@gridcentric.ca
List-Id: xen-devel@lists.xenproject.org

Olaf,
> On Mon, Nov 14, Andres Lagar-Cavilla wrote:
>
> I will do a more complete review later, a few comments below.
>
>
>> +    free_requests = RING_FREE_REQUESTS(&med->front_ring);
>> +    if ( unlikely(free_requests < d->max_vcpus) )
>> +    {
>> +        /* This may happen during normal operation (hopefully not
>> often). */
>> +        gdprintk(XENLOG_INFO, "mem_event request slots for domain %d:
>> %d\n",
>> +                               d->domain_id, free_requests);
>
> What is the purpose of this printk? The ring can and does fillup quickly
> with paging.

Well, we can tone down printk's to be debug level. I don't think they're
unnecessary if they're made an optional debug tool.

Question: I have one vcpu, how do I fill up the ring quickly? (outside of
foreign mappings)

Andres
>
>
>> +    if ( mem_event_ring_free(d, med) == 0 )
>> +    {
>> +        /* This *may* happen, but only when foreign mappings generate
>> events. */
>> +        gdprintk(XENLOG_WARNING, "possible lost mem_event for domain
>> %d\n",
>> +                                 d->domain_id);
>
> This printk is not needed, callers have to try again.
>
> Olaf
>