xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] tools: remove some .o and binary files on clean
@ 2011-03-23 16:49 Ian Campbell
  2011-03-31 17:52 ` Ian Jackson
  0 siblings, 1 reply; 3+ messages in thread
From: Ian Campbell @ 2011-03-23 16:49 UTC (permalink / raw)
  To: xen-devel; +Cc: Ian Campbell

# HG changeset patch
# User Ian Campbell <ian.campbell@citrix.com>
# Date 1300898687 0
# Node ID d7d3aabffa1b70955ba347cfbe3869b9461374ee
# Parent  185126e8a8137b273b2d65c368f0836d8c6e461d
tools: remove some .o and binary files on clean

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

diff -r 185126e8a813 -r d7d3aabffa1b tools/xenmon/Makefile
--- a/tools/xenmon/Makefile	Wed Mar 23 16:30:00 2011 +0000
+++ b/tools/xenmon/Makefile	Wed Mar 23 16:44:47 2011 +0000
@@ -36,7 +36,9 @@ install: build
 
 .PHONY: clean
 clean:
-	rm -f  $(DEPS)
+	$(RM) -f $(DEPS)
+	$(RM) -f xenbaked xenbaked.o
+	$(RM) -f xentrace_setmake setmask.o
 
 xenbaked: xenbaked.o Makefile
 	$(CC) $(LDFLAGS) $< -o $@ $(LDLIBS)
diff -r 185126e8a813 -r d7d3aabffa1b tools/xenpmd/Makefile
--- a/tools/xenpmd/Makefile	Wed Mar 23 16:30:00 2011 +0000
+++ b/tools/xenpmd/Makefile	Wed Mar 23 16:44:47 2011 +0000
@@ -16,7 +16,7 @@ install: all
 
 .PHONY: clean
 clean:
-	$(RM) -f xenpmd $(DEPS)
+	$(RM) -f xenpmd xenpmd.o $(DEPS)
 
 xenpmd: xenpmd.o Makefile
 	$(CC) $(LDFLAGS) $< -o $@ $(LDLIBS)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] tools: remove some .o and binary files on clean
  2011-03-23 16:49 [PATCH] tools: remove some .o and binary files on clean Ian Campbell
@ 2011-03-31 17:52 ` Ian Jackson
  2011-04-01 10:26   ` Ian Campbell
  0 siblings, 1 reply; 3+ messages in thread
From: Ian Jackson @ 2011-03-31 17:52 UTC (permalink / raw)
  To: Ian Campbell; +Cc: xen-devel

Ian Campbell writes ("[Xen-devel] [PATCH] tools: remove some .o and binary files on clean"):
> diff -r 185126e8a813 -r d7d3aabffa1b tools/xenmon/Makefile
> --- a/tools/xenmon/Makefile	Wed Mar 23 16:30:00 2011 +0000
> +++ b/tools/xenmon/Makefile	Wed Mar 23 16:44:47 2011 +0000
> @@ -36,7 +36,9 @@ install: build
>  
>  .PHONY: clean
>  clean:
> -	rm -f  $(DEPS)
> +	$(RM) -f $(DEPS)
> +	$(RM) -f xenbaked xenbaked.o
> +	$(RM) -f xentrace_setmake setmask.o
>  
>  xenbaked: xenbaked.o Makefile

This patch is against something subtly different to xen-unstable.hg.

xen-unstable.hg contains this:

| clean:
|         rm -f $(BIN) $(DEPS)
|
|
| %: %.c Makefile

Differences include: presence of $(BIN) rather than two consecutive
spaces, and one or two blank lines.

Ian.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] tools: remove some .o and binary files on clean
  2011-03-31 17:52 ` Ian Jackson
@ 2011-04-01 10:26   ` Ian Campbell
  0 siblings, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2011-04-01 10:26 UTC (permalink / raw)
  To: Ian Jackson; +Cc: xen-devel@lists.xensource.com

On Thu, 2011-03-31 at 18:52 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[Xen-devel] [PATCH] tools: remove some .o and binary files on clean"):
> > diff -r 185126e8a813 -r d7d3aabffa1b tools/xenmon/Makefile
> > --- a/tools/xenmon/Makefile	Wed Mar 23 16:30:00 2011 +0000
> > +++ b/tools/xenmon/Makefile	Wed Mar 23 16:44:47 2011 +0000
> > @@ -36,7 +36,9 @@ install: build
> >  
> >  .PHONY: clean
> >  clean:
> > -	rm -f  $(DEPS)
> > +	$(RM) -f $(DEPS)
> > +	$(RM) -f xenbaked xenbaked.o
> > +	$(RM) -f xentrace_setmake setmask.o
> >  
> >  xenbaked: xenbaked.o Makefile
> 
> This patch is against something subtly different to xen-unstable.hg.
> 
> xen-unstable.hg contains this:
> 
> | clean:
> |         rm -f $(BIN) $(DEPS)
> |
> |
> | %: %.c Makefile
> 
> Differences include: presence of $(BIN) rather than two consecutive
> spaces, and one or two blank lines.

It depends on "tools: remove pattern matched linking rules", which
you've now applied I think. I guess this patch should have been part of
that little series, sorry for that.

Ian.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-04-01 10:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-23 16:49 [PATCH] tools: remove some .o and binary files on clean Ian Campbell
2011-03-31 17:52 ` Ian Jackson
2011-04-01 10:26   ` Ian Campbell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).