From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>, Wei Liu <wei.liu2@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 2/2] x86/pv: drop gate_op prefix in emul-gate-op.c
Date: Thu, 31 Aug 2017 13:36:13 +0100 [thread overview]
Message-ID: <d7f5fda4-9cf3-6f2e-37a7-ebba050576bc@citrix.com> (raw)
In-Reply-To: <59A8174E02000078001761D2@prv-mh.provo.novell.com>
On 31/08/17 13:03, Jan Beulich wrote:
>>>> On 31.08.17 at 13:45, <wei.liu2@citrix.com> wrote:
>> There is only one function gate_op_read that needs to be modified.
> I'm fine with it just being read() here, but I can see this being possibly
> controversial. Please double check that Andrew isn't entirely opposed
> to it. An alternative suggestion would then be read_mem().
I'm not opposed generally, but simply 'read' has a chance of angering
Coverity, because it has inbuilt models for most functions specified by
core standards like POSIX.
read_mem() would be better.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-08-31 12:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 11:45 [PATCH 0/2] x86/pv: drop unnecessary prefixes Wei Liu
2017-08-31 11:45 ` [PATCH 1/2] x86/pv: drop priv_op prefix in emul-priv-op.c Wei Liu
2017-08-31 12:02 ` Jan Beulich
2017-08-31 11:45 ` [PATCH 2/2] x86/pv: drop gate_op prefix in emul-gate-op.c Wei Liu
2017-08-31 12:03 ` Jan Beulich
2017-08-31 12:36 ` Andrew Cooper [this message]
2017-08-31 15:04 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7f5fda4-9cf3-6f2e-37a7-ebba050576bc@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).