From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH v2 03/13] iommu: make use of type-safe BFN and MFN in exported functions Date: Tue, 10 Jul 2018 17:13:00 +0100 Message-ID: References: <20180707110526.35822-1-paul.durrant@citrix.com> <20180707110526.35822-4-paul.durrant@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1fcvGE-00085g-6x for xen-devel@lists.xenproject.org; Tue, 10 Jul 2018 16:13:06 +0000 In-Reply-To: <20180707110526.35822-4-paul.durrant@citrix.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Paul Durrant , xen-devel@lists.xenproject.org Cc: Kevin Tian , Stefano Stabellini , Wei Liu , Jun Nakajima , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Julien Grall , Jan Beulich List-Id: xen-devel@lists.xenproject.org T24gMDcvMDcvMjAxOCAxMjowNSBQTSwgUGF1bCBEdXJyYW50IHdyb3RlOgo+IFRoaXMgcGF0Y2gg bW9kaWZpZXMgdGhlIGRlY2xhcmF0aW9uIG9mIHRoZSBlbnRyeSBwb2ludHMgdG8gdGhlIElPTU1V Cj4gc3ViLXN5c3RlbSB0byB1c2UgYmZuX3QgYW5kIG1mbl90IGluIHBsYWNlIG9mIHVuc2lnbmVk IGxvbmcuIEEgc3Vic2VxdWVudAo+IHBhdGNoIHdpbGwgc2ltaWxhcmx5IG1vZGlmeSB0aGUgbWV0 aG9kcyBpbiB0aGUgaW9tbXVfb3BzIHN0cnVjdHVyZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBQYXVs IER1cnJhbnQgPHBhdWwuZHVycmFudEBjaXRyaXguY29tPgo+IC0tLQo+IENjOiBKYW4gQmV1bGlj aCA8amJldWxpY2hAc3VzZS5jb20+Cj4gQ2M6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIz QGNpdHJpeC5jb20+Cj4gQ2M6IEdlb3JnZSBEdW5sYXAgPEdlb3JnZS5EdW5sYXBAZXUuY2l0cml4 LmNvbT4KPiBDYzogSWFuIEphY2tzb24gPGlhbi5qYWNrc29uQGV1LmNpdHJpeC5jb20+Cj4gQ2M6 IEtvbnJhZCBSemVzenV0ZWsgV2lsayA8a29ucmFkLndpbGtAb3JhY2xlLmNvbT4KPiBDYzogU3Rl ZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPgo+IENjOiBKdWxpZW4gR3Jh bGwgPGp1bGllbi5ncmFsbEBhcm0uY29tPgo+IENjOiBUaW0gRGVlZ2FuIDx0aW1AeGVuLm9yZz4K PiBDYzogV2VpIExpdSA8d2VpLmxpdTJAY2l0cml4LmNvbT4KPiBDYzogSnVuIE5ha2FqaW1hIDxq dW4ubmFrYWppbWFAaW50ZWwuY29tPgo+IENjOiBLZXZpbiBUaWFuIDxrZXZpbi50aWFuQGludGVs LmNvbT4KPiBDYzogR2VvcmdlIER1bmxhcCA8Z2VvcmdlLmR1bmxhcEBldS5jaXRyaXguY29tPgo+ IAo+IHYyOgo+ICAtIEFkZHJlc3NlZCBjb21tZW50cyBmcm9tIEphbi4KPiAgLSBVc2UgaW50ZXJt ZWRpYXRlICdmcmFtZScgdmFyaWFibGUgdG8gYXZvaWQgZGlyZWN0bHkgZW5jYXBzdWxhdGluZwo+ ICAgIG1mbiBvciBnZm4gdmFsdWVzIGFzIGJmbnMuCgpBIGNvdXBsZSBvZiBjb21tZW50cyBvbiBw YXJ0aWN1bGFyIGluc3RhbmNlcy4uLgoKPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L21tL3Ay bS5jIGIveGVuL2FyY2gveDg2L21tL3AybS5jCj4gaW5kZXggYzUzY2FiNDRkOS4uY2UxMmJjZmY0 MiAxMDA2NDQKPiAtLS0gYS94ZW4vYXJjaC94ODYvbW0vcDJtLmMKPiArKysgYi94ZW4vYXJjaC94 ODYvbW0vcDJtLmMKPiBAQCAtNzE0LDkgKzcxNCwxMiBAQCBwMm1fcmVtb3ZlX3BhZ2Uoc3RydWN0 IHAybV9kb21haW4gKnAybSwgdW5zaWduZWQgbG9uZyBnZm5fbCwgdW5zaWduZWQgbG9uZyBtZm4s Cj4gIAo+ICAgICAgICAgIGlmICggbmVlZF9pb21tdShwMm0tPmRvbWFpbikgKQo+ICAgICAgICAg IHsKPiArICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBmcmFtZSA9IG1mbjsKPiArICAgICAgICAg ICAgYmZuX3QgYmZuID0gX2JmbihmcmFtZSk7Cj4gKwo+ICAgICAgICAgICAgICBmb3IgKCBpID0g MDsgaSA8ICgxIDw8IHBhZ2Vfb3JkZXIpOyBpKysgKQo+ICAgICAgICAgICAgICB7Cj4gLSAgICAg ICAgICAgICAgICBpbnQgcmV0ID0gaW9tbXVfdW5tYXBfcGFnZShwMm0tPmRvbWFpbiwgbWZuICsg aSk7Cj4gKyAgICAgICAgICAgICAgICBpbnQgcmV0ID0gaW9tbXVfdW5tYXBfcGFnZShwMm0tPmRv bWFpbiwgYmZuX2FkZChiZm4sIGkpKTsKCkhhdmluZyBhICdiZm4nIHZhcmlhYmxlIGhlcmUgbWFr ZXMgc29tZSBzZW5zZSwgYmVjYXVzZSBvdGhlcndpc2UsIGlmIG1mbgpldmVyIGdldHMgdGhlIG1m bl90IHR5cGUsIHlvdSdsbCBoYXZlCgogIGlvbW11X3VubWFwX3BhZ2UoLi4uIF9iZm4obWZuX3go bWZuKStpKSk7CgpiZWluZyBhYmxlIHRvIHVzZSBiZm5fYWRkKCkgaXMgbXVjaCBjbGVhbmVyLiAg SSBkb24ndCB0aGluayB0aGUKaW50ZXJtZWRpYXRlICdmcmFtZScgdmFyaWFibGUgaW4gdGhlIGNh c2UsIHJlYWxseSBhZGRzIGFueXRoaW5nLgoKPiBkaWZmIC0tZ2l0IGEveGVuL2NvbW1vbi9ncmFu dF90YWJsZS5jIGIveGVuL2NvbW1vbi9ncmFudF90YWJsZS5jCj4gaW5kZXggZDI2MTBlMzIwYy4u ZDA5MjZkMTNlMCAxMDA2NDQKPiAtLS0gYS94ZW4vY29tbW9uL2dyYW50X3RhYmxlLmMKPiArKysg Yi94ZW4vY29tbW9uL2dyYW50X3RhYmxlLmMKPiBAQCAtMTEzMiw2ICsxMTMyLDggQEAgbWFwX2dy YW50X3JlZigKPiAgICAgIG5lZWRfaW9tbXUgPSBnbnR0YWJfbmVlZF9pb21tdV9tYXBwaW5nKGxk KTsKPiAgICAgIGlmICggbmVlZF9pb21tdSApCj4gICAgICB7Cj4gKyAgICAgICAgdW5zaWduZWQg bG9uZyBmcmFtZSA9IG1mbl94KG1mbik7Cj4gKyAgICAgICAgYmZuX3QgYmZuID0gX2JmbihmcmFt ZSk7Cj4gICAgICAgICAgdW5zaWduZWQgaW50IGtpbmQ7Cj4gICAgICAgICAgaW50IGVyciA9IDA7 Cj4gIAo+IEBAIC0xMTQ0LDE0ICsxMTQ2LDEzIEBAIG1hcF9ncmFudF9yZWYoCj4gICAgICAgICAg ICAgICAhKG9sZF9waW4gJiAoR05UUElOX2hzdHdfbWFza3xHTlRQSU5fZGV2d19tYXNrKSkgKQo+ ICAgICAgICAgIHsKPiAgICAgICAgICAgICAgaWYgKCAhKGtpbmQgJiBNQVBLSU5EX1dSSVRFKSAp Cj4gLSAgICAgICAgICAgICAgICBlcnIgPSBpb21tdV9tYXBfcGFnZShsZCwgbWZuX3gobWZuKSwg bWZuX3gobWZuKSwKPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIElPTU1V Rl9yZWFkYWJsZXxJT01NVUZfd3JpdGFibGUpOwo+ICsgICAgICAgICAgICAgICAgZXJyID0gaW9t bXVfbWFwX3BhZ2UobGQsIGJmbiwgbWZuLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgSU9NTVVGX3JlYWRhYmxlIHwgSU9NTVVGX3dyaXRhYmxlKTsKPiAgICAgICAgICB9 Cj4gICAgICAgICAgZWxzZSBpZiAoIGFjdF9waW4gJiYgIW9sZF9waW4gKQo+ICAgICAgICAgIHsK PiAgICAgICAgICAgICAgaWYgKCAha2luZCApCj4gLSAgICAgICAgICAgICAgICBlcnIgPSBpb21t dV9tYXBfcGFnZShsZCwgbWZuX3gobWZuKSwgbWZuX3gobWZuKSwKPiAtICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIElPTU1VRl9yZWFkYWJsZSk7Cj4gKyAgICAgICAgICAgICAg ICBlcnIgPSBpb21tdV9tYXBfcGFnZShsZCwgYmZuLCBtZm4sIElPTU1VRl9yZWFkYWJsZSk7CgpI ZXJlJ3MgYW4gZXhhbXBsZSB3aGVyZSBJIHRoaW5rIGhhdmluZyBhbiBleHRyYSB2YXJpYWJsZSBp cyBzb21ld2hhdApkYW5nZXJvdXMuICBCZWZvcmUgdGhpcyBjaGFuZ2UsIGl0J3Mgb2J2aW91cyB0 aGF0IHlvdSBoYXZlIGEgMToxCm1hcHBpbmc7IG5vdywgbG9va2luZyBqdXN0IGF0IHRoaXMgbGlu ZSwgaXQncyBub3Qgb2J2aW91cyB0aGF0IGJmbiA9PQptZm4uICBXb3JzZSwgdGhlcmUncyBhIHJp c2sgdGhhdCB0aGVyZSB3aWxsIGJlIHNvbWUgc29ydCBvZiBidWcKaW50cm9kdWNlZCB3aGljaCBj aGFuZ2VzIGJmbiwgc3VjaCB0aGF0IGJmbiAhPSBtZm4gYW55bW9yZS4KCklmIHlvdSBoYXZlIHRv IHVzZSBhbiBpbnRlcm1lZGlhdGUgdmFyaWFibGUgaGVyZSwgdGhpcyBzaG91bGQgYmUKCiAgaW9t bXVfbWFwX3BhZ2UoLi4uLCBfYmZuKGZyYW1lKSwgX21mbihmcmFtZSksIC4uLik7CgpCdXQgSSBy ZWFsbHkgdGhpbmsKCiAgaW9tbXVfbWFwX3BhZ2UoLi4uLCBfYmZuKG1mbl94KG1mbikpLCBtZm4s IC4uLik7CgptYWtlcyB0aGUgbW9zdCBzZW5zZSBoZXJlLgoKIC1HZW9yZ2UKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxp c3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVj dC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw=