From: Paul Durrant <Paul.Durrant@citrix.com>
To: 'Juergen Gross' <jgross@suse.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Cc: "sstabellini@kernel.org" <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Andrew Cooper <Andrew.Cooper3@citrix.com>,
"Tim (Xen.org)" <tim@xen.org>,
George Dunlap <George.Dunlap@citrix.com>,
"jbeulich@suse.com" <jbeulich@suse.com>,
Ian Jackson <Ian.Jackson@citrix.com>
Subject: Re: [PATCH v2 3/8] xen: delay allocation of grant table sub structures
Date: Wed, 6 Sep 2017 09:43:56 +0000 [thread overview]
Message-ID: <d8e79299388a4301b3ae5109f5f9d0cb@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <ffa52361-2c3e-b6d1-44a4-c23bc83ecfed@suse.com>
> -----Original Message-----
> From: Juergen Gross [mailto:jgross@suse.com]
> Sent: 06 September 2017 10:42
> To: Paul Durrant <Paul.Durrant@citrix.com>; xen-devel@lists.xen.org
> Cc: sstabellini@kernel.org; Wei Liu <wei.liu2@citrix.com>; George Dunlap
> <George.Dunlap@citrix.com>; Andrew Cooper
> <Andrew.Cooper3@citrix.com>; Ian Jackson <Ian.Jackson@citrix.com>; Tim
> (Xen.org) <tim@xen.org>; jbeulich@suse.com
> Subject: Re: [Xen-devel] [PATCH v2 3/8] xen: delay allocation of grant table
> sub structures
>
> On 06/09/17 10:44, Paul Durrant wrote:
> >> -----Original Message-----
> >> From: Xen-devel [mailto:xen-devel-bounces@lists.xen.org] On Behalf Of
> >> Juergen Gross
> >> Sent: 06 September 2017 09:26
> >> To: xen-devel@lists.xen.org
> >> Cc: Juergen Gross <jgross@suse.com>; sstabellini@kernel.org; Wei Liu
> >> <wei.liu2@citrix.com>; George Dunlap <George.Dunlap@citrix.com>;
> >> Andrew Cooper <Andrew.Cooper3@citrix.com>; Ian Jackson
> >> <Ian.Jackson@citrix.com>; Tim (Xen.org) <tim@xen.org>;
> >> jbeulich@suse.com
> >> Subject: [Xen-devel] [PATCH v2 3/8] xen: delay allocation of grant table
> sub
> >> structures
> >>
> >> Delay the allocation of the grant table sub structures in order to
> >> allow modifying parameters needed for sizing of these structures at a
> >> per domain basis. Either do it from gnttab_setup_table() or just
> >> before the domain is started the first time.
> >
> > Why does it need to be in two places? Could it not just be done on the first
> call to gnttab_grow_table()?
>
> Could be difficult for e.g. a xenstore domain: it might make use of
> the maptrack frames before that, so it would explode then.
>
> It should be possible, however, to move the call to grant_table_init()
> from gnttab_setup_table() to gnttab_grow_table().
>
Ok. Thanks,
Paul
>
> Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-09-06 9:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 8:26 [PATCH v2 0/8] xen: better grant v2 support Juergen Gross
2017-09-06 8:26 ` [PATCH v2 1/8] xen: move XENMAPSPACE_grant_table code into grant_table.c Juergen Gross
2017-09-06 8:34 ` Paul Durrant
2017-09-06 9:31 ` Juergen Gross
2017-09-06 10:04 ` Wei Liu
2017-09-06 8:26 ` [PATCH v2 2/8] xen: clean up grant_table.h Juergen Gross
2017-09-06 8:37 ` Paul Durrant
2017-09-06 10:11 ` Wei Liu
2017-09-06 10:12 ` Juergen Gross
2017-09-06 8:26 ` [PATCH v2 3/8] xen: delay allocation of grant table sub structures Juergen Gross
2017-09-06 8:44 ` Paul Durrant
2017-09-06 9:42 ` Juergen Gross
2017-09-06 9:43 ` Paul Durrant [this message]
2017-09-06 8:26 ` [PATCH v2 4/8] xen: make grant resource limits per domain Juergen Gross
2017-09-06 9:10 ` Paul Durrant
2017-09-06 9:42 ` Juergen Gross
2017-09-06 8:26 ` [PATCH v2 5/8] xen: double default grant frame limit for huge hosts Juergen Gross
2017-09-06 9:12 ` Paul Durrant
2017-09-06 8:26 ` [PATCH v2 6/8] xen: add new domctl hypercall to set grant table resource limits Juergen Gross
2017-09-06 9:17 ` Paul Durrant
2017-09-06 9:43 ` Juergen Gross
2017-09-06 8:26 ` [PATCH v2 7/8] libxc: add libxc support for setting " Juergen Gross
2017-09-06 8:26 ` [PATCH v2 8/8] libxl: add libxl " Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8e79299388a4301b3ae5109f5f9d0cb@AMSPEX02CL03.citrite.net \
--to=paul.durrant@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=George.Dunlap@citrix.com \
--cc=Ian.Jackson@citrix.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).