From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>, Jan Beulich <JBeulich@suse.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Juergen Schinker <ba1020@homie.homelinux.net>,
Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH for-4.8] ipxe: update to newer commit [and 1 more messages]
Date: Wed, 12 Oct 2016 10:09:44 -0400 [thread overview]
Message-ID: <d92caad7-103e-ec69-a5f9-06f74ba9cd25@oracle.com> (raw)
In-Reply-To: <22526.6120.714694.534307@mariner.uk.xensource.com>
On 10/12/2016 07:00 AM, Ian Jackson wrote:
> Ian Jackson writes ("Re: [Xen-devel] [PATCH for-4.8] ipxe: update to newer commit"):
>> That was eventually done. I'm not sure exactly when the change was
>> made. Does gcc -Wno-foo work properly on all the gcc's we care about ?
> Jan Beulich writes ("Re: [Xen-devel] [PATCH for-4.8] ipxe: update to newer commit"):
>> Just fyi I have run into an issue with -Wno-override-init use in Linux
>> 4.8 on gcc 4.1.x, so what you say doesn't appear to hold for all gcc
>> versions we permit to be used.
> Well, that answers my question above.
>
> I think the right approach is to:
>
> * Test -Wno-this-is-not-a-warning-option. If gcc accepts it,
> add -Wno-something to disable the nonnull check·
Back compatibility is in fact not a problem. These options would only be
passed on when gcc6+ is used
>
> * Review the misleading indentations and if there are only a few, fix
> them in a downstream patch. Or, if there are many, decide to
> tolerate them.
There are more warnings than just indentation and nonnull checks:
-Wno-nonnull-compare
-Wno-unused-const-variable
-Wno-misleading-indentation
-Wno-shift-negative-value
-Wno-array-bounds
(The last two flagged actual bugs that have been fixed upstream).
Some of the warnings can be addressed by backporting upstream patches
but there are a few for which backporting will involve much more code
movement than fixing the code ourselves.
-boris
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-10-12 14:08 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 12:50 [PATCH for-4.8] ipxe: update to newer commit Wei Liu
2016-10-10 15:34 ` Ian Jackson
2016-10-10 15:44 ` Wei Liu
2016-10-10 15:51 ` Ian Jackson
2016-10-10 16:33 ` Wei Liu
2016-10-10 17:38 ` Boris Ostrovsky
2016-10-11 9:40 ` Wei Liu
2016-10-11 9:52 ` Ian Jackson
2016-10-11 12:52 ` Boris Ostrovsky
2016-10-11 13:32 ` Ian Jackson
2016-10-11 14:27 ` Boris Ostrovsky
2016-10-11 14:54 ` Ian Jackson
2016-10-11 17:11 ` Boris Ostrovsky
2016-10-12 11:00 ` [PATCH for-4.8] ipxe: update to newer commit [and 1 more messages] Ian Jackson
2016-10-12 14:09 ` Boris Ostrovsky [this message]
2016-10-12 14:14 ` Wei Liu
2016-10-12 14:16 ` Ian Jackson
2016-10-12 7:45 ` [PATCH for-4.8] ipxe: update to newer commit Jan Beulich
2016-10-11 21:11 ` Andrew Cooper
2016-10-11 21:17 ` Andrew Cooper
2016-10-12 7:50 ` Jan Beulich
2016-10-10 18:28 ` Juergen Schinker
2016-10-11 9:37 ` Wei Liu
2016-10-11 9:42 ` Juergen Schinker
2016-10-11 9:45 ` Wei Liu
2016-10-11 19:31 ` Juergen Schinker
2016-10-11 19:45 ` Konrad Rzeszutek Wilk
2016-10-12 9:27 ` Wei Liu
2016-10-12 21:03 ` Boris Ostrovsky
2016-10-13 9:04 ` Wei Liu
2016-10-13 9:10 ` Juergen Schinker
2016-10-13 9:29 ` Wei Liu
2016-10-13 10:02 ` Juergen Schinker
2016-10-13 14:53 ` Wei Liu
[not found] ` <1633715062.155.1476375972276.JavaMail.zimbra@homie.homelinux.net>
2016-10-13 16:45 ` Wei Liu
2016-10-13 19:58 ` ANNOUNCEMENT] Xen 4.8 RC2 FULL SUCCESS 13.10.16 Juergen Schinker
2016-10-13 9:32 ` [PATCH for-4.8] ipxe: update to newer commit Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d92caad7-103e-ec69-a5f9-06f74ba9cd25@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=JBeulich@suse.com \
--cc=ba1020@homie.homelinux.net \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).