From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>,
xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com,
konrad.wilk@oracle.com
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH v2 1/4] tools/libacpi: add _FADT_ to the FADT boot flags definitions
Date: Fri, 2 Dec 2016 13:53:44 +0000 [thread overview]
Message-ID: <db39ce26-b12e-5901-c233-a0b81aa02f71@citrix.com> (raw)
In-Reply-To: <20161202134851.57483-2-roger.pau@citrix.com>
On 02/12/16 13:48, Roger Pau Monne wrote:
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> ---
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> Cc: boris.ostrovsky@oracle.com
> Cc: konrad.wilk@oracle.com
> ---
> tools/libacpi/acpi2_0.h | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/tools/libacpi/acpi2_0.h b/tools/libacpi/acpi2_0.h
> index 775eb7a..5ddef8a 100644
> --- a/tools/libacpi/acpi2_0.h
> +++ b/tools/libacpi/acpi2_0.h
> @@ -227,9 +227,8 @@ struct acpi_20_fadt {
> /*
> * FADT Boot Architecture Flags.
> */
> -#define ACPI_LEGACY_DEVICES (1 << 0)
> -#define ACPI_8042 (1 << 1)
> -
> +#define ACPI_FADT_LEGACY_DEVICES (1 << 0)
> +#define ACPI_FADT_8042 (1 << 1)
It would be better to retain the newline here, Otherwise, Reviewed-by:
Andrew Cooper <andrew.cooper3@citrix.com>
> /*
> * FADT Fixed Feature Flags.
> */
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-12-02 13:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 13:48 [PATCH v2 0/4] tools/libacpi: fix boot flags passed to PVHv2 guests Roger Pau Monne
2016-12-02 13:48 ` [PATCH v2 1/4] tools/libacpi: add _FADT_ to the FADT boot flags definitions Roger Pau Monne
2016-12-02 13:53 ` Andrew Cooper [this message]
2016-12-02 14:03 ` Roger Pau Monne
2016-12-02 17:15 ` Jan Beulich
2016-12-02 13:48 ` [PATCH v2 2/4] tools/libacpi: set FADT boot flag to notify lack of VGA for PVHv2 guests Roger Pau Monne
2016-12-02 13:57 ` Andrew Cooper
2016-12-02 13:48 ` [PATCH v2 3/4] tools/libacpi: don't announce a 8042 controller in the FADT " Roger Pau Monne
2016-12-02 14:01 ` Andrew Cooper
2016-12-02 13:48 ` [PATCH v2 4/4] tools/libacpi: announce that PVHv2 has no CMOS RTC in FADT Roger Pau Monne
2016-12-02 14:06 ` Andrew Cooper
2016-12-02 14:21 ` Boris Ostrovsky
2016-12-02 14:23 ` Andrew Cooper
2016-12-02 17:20 ` Jan Beulich
2016-12-02 17:32 ` Roger Pau Monne
2016-12-05 7:48 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db39ce26-b12e-5901-c233-a0b81aa02f71@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).