xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Stefano Stabellini <stefanos@xilinx.com>,
	andrii_anisov@epam.com, xen-devel@lists.xen.org
Subject: Re: [PATCH v3 25/25] xen/arm: split domain_build.c
Date: Thu, 16 Aug 2018 10:20:02 +0100	[thread overview]
Message-ID: <dbf9b7d3-b82c-47db-45d5-c0eabee4f232@arm.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1808151644360.15066@sstabellini-ThinkPad-X260>

Hi Stefano,

On 08/16/2018 01:25 AM, Stefano Stabellini wrote:
> On Mon, 13 Aug 2018, Julien Grall wrote:
>>> +
>>> +#ifndef CONFIG_ACPI
>>> +static inline int prepare_acpi(struct domain *d, struct kernel_info *kinfo)
>>> +{
>>> +    /* Only booting with ACPI will hit here */
>>> +    BUG();
>>> +    return -EINVAL;
>>> +}
>>> +#else
>>> +int prepare_acpi(struct domain *d, struct kernel_info *kinfo);
>>> +#endif
>>
>> This one should go in asm-arm/acpi.h.
>>
>> So this header is not necessary anymore.
> 
> I was unable to add prepare_acpi to asm-arm/acpi.h because it causes a
> #include dependency hell, I am thinking of adding it to asm-arm/domain_build.h.
> 
> In file included from /local/repos/xen-upstream/xen/include/xen/sched.h:11:0,
>                   from /local/repos/xen-upstream/xen/include/asm/domain.h:5,
>                   from /local/repos/xen-upstream/xen/include/asm/kernel.h:10,
>                   from /local/repos/xen-upstream/xen/include/asm/acpi.h:27,
>                   from /local/repos/xen-upstream/xen/include/acpi/platform/aclinux.h:58,
>                   from /local/repos/xen-upstream/xen/include/acpi/platform/acenv.h:142,
>                   from /local/repos/xen-upstream/xen/include/acpi/acpi.h:56,
>                   from /local/repos/xen-upstream/xen/include/xen/acpi.h:33,
>                   from pl011.c:307:
> /local/repos/xen-upstream/xen/include/xen/domain.h:59:31: error: ‘struct xen_domctl_createdomain’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
>                          struct xen_domctl_createdomain *config);

Xen Arm headers are a bit a mess. :/

It looks like create_dom0 lives in setup.h, would it be possible to move 
the prototypes there?

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-08-16  9:20 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-31 23:27 [PATCH v3 00/25] dom0less step1: boot multiple domains from device tree Stefano Stabellini
2018-07-31 23:27 ` [PATCH v3 01/25] xen: allow console_io hypercalls from certain DomUs Stefano Stabellini
2018-08-17 19:33   ` Daniel De Graaf
2018-07-31 23:27 ` [PATCH v3 02/25] xen/arm: move a few DT related defines to public/device_tree_defs.h Stefano Stabellini
2018-08-01  9:31   ` Julien Grall
2018-08-22 15:25     ` Wei Liu
2018-07-31 23:27 ` [PATCH v3 03/25] xen/arm: extend device tree based multiboot protocol Stefano Stabellini
2018-07-31 23:27 ` [PATCH v3 04/25] xen/arm: document dom0less Stefano Stabellini
2018-08-01  9:46   ` Julien Grall
2018-10-03 16:47     ` Stefano Stabellini
2018-07-31 23:27 ` [PATCH v3 05/25] xen/arm: do not pass dt_host to make_memory_node and make_hypervisor_node Stefano Stabellini
2018-08-01  9:50   ` Julien Grall
2018-07-31 23:27 ` [PATCH v3 06/25] xen/arm: move evtchn_allocate call out of make_hypervisor_node Stefano Stabellini
2018-08-01  9:51   ` Julien Grall
2018-07-31 23:27 ` [PATCH v3 07/25] xen/arm: rename acpi_make_chosen_node to make_chosen_node Stefano Stabellini
2018-08-01  9:53   ` Julien Grall
2018-07-31 23:27 ` [PATCH v3 08/25] xen/arm: increase MAX_MODULES Stefano Stabellini
2018-07-31 23:27 ` [PATCH v3 09/25] xen/arm: introduce bootcmdlines Stefano Stabellini
2018-08-01 10:51   ` Julien Grall
2018-10-03 23:11     ` Stefano Stabellini
2018-10-04 17:23       ` Julien Grall
2018-10-04 21:08         ` Stefano Stabellini
2018-07-31 23:27 ` [PATCH v3 10/25] xen/arm: don't add duplicate boot modules Stefano Stabellini
2018-08-01 11:06   ` Julien Grall
2018-10-04 21:05     ` Stefano Stabellini
2018-07-31 23:27 ` [PATCH v3 11/25] xen/arm: probe domU kernels and initrds Stefano Stabellini
2018-07-31 23:27 ` [PATCH v3 12/25] xen/arm: refactor construct_dom0 Stefano Stabellini
2018-08-13 10:15   ` Julien Grall
2018-08-15 19:27     ` Stefano Stabellini
2018-07-31 23:27 ` [PATCH v3 13/25] xen/arm: introduce create_domUs Stefano Stabellini
2018-08-01  8:48   ` Jan Beulich
2018-08-13 10:23   ` Julien Grall
2018-08-15 19:37     ` Stefano Stabellini
2018-08-13 10:55   ` Julien Grall
2018-08-15 20:04     ` Stefano Stabellini
2018-08-16  9:03       ` Julien Grall
2018-08-16 18:20         ` Stefano Stabellini
2018-07-31 23:27 ` [PATCH v3 14/25] xen/arm: introduce construct_domU Stefano Stabellini
2018-08-13 10:55   ` Julien Grall
2018-08-15 20:21     ` Stefano Stabellini
2018-07-31 23:27 ` [PATCH v3 15/25] xen/arm: rename get_11_allocation_size to get_allocation_size Stefano Stabellini
2018-07-31 23:27 ` [PATCH v3 16/25] xen/arm: rename allocate_memory to allocate_memory_11 Stefano Stabellini
2018-08-13 10:57   ` Julien Grall
2018-08-15 20:26     ` Stefano Stabellini
2018-08-16  9:08       ` Julien Grall
2018-08-16 18:27         ` Stefano Stabellini
2018-07-31 23:28 ` [PATCH v3 17/25] xen/arm: introduce allocate_memory Stefano Stabellini
2018-08-01 11:28   ` Julien Grall
2018-10-03 17:46     ` Stefano Stabellini
2018-07-31 23:28 ` [PATCH v3 18/25] xen/arm: generate a simple device tree for domUs Stefano Stabellini
2018-08-13 11:07   ` Julien Grall
2018-08-15 20:47     ` Stefano Stabellini
2018-07-31 23:28 ` [PATCH v3 19/25] xen/arm: generate vpl011 node on device tree for domU Stefano Stabellini
2018-08-13 11:20   ` Julien Grall
2018-08-15 23:23     ` Stefano Stabellini
2018-07-31 23:28 ` [PATCH v3 20/25] xen/arm: introduce a union in vpl011 Stefano Stabellini
2018-08-13 11:24   ` Julien Grall
2018-08-15 23:36     ` Stefano Stabellini
2018-07-31 23:28 ` [PATCH v3 21/25] xen/arm: refactor vpl011_data_avail Stefano Stabellini
2018-08-13 13:23   ` Julien Grall
2018-07-31 23:28 ` [PATCH v3 22/25] xen/arm: Allow vpl011 to be used by DomU Stefano Stabellini
2018-08-13 13:42   ` Julien Grall
2018-08-15 23:41     ` Stefano Stabellini
2018-08-13 14:10   ` Julien Grall
2018-08-16 19:21     ` Stefano Stabellini
2018-08-22 10:19       ` Julien Grall
2018-10-03 21:21         ` Stefano Stabellini
2018-10-04 17:17           ` Julien Grall
2018-07-31 23:28 ` [PATCH v3 23/25] xen: support console_switching between Dom0 and DomUs on ARM Stefano Stabellini
2018-08-01  9:03   ` Jan Beulich
2018-10-04 21:52     ` Stefano Stabellini
2018-10-05  9:25       ` Julien Grall
2018-10-05  9:48         ` Julien Grall
2018-10-05 18:39           ` Stefano Stabellini
2018-10-05 18:39         ` Stefano Stabellini
2018-08-13 13:58   ` Julien Grall
2018-08-16 21:48     ` Stefano Stabellini
2018-07-31 23:28 ` [PATCH v3 24/25] xen/vpl011: buffer out chars when the backend is xen Stefano Stabellini
2018-08-13 14:21   ` Julien Grall
2018-08-16 19:41     ` Stefano Stabellini
2018-08-22 10:35       ` Julien Grall
2018-10-04 21:29         ` Stefano Stabellini
2018-07-31 23:28 ` [PATCH v3 25/25] xen/arm: split domain_build.c Stefano Stabellini
2018-08-13 14:29   ` Julien Grall
2018-08-16  0:25     ` Stefano Stabellini
2018-08-16  9:20       ` Julien Grall [this message]
2018-08-16 18:12         ` Stefano Stabellini
2018-08-22 15:44 ` [PATCH v3 00/25] dom0less step1: boot multiple domains from device tree Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dbf9b7d3-b82c-47db-45d5-c0eabee4f232@arm.com \
    --to=julien.grall@arm.com \
    --cc=andrii_anisov@epam.com \
    --cc=sstabellini@kernel.org \
    --cc=stefanos@xilinx.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).