From: Julien Grall <julien.grall@linaro.org>
To: manish.jaggi@linaro.org, xen-devel@lists.xenproject.org,
sameer.goel@linaro.org, andre.przywara@linaro.org
Cc: Jan Beulich <JBeulich@suse.com>, manish.jaggi@cavium.com
Subject: Re: [RFC 08/11] Add ACPI_IORT config
Date: Thu, 18 Jan 2018 19:01:27 +0000 [thread overview]
Message-ID: <dc15bb25-57f1-5fee-e1e3-77de7bf75c24@linaro.org> (raw)
In-Reply-To: <20180102092809.1841-9-manish.jaggi@linaro.org>
Hi Manish,
The usual scripts/get_maintainers.pl.
On 02/01/18 09:28, manish.jaggi@linaro.org wrote:
> From: Manish Jaggi <manish.jaggi@linaro.org>
>
> Add ACPI_IORT config
>
> Singed-off-by: Manish Jaggi <manish.jaggi@linaro.org>
> ---
> xen/arch/arm/Kconfig | 5 +++++
> xen/drivers/acpi/Kconfig | 3 +++
> 2 files changed, 8 insertions(+)
>
> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> index f58019d6ed..d4767d6ea3 100644
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -42,6 +42,11 @@ config ACPI
> Advanced Configuration and Power Interface (ACPI) support for Xen is
> an alternative to device tree on ARM64.
>
> +config ACPI_IORT
> + bool
> + prompt "ACPI IORT Support" if EXPERT = "y"
No need for EXPERT here. It will get picked up by ACPI.
Also, I don't think it is useful to let the user disabling IORT. You
either need all ACPI or not. It will get into trouble if IORT is not
handled in Xen.
Note that I am happy to see the config ACPI_IORT here. But not exposed
to user's choice.
> + depends on ACPI
> +
> config HAS_GICV3
> bool
>
> diff --git a/xen/drivers/acpi/Kconfig b/xen/drivers/acpi/Kconfig
> index b64d3731fb..15ae98140c 100644
> --- a/xen/drivers/acpi/Kconfig
> +++ b/xen/drivers/acpi/Kconfig
> @@ -5,5 +5,8 @@ config ACPI
> config ACPI_LEGACY_TABLES_LOOKUP
> bool
>
> +config ACPI_IORT
> + bool
I am not sure to understand why you define ACPI_IORT again here. It is
already done above?
However, I don't think it is necessary to have a separate patch just for
adding the Kconfig. You can fold into the patch that is first using it.
BTW, I would have expected this to be patch #1 and used to gate
compilation for any of those file.
> +
> config NUMA
> bool
>
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-01-18 19:01 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 9:27 [RFC 00/11] acpi: arm: IORT Support for Xen manish.jaggi
2018-01-02 9:27 ` [RFC 01/11] acpi: arm: Public API for populating and query based on requesterid manish.jaggi
2018-01-16 17:53 ` Julien Grall
2018-01-16 18:31 ` Julien Grall
2018-01-19 6:05 ` Manish Jaggi
2018-01-19 12:03 ` Julien Grall
2018-01-22 5:07 ` Manish Jaggi
2018-01-22 13:40 ` Julien Grall
2018-01-02 9:28 ` [RFC 02/11] acpi: arm: API to query estimated size of hardware domain's IORT manish.jaggi
2018-01-16 18:52 ` Julien Grall
2018-01-19 6:10 ` Manish Jaggi
2018-01-22 13:45 ` Julien Grall
2018-01-02 9:28 ` [RFC 03/11] acpi: arm: Code to generate Hardware Domains IORT manish.jaggi
2018-01-18 18:32 ` Julien Grall
2018-01-02 9:28 ` [RFC 04/11] Import iort.c and acpi_iort.h manish.jaggi
2018-01-02 9:28 ` [RFC 05/11] Import fwnode.h from linux manish.jaggi
2018-01-02 9:28 ` [RFC 06/11] fwnode xen spacific changes manish.jaggi
2018-01-18 18:51 ` Julien Grall
2018-03-06 10:27 ` Manish Jaggi
2018-03-06 14:29 ` Julien Grall
2018-03-06 13:43 ` Manish Jaggi
2018-03-06 13:44 ` Manish Jaggi
2018-03-06 14:22 ` Julien Grall
2018-01-02 9:28 ` [RFC 07/11] Add kernel helper functions manish.jaggi
2018-01-18 18:55 ` Julien Grall
2018-01-19 9:33 ` Jan Beulich
2018-02-08 21:56 ` Sameer Goel
2018-01-02 9:28 ` [RFC 08/11] Add ACPI_IORT config manish.jaggi
2018-01-18 19:01 ` Julien Grall [this message]
2018-01-02 9:28 ` [RFC 09/11] Xen IORT Changes manish.jaggi
2018-01-18 19:10 ` Julien Grall
2018-01-02 9:28 ` [RFC 10/11] IORT parsing functions to prepare requesterId maps manish.jaggi
2018-01-02 9:28 ` [RFC 11/11] Add to_pci_dev macro manish.jaggi
2018-01-18 19:15 ` Julien Grall
2018-02-08 21:54 ` Sameer Goel
2018-01-16 17:53 ` [RFC 00/11] acpi: arm: IORT Support for Xen Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc15bb25-57f1-5fee-e1e3-77de7bf75c24@linaro.org \
--to=julien.grall@linaro.org \
--cc=JBeulich@suse.com \
--cc=andre.przywara@linaro.org \
--cc=manish.jaggi@cavium.com \
--cc=manish.jaggi@linaro.org \
--cc=sameer.goel@linaro.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).