From: George Dunlap <george.dunlap@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Julien Grall <julien.grall@arm.com>
Subject: Re: [PATCH] x86/mm: silence a pointless warning
Date: Tue, 2 May 2017 18:04:13 +0100 [thread overview]
Message-ID: <dd14fed7-dfcd-a7b0-328b-ca00f38ef460@citrix.com> (raw)
In-Reply-To: <5908BECC0200007800155EE5@prv-mh.provo.novell.com>
On 02/05/17 16:15, Jan Beulich wrote:
> get_page() logs a message when it fails (dom_cow is never dying or
> paging_mode_external()), so better avoid the call when it's pointless
> to do anyway.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
The other option would be to add "domain == dom_cow" as a condition for
which get_page() doesn't report an error.
But on the whole I think this is probably the better option:
Acked-by: George Dunlap <george.dunlap@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-05-02 17:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 15:15 [PATCH] x86/mm: silence a pointless warning Jan Beulich
2017-05-02 15:31 ` Jan Beulich
2017-05-02 16:54 ` George Dunlap
2017-05-03 7:25 ` Jan Beulich
2017-05-02 17:04 ` George Dunlap [this message]
2017-05-03 7:31 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd14fed7-dfcd-a7b0-328b-ca00f38ef460@citrix.com \
--to=george.dunlap@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien.grall@arm.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).