From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Julien Grall <julien.grall@arm.com>, Xen-devel <xen-devel@lists.xen.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Tim Deegan <tim@xen.org>, Jan Beulich <JBeulich@suse.com>,
Ian Jackson <ian.jackson@citrix.com>
Subject: Re: [PATCH v2] xen/timers: Fix memory leak with cpu unplug/plug
Date: Mon, 8 Apr 2019 11:47:17 +0100 [thread overview]
Message-ID: <ddb84ed5-b986-a9eb-be71-e3d0b5060cad@citrix.com> (raw)
In-Reply-To: <5394e8aa-bae4-8a27-327a-b0dcd0996477@arm.com>
On 08/04/2019 11:39, Julien Grall wrote:
> Hi,
>
> On 4/8/19 10:39 AM, Andrew Cooper wrote:
>> + case CPU_RESUME_FAILED:
>> + if ( !park_offline_cpus && system_state != SYS_STATE_suspend )
>
> This patch breaks compilation on arm32/arm64 because park_offline_cpus
> is not defined:
>
> timer.c: In function 'cpu_callback':
> timer.c:651:15: error: 'park_offline_cpus' undeclared (first use in
> this function)
> if ( !park_offline_cpus && system_state != SYS_STATE_suspend )
> ^~~~~~~~~~~~~~~~~
>
> What is the purpose of park_offline_cpus?
Sorry. I should have waited for a full build test first.
park_offline_cpus is a workaround for Intel's MCE behaviour, where the
system will shut down rather than deliver an #MC if machine checking
isn't configured on all CPUs.
As a result, we have to start all CPUs, even beyond maxcpus= and set up
machine check handling, and never ever free their stacks, even if we'd
prefer the CPUs to be offline.
Are you happy with a
#define park_offline_cpus false
in ARM?
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-04-08 10:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 9:39 [PATCH v2] xen/timers: Fix memory leak with cpu unplug/plug Andrew Cooper
2019-04-08 9:56 ` Jan Beulich
2019-04-08 10:39 ` Julien Grall
2019-04-08 10:47 ` Andrew Cooper [this message]
2019-04-08 11:38 ` Julien Grall
2019-04-08 12:09 ` Andrew Cooper
2019-04-08 13:53 ` Julien Grall
2019-04-08 14:33 ` Andrew Cooper
2019-04-08 16:16 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddb84ed5-b986-a9eb-be71-e3d0b5060cad@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=ian.jackson@citrix.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).