Re: Crash during boot in Debian lenny default dom0 kernel (2.6.26-2-xen-686)

[George Dunlap <George.Dunlap@eu.citrix.com>]

(Jeremy: Discussing the default Lenny dom0 package, 2.6.26-2-xen--686
crashing during boot if MSIs are available.)

Sure enough, the structure it's using looks like this:

struct physdev_map_pirq {
    domid_t domid;
    /* IN */
    int type;
    /* IN */
    int index;
    /* IN or OUT */
    int pirq;
    /* IN */
    struct {
        int bus, devfn, entry_nr;
        int msi;  /* 0 - MSIX    1 - MSI */
    } msi_info;
};

The code in question came from a patch called
suse-20080808143035.patch; reading the numbers as the timestamp "2008
August 8" would seem to match up with the 3.3 dev lifecycle.

Any suggestions for a simple fix I can try to push upstream?

 -George

On Thu, Feb 25, 2010 at 11:46 AM, George Dunlap
<George.Dunlap@eu.citrix.com> wrote:
> I'm looking at the debian source package for this kernel to see if I
> can sort out where it got the header from.
>
> Given that this is already in a major distribution, is there any way
> we can fail gracefully if someone's running this kernel?  I'm not
> familiar enough with the MSI to know if this is possible, or what a
> good set of "sanity checks" would be for failing the hypercall.
>
>  -George
>
> On Thu, Feb 25, 2010 at 10:56 AM, Jan Beulich <JBeulich@novell.com> wrote:
>>>>> George Dunlap <George.Dunlap@eu.citrix.com> 25.02.10 11:48 >>>
>>>Is it possible that there's actually a bug in the compat code, and
>>>that table_base actually *was* set to (uint32_t)1?  If a reasonable
>>>number for table_base is "1", giving it 64 bits in the structure would
>>>seem a bit like overkill...
>>
>> "1" definitely is not a reasonable value here. And it's also not the
>> compat code I'm sure - it is the kernel using a bad structure definition.
>>
>> Jan
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xensource.com
>> http://lists.xensource.com/xen-devel
>>
>