From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH][XEN] p2m cleanup: remove unused function Date: Wed, 3 Mar 2010 11:25:10 +0000 Message-ID: References: <201003021820.52535.Christoph.Egger@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: Christoph Egger , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org I thought the whole point of gfn_to_mfn_current() was that it can walk the p2m table more efficiently if the domain in question is current. This isn't true with EPT-HAP, but I thought that it was true for both shadowed and NPT-HAP. Is this no longer the case? -George On Tue, Mar 2, 2010 at 6:03 PM, Keir Fraser wro= te: > On 02/03/2010 17:20, "Christoph Egger" wrote: > >> Attached patch removes gfn_to_mfn_current(). It is redundant and effecti= vely >> unused. > > Hm, well, it's unused after your patch, but used a fair bit right now. It= 'll > need an Ack from Tim Deegan, who's on holiday until middle of next week. > >> All remaining users now use proper replacement function. >> =3D> No functional change. >> >> While here, silence stdvga > > Is that a bug fix? Anyhow would belong in a separate properly explained > patch. > >> and use page_mode_hap() >> consequently. > > I see you change over to using page_mode_hap() in a few places. I wasn't > sure on the justification. If you could get rid of > arch.hvm_domain.hap_enabled entirely that might make it seem more > worthwhile. Again, it would need Ack from Tim. > > =A0-- Keir > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel >