xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Gianni Tedesco <gianni.tedesco@citrix.com>
To: xen-devel@lists.xensource.com
Cc: Ian Campbell <Ian.Campbell@eu.citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: [PATCH 2 of 3] xl: Remove libxl_need_xenpv_qemu()
Date: Tue, 4 Jan 2011 16:51:31 +0000	[thread overview]
Message-ID: <deb521c7f86fe761a9ee.1294159891@localhost6.localdomain6> (raw)
In-Reply-To: <patchbomb.1294159889@localhost6.localdomain6>

 tools/libxl/libxl.c |  33 ---------------------------------
 tools/libxl/libxl.h |   4 ----
 2 files changed, 0 insertions(+), 37 deletions(-)


# HG changeset patch
# User Gianni Tedesco <gianni.tedesco@citrix.com>
# Date 1294158577 0
# Node ID deb521c7f86fe761a9eed8e3ef55942087eb90fa
# Parent  01a1ce470640c67cf507e1f64a32561443b43061
xl: Remove libxl_need_xenpv_qemu()

It appears to have been made redundant with no users in-tree.

Signed-off-by: Gianni Tedesco <gianni.tedesco@citrix.com>

diff -r 01a1ce470640 -r deb521c7f86f tools/libxl/libxl.c
--- a/tools/libxl/libxl.c	Tue Jan 04 16:01:58 2011 +0000
+++ b/tools/libxl/libxl.c	Tue Jan 04 16:29:37 2011 +0000
@@ -2654,39 +2654,6 @@ static int libxl_build_xenpv_qemu_args(l
     return 0;
 }
 
-int libxl_need_xenpv_qemu(libxl_ctx *ctx,
-        int nr_consoles, libxl_device_console *consoles,
-        int nr_vfbs, libxl_device_vfb *vfbs,
-        int nr_disks, libxl_device_disk *disks)
-{
-    int i, ret = 0;
-    libxl__gc gc = LIBXL_INIT_GC(ctx);
-
-    if (nr_consoles > 1) {
-        ret = 1;
-        goto out;
-    }
-
-    for (i = 0; i < nr_consoles; i++) {
-        if (consoles[i].consback == LIBXL_CONSBACK_IOEMU) {
-            ret = 1;
-            goto out;
-        }
-    }
-
-    if (nr_vfbs > 0) {
-        ret = 1;
-        goto out;
-    }
-
-    if (nr_disks > 0 && !libxl__blktap_enabled(&gc))
-        ret = 1;
-
-out:
-    libxl__free_all(&gc);
-    return ret;
-}
-
 int libxl_create_xenpv_qemu(libxl_ctx *ctx, uint32_t domid, libxl_device_vfb *vfb,
                             libxl_device_model_starting **starting_r)
 {
diff -r 01a1ce470640 -r deb521c7f86f tools/libxl/libxl.h
--- a/tools/libxl/libxl.h	Tue Jan 04 16:01:58 2011 +0000
+++ b/tools/libxl/libxl.h	Tue Jan 04 16:29:37 2011 +0000
@@ -383,10 +383,6 @@ int libxl_create_device_model(libxl_ctx 
                               libxl_device_model_starting **starting_r);
 int libxl_create_xenpv_qemu(libxl_ctx *ctx, uint32_t domid, libxl_device_vfb *vfb,
                             libxl_device_model_starting **starting_r);
-int libxl_need_xenpv_qemu(libxl_ctx *ctx,
-        int nr_consoles, libxl_device_console *consoles,
-        int nr_vfbs, libxl_device_vfb *vfbs,
-        int nr_disks, libxl_device_disk *disks);
   /* Caller must either: pass starting_r==0, or on successful
    * return pass *starting_r (which will be non-0) to
    * libxl_confirm_device_model or libxl_detach_device_model. */

  parent reply	other threads:[~2011-01-04 16:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-04 16:51 [PATCH 0 of 3] Refactor libxl domain creation Gianni Tedesco
2011-01-04 16:51 ` [PATCH 1 of 3] xl: idl: Abolish keyed union types Gianni Tedesco
2011-01-04 16:51 ` Gianni Tedesco [this message]
2011-01-04 16:51 ` [PATCH 3 of 3] xl: Introduce libxl_domain_create_new() and libxl_domain_create_restore() Gianni Tedesco
2011-01-04 17:51 ` [PATCH 0 of 3] Refactor libxl domain creation Gianni Tedesco
2011-01-05 11:15 ` Gianni Tedesco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=deb521c7f86fe761a9ee.1294159891@localhost6.localdomain6 \
    --to=gianni.tedesco@citrix.com \
    --cc=Ian.Campbell@eu.citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=Stefano.Stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).