From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: tim@xen.org, sstabellini@kernel.org, George.Dunlap@eu.citrix.com,
andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com,
xen-devel@lists.xen.org, jbeulich@suse.com
Subject: Re: [PATCH v1 1/9] mm: Separate free page chunk merging into its own routine
Date: Tue, 28 Mar 2017 15:41:10 -0400 [thread overview]
Message-ID: <dfd5eb2b-04e4-d755-f820-17e7a0151eb3@oracle.com> (raw)
In-Reply-To: <20170328192027.yewggjjhxwrmn3dk@citrix.com>
On 03/28/2017 03:20 PM, Wei Liu wrote:
> On Fri, Mar 24, 2017 at 01:04:56PM -0400, Boris Ostrovsky wrote:
>> This is needed for subsequent changes to memory scrubbing. No
>> logic change, only code re-factoring.
> Actually there is a slight change in logic: pg and order could be
> updated in the original merge code. With this patch you still pass the
> original pg to reserve_offlined_page if tainted is true. I don't think
> this matters in terms of correctness, but it is worth pointing out.
Actually, for pg it does matter since reserve_offlined_page() is passed
buddy head. So I should make merge_chunks() return new head.
('order' is not used after merge_chunks(), so that's OK).
-boris
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-03-28 19:41 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 17:04 [PATCH v1 0/9] Memory scrubbing from idle loop Boris Ostrovsky
2017-03-24 17:04 ` [PATCH v1 1/9] mm: Separate free page chunk merging into its own routine Boris Ostrovsky
2017-03-27 15:16 ` Wei Liu
2017-03-27 16:03 ` Jan Beulich
2017-03-27 16:28 ` Boris Ostrovsky
2017-03-28 7:27 ` Jan Beulich
2017-03-28 19:20 ` Wei Liu
2017-03-28 19:41 ` Boris Ostrovsky [this message]
2017-03-28 19:44 ` Wei Liu
2017-03-28 19:57 ` Boris Ostrovsky
2017-03-24 17:04 ` [PATCH v1 2/9] mm: Place unscrubbed pages at the end of pagelist Boris Ostrovsky
2017-03-28 19:27 ` Wei Liu
2017-03-28 19:46 ` Boris Ostrovsky
2017-03-24 17:04 ` [PATCH v1 3/9] mm: Scrub pages in alloc_heap_pages() if needed Boris Ostrovsky
2017-03-28 19:43 ` Wei Liu
2017-03-24 17:04 ` [PATCH v1 4/9] mm: Scrub memory from idle loop Boris Ostrovsky
2017-03-28 20:01 ` Wei Liu
2017-03-28 20:14 ` Boris Ostrovsky
2017-03-24 17:05 ` [PATCH v1 5/9] mm: Do not discard already-scrubbed pages if softirqs are pending Boris Ostrovsky
2017-03-29 10:22 ` Wei Liu
2017-03-24 17:05 ` [PATCH v1 6/9] spinlock: Introduce spin_lock_cb() Boris Ostrovsky
2017-03-29 10:28 ` Wei Liu
2017-03-29 13:47 ` Boris Ostrovsky
2017-03-29 14:07 ` Boris Ostrovsky
2017-03-24 17:05 ` [PATCH v1 7/9] mm: Keep pages available for allocation while scrubbing Boris Ostrovsky
2017-03-24 17:05 ` [PATCH v1 8/9] mm: Print number of unscrubbed pages in 'H' debug handler Boris Ostrovsky
2017-03-28 20:11 ` Wei Liu
2017-03-24 17:05 ` [PATCH v1 9/9] mm: Make sure pages are scrubbed Boris Ostrovsky
2017-03-29 10:39 ` Wei Liu
2017-03-29 16:25 ` Wei Liu
2017-03-29 16:35 ` Boris Ostrovsky
2017-03-29 16:45 ` Wei Liu
2017-03-29 17:12 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfd5eb2b-04e4-d755-f820-17e7a0151eb3@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).