Install of Xen 4.8 on Fedora 25 makes the box unbootable.. which is due to /var/run/xen being created, instead of /run/xen

Install of Xen 4.8 on Fedora 25 makes the box unbootable.. which is due to /var/run/xen being created, instead of /run/xen

[Konrad Rzeszutek Wilk]

Hey,

Credit goes to Boris (CC-ed) for figuring out how to fix this.

I was doing:

./configure --prefix=/usr --enable-systemd
make -j8
cd dist;./install.sh;)
reboot

and to my surprise it would hang on 
Starting Terminate Plymouth Boot Screen"...                                                                
                                                                                                                                
with a bunch of 'FAILED'.                                                                                                  


What I hadn't realized is that Fedora has removed the
/var/run and is now using /run. But the dist/install
has the /var/run directory (dist/install/var/run/) in it -
and that seems to make everything blow up as it erase
the original symlink:

[konrad@x230 /]$ ls -al /var/run
lrwxrwxrwx. 1 root root 6 Oct  5 02:08 /var/run -> ../run

with its own directory which has nothing to do with /run - and
which only has 'xen' and 'xenstored' in it (albeit at bootup things
do seem to be created there - but they are not in sync with things in 
/run).


The "Fix" is to boot with 'init=/bin/bash' on Linux command line and do:

mount / -o remount,rw
rm -rf /var/run
mkdir /run/xen
mkdir /run/xenstored
ln -sf /run /var/run

And then everything works again.

A bit of light builds shows that RELEASE-4.7.0
does not have an dist/install/var/run but
RELEASE-4.8.0 and higher does.

And I am not exactly sure which commit does this and
how to go around to auto-detect this? 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: Install of Xen 4.8 on Fedora 25 makes the box unbootable.. which is due to /var/run/xen being created, instead of /run/xen

[Boris Ostrovsky]

On 02/15/2017 03:51 PM, Konrad Rzeszutek Wilk wrote:
> Hey,
>
> Credit goes to Boris (CC-ed) for figuring out how to fix this.
>
> I was doing:
>
> ./configure --prefix=/usr --enable-systemd
> make -j8
> cd dist;./install.sh;)
> reboot
>
> and to my surprise it would hang on 
> Starting Terminate Plymouth Boot Screen"...                                                                
>                                                                                                                                 
> with a bunch of 'FAILED'.                                                                                                  
>
>
> What I hadn't realized is that Fedora has removed the
> /var/run and is now using /run. But the dist/install
> has the /var/run directory (dist/install/var/run/) in it -
> and that seems to make everything blow up as it erase
> the original symlink:
>
> [konrad@x230 /]$ ls -al /var/run
> lrwxrwxrwx. 1 root root 6 Oct  5 02:08 /var/run -> ../run
>
> with its own directory which has nothing to do with /run - and
> which only has 'xen' and 'xenstored' in it (albeit at bootup things
> do seem to be created there - but they are not in sync with things in 
> /run).
>
>
> The "Fix" is to boot with 'init=/bin/bash' on Linux command line and do:
>
> mount / -o remount,rw
> rm -rf /var/run
> mkdir /run/xen
> mkdir /run/xenstored
> ln -sf /run /var/run
>
> And then everything works again.
>
> A bit of light builds shows that RELEASE-4.7.0
> does not have an dist/install/var/run but
> RELEASE-4.8.0 and higher does.
>
> And I am not exactly sure which commit does this and
> how to go around to auto-detect this? 

I *think* this started happening after
  https://lists.xenproject.org/archives/html/xen-devel/2016-08/msg00372.html

-boris


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: Install of Xen 4.8 on Fedora 25 makes the box unbootable.. which is due to /var/run/xen being created, instead of /run/xen

[Juergen Gross]

On 15/02/17 22:10, Boris Ostrovsky wrote:
> On 02/15/2017 03:51 PM, Konrad Rzeszutek Wilk wrote:
>> Hey,
>>
>> Credit goes to Boris (CC-ed) for figuring out how to fix this.
>>
>> I was doing:
>>
>> ./configure --prefix=/usr --enable-systemd
>> make -j8
>> cd dist;./install.sh;)
>> reboot
>>
>> and to my surprise it would hang on 
>> Starting Terminate Plymouth Boot Screen"...                                                                
>>                                                                                                                                 
>> with a bunch of 'FAILED'.                                                                                                  
>>
>>
>> What I hadn't realized is that Fedora has removed the
>> /var/run and is now using /run. But the dist/install
>> has the /var/run directory (dist/install/var/run/) in it -
>> and that seems to make everything blow up as it erase
>> the original symlink:
>>
>> [konrad@x230 /]$ ls -al /var/run
>> lrwxrwxrwx. 1 root root 6 Oct  5 02:08 /var/run -> ../run
>>
>> with its own directory which has nothing to do with /run - and
>> which only has 'xen' and 'xenstored' in it (albeit at bootup things
>> do seem to be created there - but they are not in sync with things in 
>> /run).
>>
>>
>> The "Fix" is to boot with 'init=/bin/bash' on Linux command line and do:
>>
>> mount / -o remount,rw
>> rm -rf /var/run
>> mkdir /run/xen
>> mkdir /run/xenstored
>> ln -sf /run /var/run
>>
>> And then everything works again.
>>
>> A bit of light builds shows that RELEASE-4.7.0
>> does not have an dist/install/var/run but
>> RELEASE-4.8.0 and higher does.
>>
>> And I am not exactly sure which commit does this and
>> how to go around to auto-detect this? 
> 
> I *think* this started happening after
>   https://lists.xenproject.org/archives/html/xen-devel/2016-08/msg00372.html

I thought using:

./configure --prefix=/usr --enable-systemd XEN_RUN_DIR=/run/xen
XEN_RUN_STORED=/run/xenstored

would solve this issue, but obviously those settings don't make it into
config/Paths.mk

I suggest adding something like "--rundir=..." to the possible configure
parameters defaulting to /var/run and set XEN_RUN_DIR to $(rundir)/xen
and XEN_RUN_STORED to $(rundir)/xenstored.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: Install of Xen 4.8 on Fedora 25 makes the box unbootable.. which is due to /var/run/xen being created, instead of /run/xen

[Olaf Hering]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Wed, 15 Feb 2017 15:51:12 -0500
schrieb Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>:
> mkdir /run/xen
> mkdir /run/xenstored

This must be done by the startup scripts because the "run" directories,
where ever they are, are volatile.

I think confiugre should check if "/run" exists and assume this is a
systemd based system and adjust the Makefile variables to be
either /var/run or /run.

Of course keeping a symlink /var/run is too much of a burden...

Olaf
-----BEGIN PGP SIGNATURE-----

iF0EARECAB0WIQSkRyP6Rn//f03pRUBdQqD6ppg2fgUCWKVaLwAKCRBdQqD6ppg2
fsWaAKCj7uB6BBXevzJZJl3/6GXDi8muCQCfbB81TtS/jn13igbjl8ojNWcbjV4=
=SevM
-----END PGP SIGNATURE-----
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: Install of Xen 4.8 on Fedora 25 makes the box unbootable.. which is due to /var/run/xen being created, instead of /run/xen

[Juergen Gross]

On 16/02/17 08:52, Olaf Hering wrote:
> Am Wed, 15 Feb 2017 15:51:12 -0500
> schrieb Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>:
>> mkdir /run/xen
>> mkdir /run/xenstored
> 
> This must be done by the startup scripts because the "run" directories,
> where ever they are, are volatile.
> 
> I think confiugre should check if "/run" exists and assume this is a
> systemd based system and adjust the Makefile variables to be
> either /var/run or /run.

You can't assume ./configure is running on the same system as Xen is
being built for.

Just sent a patch adding "--with-rundir" parameter to configure.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: Install of Xen 4.8 on Fedora 25 makes the box unbootable.. which is due to /var/run/xen being created, instead of /run/xen

[Olaf Hering]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Thu, 16 Feb 2017 08:58:01 +0100
schrieb Juergen Gross <jgross@suse.com>:
> You can't assume ./configure is running on the same system as Xen is
> being built for.

I think its easy to decide at build time if the target has and/or uses
"/run". And this will not change suddenly later at runtime.

Olaf
-----BEGIN PGP SIGNATURE-----

iF0EARECAB0WIQSkRyP6Rn//f03pRUBdQqD6ppg2fgUCWKVc2AAKCRBdQqD6ppg2
fmDLAJoCBNtcIxqEigAuoaGyx6Ngg7WxBgCfUK3MiGAQ2H/s7drKLVyJL42H6eg=
=reRA
-----END PGP SIGNATURE-----
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: Install of Xen 4.8 on Fedora 25 makes the box unbootable.. which is due to /var/run/xen being created, instead of /run/xen

[Olaf Hering]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Thu, 16 Feb 2017 08:58:01 +0100
schrieb Juergen Gross <jgross@suse.com>:
> You can't assume ./configure is running on the same system as Xen is
> being built for.

I think its easy to decide at build time if the target has and/or uses
"/run". And this will not change suddenly later at runtime.

Olaf
-----BEGIN PGP SIGNATURE-----

iF0EARECAB0WIQSkRyP6Rn//f03pRUBdQqD6ppg2fgUCWKVdPgAKCRBdQqD6ppg2
fmezAJ4k7QbZhloBUVy6h+JUna2nlfcXzwCfZEdNpin6GxAKDxokfQBSkpeKI1c=
=K0t9
-----END PGP SIGNATURE-----
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: Install of Xen 4.8 on Fedora 25 makes the box unbootable.. which is due to /var/run/xen being created, instead of /run/xen

[M A Young]

On Thu, 16 Feb 2017, Juergen Gross wrote:

> On 16/02/17 08:52, Olaf Hering wrote:
> > Am Wed, 15 Feb 2017 15:51:12 -0500
> > schrieb Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>:
> >> mkdir /run/xen
> >> mkdir /run/xenstored
> > 
> > This must be done by the startup scripts because the "run" directories,
> > where ever they are, are volatile.
> > 
> > I think confiugre should check if "/run" exists and assume this is a
> > systemd based system and adjust the Makefile variables to be
> > either /var/run or /run.
> 
> You can't assume ./configure is running on the same system as Xen is
> being built for.
> 
> Just sent a patch adding "--with-rundir" parameter to configure.

Build time detection makes sense to determine the default setting, but 
there should probably be an option to override it for when you are 
building in one environment for use in a different one.

	Michael Young

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel