From: Julien Grall <julien.grall@arm.com>
To: Peng Fan <van.freenix@gmail.com>, sstabellini@kernel.org
Cc: xen-devel@lists.xen.org
Subject: Re: [PATCH] arm64: head: Fill image size
Date: Thu, 18 Aug 2016 17:02:01 +0100 [thread overview]
Message-ID: <e2e01bb4-b047-4f18-e43b-85f68a2dca01@arm.com> (raw)
In-Reply-To: <1471316303-29751-1-git-send-email-van.freenix@gmail.com>
Hello Peng,
On 16/08/16 03:58, Peng Fan wrote:
> When booting xen from U-Boot, U-Boot will use the image size
> info. Because this information is lacked in XEN image,U-Boot
> assume the image size is 16MB to memmove, which will cost lots
> time on simulation platform.
The patch looks good to me, however I would prefer if you update all the
header rather than updating only the field you care.
You can give a look to commit a2c1d73b94ed49f5fac12e95052d7b140783f800
"arm64: Update the Image header" in Linux for more details.
Regards,
>
> Signed-off-by: Peng Fan <van.freenix@gmail.com>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Julien Grall <julien.grall@arm.com>
> ---
> xen/arch/arm/arm64/head.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
> index 91e2817..9fade07 100644
> --- a/xen/arch/arm/arm64/head.S
> +++ b/xen/arch/arm/arm64/head.S
> @@ -115,7 +115,7 @@ efi_head:
> add x13, x18, #0x16
> b real_start /* branch to kernel start */
> .quad 0 /* Image load offset from start of RAM */
> - .quad 0 /* reserved */
> + .quad _end - start /* Effective size of Image, little-endian */
> .quad 0 /* reserved */
> .quad 0 /* reserved */
> .quad 0 /* reserved */
>
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-08-18 16:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 2:58 [PATCH] arm64: head: Fill image size Peng Fan
2016-08-18 16:02 ` Julien Grall [this message]
2016-08-19 12:13 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2e01bb4-b047-4f18-e43b-85f68a2dca01@arm.com \
--to=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=van.freenix@gmail.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).