From: Paolo Bonzini <pbonzini@redhat.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>, qemu-devel@nongnu.org
Cc: Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
"Daniel P. Berrange" <berrange@redhat.com>,
Ross Lagerwall <ross.lagerwall@citrix.com>,
Anthony PERARD <anthony.perard@citrix.com>,
xen-devel@lists.xenproject.org, Eric Blake <eblake@redhat.com>
Subject: Re: [PATCH 01/12] checkpatch: Add xendevicemodel_handle to the list of types
Date: Tue, 13 Mar 2018 16:11:00 +0100 [thread overview]
Message-ID: <e2f1cee4-8dad-d901-ae2f-51495a855b4e@redhat.com> (raw)
In-Reply-To: <1520535787-6223-2-git-send-email-ian.jackson@eu.citrix.com>
On 08/03/2018 20:02, Ian Jackson wrote:
> This avoids checkpatch misparsing (as statements) long function
> definitions or declarations, which sometimes start with constructs
> like this:
>
> static inline int xendevicemodel_relocate_memory(
> xendevicemodel_handle *dmod, domid_t domid, ...
>
> CC: Eric Blake <eblake@redhat.com>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: Daniel P. Berrange <berrange@redhat.com>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> ---
> v6.1: New patch
> ---
> scripts/checkpatch.pl | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index d1fe79b..3e488f7 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -266,6 +266,7 @@ our @typeList = (
> qr{target_(?:u)?long},
> qr{hwaddr},
> qr{xml${Ident}},
> + qr{xendevicemodel_handle},
> );
>
> # This can be modified by sub possible. Since it can be empty, be careful
> --
Or just rename it so that it is CamelCase. Then checkpatch will be happy.
Paolo
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-03-13 15:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 19:02 [PATCH v6.1 00/11] xen: xen-domid-restrict improvements Ian Jackson
2018-03-08 19:02 ` [PATCH 01/12] checkpatch: Add xendevicemodel_handle to the list of types Ian Jackson
2018-03-13 15:11 ` Paolo Bonzini [this message]
2018-03-26 13:58 ` Ian Jackson
2018-04-19 16:32 ` Ian Jackson
2018-03-08 19:02 ` [PATCH 02/12] xen: link against xentoolcore Ian Jackson
2018-03-08 19:02 ` [PATCH 03/12] xen: restrict: use xentoolcore_restrict_all Ian Jackson
2018-03-08 19:02 ` [PATCH 04/12] xen: defer call to xen_restrict until just before os_setup_post Ian Jackson
2018-03-08 19:03 ` [PATCH 05/12] xen: destroy_hvm_domain: Move reason into a variable Ian Jackson
2018-03-08 19:03 ` [PATCH 06/12] xen: move xc_interface compatibility fallback further up the file Ian Jackson
2018-03-08 19:03 ` [PATCH 07/12] xen: destroy_hvm_domain: Try xendevicemodel_shutdown Ian Jackson
2018-03-08 19:03 ` [PATCH 08/12] os-posix: Provide new -runas <uid>:<gid> facility Ian Jackson
2018-04-13 15:51 ` [Qemu-devel] " Markus Armbruster
2018-04-16 14:06 ` Ian Jackson
2018-04-16 16:17 ` Markus Armbruster
2018-04-16 17:00 ` Ian Jackson
2018-04-16 18:06 ` Markus Armbruster
2018-03-08 19:03 ` [PATCH 09/12] configure: do_compiler: Dump some extra info under bash Ian Jackson
2018-03-08 19:03 ` [PATCH 10/12] xen: Use newly added dmops for mapping VGA memory Ian Jackson
2018-03-09 15:44 ` Anthony PERARD
2018-03-09 16:12 ` Ian Jackson
2018-03-09 16:13 ` Ian Jackson
2018-03-08 19:03 ` [PATCH 11/12] xen: Expect xenstore write to fail when restricted Ian Jackson
2018-03-09 15:46 ` Anthony PERARD
2018-03-08 19:03 ` [PATCH 12/12] scripts/get_maintainer.pl: Print proper error message for missing $file Ian Jackson
2018-03-13 15:11 ` Paolo Bonzini
2018-03-09 16:20 ` [PATCH v6.1 00/11] xen: xen-domid-restrict improvements Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2f1cee4-8dad-d901-ae2f-51495a855b4e@redhat.com \
--to=pbonzini@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=qemu-devel@nongnu.org \
--cc=ross.lagerwall@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).