From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: Re: [PATCH v2] public/io/netif.h: make control ring hash protocol more general Date: Tue, 16 Feb 2016 11:14:09 +0000 Message-ID: References: <1455534896-9598-1-git-send-email-paul.durrant@citrix.com> <1455618175.15441.54.camel@citrix.com> <8e7984055a044cf1b4a834c38d85f35f@AMSPEX02CL03.citrite.net> <56C311B902000078000D2938@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aVda7-0001wi-Ug for xen-devel@lists.xenproject.org; Tue, 16 Feb 2016 11:14:12 +0000 In-Reply-To: <56C311B902000078000D2938@prv-mh.provo.novell.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Ian Jackson , "Tim (Xen.org)" , "Keir (Xen.org)" , Ian Campbell , "xen-devel@lists.xenproject.org" List-Id: xen-devel@lists.xenproject.org > -----Original Message----- > From: Jan Beulich [mailto:JBeulich@suse.com] > Sent: 16 February 2016 11:11 > To: Paul Durrant > Cc: Ian Campbell; Ian Jackson; xen-devel@lists.xenproject.org; Keir > (Xen.org); Tim (Xen.org) > Subject: RE: [PATCH v2] public/io/netif.h: make control ring hash protocol > more general > > >>> On 16.02.16 at 12:02, wrote: > >> From: Ian Campbell [mailto:ian.campbell@citrix.com] > >> Sent: 16 February 2016 10:23 > >> On Mon, 2016-02-15 at 11:14 +0000, Paul Durrant wrote: > >> > + */ > >> > +#ifdef NETIF_DEFINE_TOEPLITZ > >> > >> If we go with this then this should have an addtional XEN_ on the > >> front. > > > > The header is inconsistent at the moment. Some things are prefixed with > XEN_ > > some are not so if you want this prefixed then I think it's best I add > > another patch before this to change all unqualified netif/NETIF occurrences > > to xen_netif/XEN_NETIF... it will also mean less post-processing when I > > re-import the header into Linux. > > You'd need to be rather careful here: Any such identifiers which > were there already in 4.6 (or any other release) would have to > remain unchanged. Is that true? The Linux header is quite different (in that everything is already prefixed) and I was assuming any user of the header file would have to have an explicit 'import into frontend/backend repo' step where compatibility could be fixed up. Paul > For any new ones adding prefixes would > indeed seem very desirable. > > Jan