xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel@lists.xenproject.org,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH 3/3] xen/displif: Add unique display connector identifier
Date: Thu, 7 Jun 2018 16:41:48 +0300	[thread overview]
Message-ID: <e439eefd-f2ff-1874-8c69-aa7532e124fd@gmail.com> (raw)
In-Reply-To: <20180607132903.GB24186@char.us.oracle.com>

On 06/07/2018 04:29 PM, Konrad Rzeszutek Wilk wrote:
> On Wed, May 23, 2018 at 09:19:23AM +0300, Oleksandr Andrushchenko wrote:
>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>
>> If frontend is configured to expose multiple connectors then backend may
>> require a way to uniquely identify concrete virtual connector within the
>> frontend. This is useful for use-cases where connector needs to be
>> matched to physical display connector.
>> Add XenBus "unique-id" node parameter, so this sort of use-cases can
>> be implemented.
>>
>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>> ---
>>   xen/include/public/io/displif.h | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/xen/include/public/io/displif.h b/xen/include/public/io/displif.h
>> index 8a94f1f9b9d0..78158f739cf5 100644
>> --- a/xen/include/public/io/displif.h
>> +++ b/xen/include/public/io/displif.h
>> @@ -189,6 +189,13 @@
>>    *
>>    *----------------------------- Connector settings ----------------------------
>>    *
>> + * unique-id
>> + *      Values:         <uint32_t>
> Ditto, perhaps an string instead?
Ditto ;)
String is way better, but we have to decide if we want to be consistent 
with sndif
>> + *
>> + *      After device instance initialization each connector is assigned a
>> + *      unique ID (within the front driver), so it can be identified by the
>> + *      backend by this ID.
>> + *
>>    * resolution
>>    *      Values:         <width, uint32_t>x<height, uint32_t>
>>    *
>> @@ -368,6 +375,7 @@
>>   #define XENDISPL_FIELD_EVT_CHANNEL    "evt-event-channel"
>>   #define XENDISPL_FIELD_RESOLUTION     "resolution"
>>   #define XENDISPL_FIELD_BE_ALLOC       "be-alloc"
>> +#define XENDISPL_FIELD_UNIQUE_ID      "unique-id"
>>   
>>   /*
>>    ******************************************************************************
>> -- 
>> 2.17.0
>>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xenproject.org
> https://lists.xenproject.org/mailman/listinfo/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-06-07 13:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-23  6:19 [PATCH 1/3] xen/kbdif: Move multi-touch device parameters to backend nodes Oleksandr Andrushchenko
2018-05-23  6:19 ` [PATCH 2/3] xen/kbdif: Add unique input device identifier Oleksandr Andrushchenko
2018-06-07 13:28   ` Konrad Rzeszutek Wilk
2018-06-07 13:40     ` Oleksandr Andrushchenko
2018-06-07 15:47       ` Konrad Rzeszutek Wilk
2018-06-08  5:26         ` Oleksandr Andrushchenko
2018-05-23  6:19 ` [PATCH 3/3] xen/displif: Add unique display connector identifier Oleksandr Andrushchenko
2018-06-07 13:29   ` Konrad Rzeszutek Wilk
2018-06-07 13:41     ` Oleksandr Andrushchenko [this message]
2018-06-07 13:29 ` [PATCH 1/3] xen/kbdif: Move multi-touch device parameters to backend nodes Konrad Rzeszutek Wilk
2018-06-07 14:00   ` Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e439eefd-f2ff-1874-8c69-aa7532e124fd@gmail.com \
    --to=andr2000@gmail.com \
    --cc=konrad.wilk@oracle.com \
    --cc=oleksandr_andrushchenko@epam.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).