From: Julien Grall <julien.grall@arm.com>
To: Volodymyr Babchuk <volodymyr_babchuk@epam.com>, xen-devel@lists.xen.org
Cc: "Edgar E . Iglesias" <edgar.iglesias@xilinx.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Jan Beulich <jbeulich@suse.com>,
nd@arm.com
Subject: Re: [PATCH v5 06/10] arm: smccc: handle SMCs according to SMCCC
Date: Thu, 21 Sep 2017 15:48:03 +0100 [thread overview]
Message-ID: <e44231a5-2e32-57c3-900b-76d0b7174da5@arm.com> (raw)
In-Reply-To: <ee507385-707d-0438-6e79-1759d08964ef@epam.com>
On 20/09/17 21:26, Volodymyr Babchuk wrote:
>
>
> On 20.09.17 23:02, Julien Grall wrote:
>>
>>
>> On 20/09/2017 19:11, Volodymyr Babchuk wrote:
>>> On 20.09.17 20:21, Julien Grall wrote:
>>>>
>>>>
>>>> On 19/09/17 22:44, Volodymyr Babchuk wrote:
>>>>> Hi Julien,
>>>>
>>>> Hi Volodymyr,
>>>>
>>>>>
>>>>> On 13.09.17 14:11, Julien Grall wrote:
>>>>>> Hi,
>>>>>>
>>>>>> On 08/31/2017 09:09 PM, Volodymyr Babchuk wrote:
>>>>>
>>>>>>> +static void fill_uuid(struct cpu_user_regs *regs, const xen_uuid_t
>>> *u)
>>>>>>
>>>>>> Actually why do you pass a pointer for u? This requires every caller
>>>>>> to introduce temporary variable because the UUID is usually a define.
>>>>> Hmm, another way probably is to pass a whole structure as a parameter.
>>>>> Are you suggesting this approach? Something like
>>>>> fill_uuid(regs, (xen_uuid_t)MY_UUID)?
>>>>
>>>> Something list that. But why do you need the cast? MY_UUID is supposed
>>>> to be a xen_uuid_t. No?
>>> It have no type. It is just an initializer list like {1,2,3,4,5,6}. If
>>> you remember that thread, there is a requirement to make public headers
>>> compatible with c89. So I can't define MY_UUID as (xen_uuid_t){1,2,3}.
>>> Instead it is defined as a plain initializer list.
>>
>> In that case why don't introduce a version for non-strict ansi? This
>> would introduce a bit of safety and avoid cast a bit unexplained. (see
>> how __DECL_REG(...,...) is done in include/public/asm-arm.h?
> I believe you meant arch-arm.h.
>
> Just to be clear, you are proposing to introduce one
> #define XEN_DEFINE_UUID in a public header, and another one in a private
> header?
No the two in the public header. One version for strict-ansi compiler,
the other for gcc-compatible one.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-09-21 14:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 20:09 [PATCH v5 00/10] Handle SMCs and HVCs in conformance with SMCCC Volodymyr Babchuk
2017-08-31 20:09 ` [PATCH v5 01/10] arm: traps: use generic register accessors in the PSCI code Volodymyr Babchuk
2017-09-13 9:59 ` Julien Grall
2017-08-31 20:09 ` [PATCH v5 02/10] arm: traps: check if SMC was conditional before handling it Volodymyr Babchuk
2017-08-31 20:09 ` [PATCH v5 03/10] public: xen.h: add definitions for UUID handling Volodymyr Babchuk
2017-09-01 9:42 ` Ian Jackson
2017-08-31 20:09 ` [PATCH v5 04/10] arm: processor.h: add definition for immediate value mask Volodymyr Babchuk
2017-09-13 10:02 ` Julien Grall
2017-08-31 20:09 ` [PATCH v5 05/10] arm: add SMCCC protocol definitions Volodymyr Babchuk
2017-09-13 10:07 ` Julien Grall
2017-08-31 20:09 ` [PATCH v5 06/10] arm: smccc: handle SMCs according to SMCCC Volodymyr Babchuk
2017-09-13 10:17 ` Julien Grall
2017-09-13 11:11 ` Julien Grall
2017-09-19 21:44 ` Volodymyr Babchuk
2017-09-20 17:21 ` Julien Grall
2017-09-20 18:11 ` Volodymyr Babchuk
2017-09-20 20:02 ` Julien Grall
2017-09-20 20:26 ` Volodymyr Babchuk
2017-09-21 14:48 ` Julien Grall [this message]
2017-08-31 20:09 ` [PATCH v5 07/10] arm: traps: handle PSCI calls inside `vsmc.c` Volodymyr Babchuk
2017-09-13 11:53 ` Julien Grall
2017-08-31 20:09 ` [PATCH v5 08/10] arm: PSCI: use definitions provided by asm/smccc.h Volodymyr Babchuk
2017-09-13 11:58 ` Julien Grall
2017-09-21 18:28 ` Volodymyr Babchuk
2017-08-31 20:09 ` [PATCH v5 09/10] arm: vsmc: remove 64 bit mode check in PSCI handler Volodymyr Babchuk
2017-08-31 20:09 ` [PATCH v5 10/10] public: add and enable XENFEAT_ARM_SMCCC_supported feature Volodymyr Babchuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e44231a5-2e32-57c3-900b-76d0b7174da5@arm.com \
--to=julien.grall@arm.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=edgar.iglesias@xilinx.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=nd@arm.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=volodymyr_babchuk@epam.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).