From: George Dunlap <george.dunlap@eu.citrix.com>
To: xen-devel@lists.xensource.com
Cc: george.dunlap@eu.citrix.com
Subject: [PATCH] xen: Remove sched_credit_default_yield option
Date: Mon, 24 Sep 2012 16:20:02 +0100 [thread overview]
Message-ID: <e45a63da20e99291fa7e.1348500002@elijah> (raw)
# HG changeset patch
# User George Dunlap <george.dunlap@eu.citrix.com>
# Date 1348499942 -3600
# Node ID e45a63da20e99291fa7e98697a9713aa89b98316
# Parent 7e332fd064fac8d9d1cea904d5236c8d74389194
xen: Remove sched_credit_default_yield option
The sched_credit_default_yield option was added when the behavior of
"SCHEDOP_yield" was changed in 4.1, to allow any users who had
problems to revert to the old behavior. The new behavior has been in
Xen.org xen since 4.1, and in XenServer even longer, and there is no
evidence of anyone having trouble with it. Remove the option.
Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
diff --git a/docs/misc/xen-command-line.markdown b/docs/misc/xen-command-line.markdown
--- a/docs/misc/xen-command-line.markdown
+++ b/docs/misc/xen-command-line.markdown
@@ -726,9 +726,6 @@ Choose the default scheduler.
### sched\_credit2\_migrate\_resist
> `= <integer>`
-### sched\_credit\_default\_yield
-> `= <boolean>`
-
### sched\_credit\_tslice\_ms
> `= <integer>`
diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c
--- a/xen/common/sched_credit.c
+++ b/xen/common/sched_credit.c
@@ -103,8 +103,6 @@
/*
* Boot parameters
*/
-static bool_t __read_mostly sched_credit_default_yield;
-boolean_param("sched_credit_default_yield", sched_credit_default_yield);
static int __read_mostly sched_credit_tslice_ms = CSCHED_DEFAULT_TSLICE_MS;
integer_param("sched_credit_tslice_ms", sched_credit_tslice_ms);
@@ -783,11 +781,8 @@ csched_vcpu_yield(const struct scheduler
{
struct csched_vcpu * const sv = CSCHED_VCPU(vc);
- if ( !sched_credit_default_yield )
- {
- /* Let the scheduler know that this vcpu is trying to yield */
- sv->flags |= CSCHED_FLAG_VCPU_YIELD;
- }
+ /* Let the scheduler know that this vcpu is trying to yield */
+ sv->flags |= CSCHED_FLAG_VCPU_YIELD;
}
static int
next reply other threads:[~2012-09-24 15:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 15:20 George Dunlap [this message]
2012-10-01 16:51 ` [PATCH] xen: Remove sched_credit_default_yield option Ian Jackson
2012-10-01 16:54 ` George Dunlap
2012-10-01 17:01 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e45a63da20e99291fa7e.1348500002@elijah \
--to=george.dunlap@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).