Re: [PATCH v4] tools/firmware: add ACPI device for Windows laptop/slate mode switch

[Paul Durrant <Paul.Durrant@citrix.com>]

> -----Original Message-----
> From: Wei Liu [mailto:wei.liu2@citrix.com]
> Sent: 27 March 2017 16:12
> To: Paul Durrant <Paul.Durrant@citrix.com>
> Cc: xen-devel@lists.xenproject.org; Owen Smith <owen.smith@citrix.com>;
> Ian Jackson <Ian.Jackson@citrix.com>; Wei Liu <wei.liu2@citrix.com>; Jan
> Beulich <jbeulich@suse.com>; Andrew Cooper
> <Andrew.Cooper3@citrix.com>
> Subject: Re: [PATCH v4] tools/firmware: add ACPI device for Windows
> laptop/slate mode switch
> 
> On Fri, Mar 24, 2017 at 01:31:39PM +0000, Paul Durrant wrote:
> > Microsoft have defined an ACPI device to support switching Windows 10
> > between laptop/desktop mode and slate/tablet mode [1].
> >
> > This patch adds an SSDT containing such a device. The presence of the
> > device is controlled by a new 'acpi_laptop_slate' boolean in xl.cfg.
> > The new device will not be present by default.
> >
> > [1] https://msdn.microsoft.com/en-
> us/windows/hardware/commercialize/design/device-
> experiences/continuum
> >
> > Signed-off-by: Owen Smith <owen.smith@citrix.com>
> > Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> > ---
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > Cc: Wei Liu <wei.liu2@citrix.com>
> > Cc: Jan Beulich <jbeulich@suse.com>
> > Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> >
> > NOTE: Odd looking braces style in tools/libacpi/build.c is for
> >       consistency with existing code.
> >
> > v4:
> >  - Fix commit comment with new paramater name
> >
> > v3:
> >  - s/acpi_conv/acpi_laptop_slate/g
> >
> > v2:
> >  - Fix default if xenstore key is missing
> > ---
> >  docs/man/xl.cfg.pod.5.in            |  5 +++++
> >  tools/firmware/hvmloader/util.c     |  2 ++
> >  tools/libacpi/Makefile              |  4 ++--
> >  tools/libacpi/build.c               | 11 +++++++++++
> >  tools/libacpi/libacpi.h             | 31 +++++++++++++++---------------
> >  tools/libacpi/ssdt_laptop_slate.asl | 38
> +++++++++++++++++++++++++++++++++++++
> >  tools/libxl/libxl_create.c          |  3 +++
> >  tools/libxl/libxl_types.idl         |  1 +
> >  tools/xl/xl_parse.c                 |  1 +
> 
> Missing a LIBXL_HAVE macro.

Gah. I always forget those. I'll send v5 shortly.

  Paul

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel