From: Julien Grall <julien.grall@arm.com>
To: Shanker Donthineni <shankerd@codeaurora.org>,
xen-devel <xen-devel@lists.xensource.com>,
Stefano Stabellini <sstabellini@kernel.org>
Cc: Vikram Sethi <vikrams@codeaurora.org>,
Campbell Sean <scampbel@codeaurora.org>
Subject: Re: [PATCH] arm/acpi: hide watchdog timer in GTDT table for dom0
Date: Wed, 30 Nov 2016 10:29:28 +0000 [thread overview]
Message-ID: <e4b09a50-d07c-7933-c77b-ff79da79524e@arm.com> (raw)
In-Reply-To: <1480388349-13887-1-git-send-email-shankerd@codeaurora.org>
Hi Shanker,
On 29/11/2016 02:59, Shanker Donthineni wrote:
> Either we have to hide the watchdog timer section in GTDT or emulate
> watchdog timer block for dom0. Otherwise, system gets panic when
> dom0 accesses its MMIO registers. The current XEN doesn't support
> virtualization of watchdog timer, so hide the watchdog timer section
> for dom0.
IHMO, the patch description is not really accurate. You are removing the
platform timer array that contains watchdog but also Block Timer.
Whilst you mention watchdog, you don't have a word on the Block Timer.
Taking a step back, DOM0 is not able to use it because it does not
request to map the memory region (this is the behavior expected for PCI
and AMBA devices). So this is a bug in the kernel for me.
Assuming this would be fixed, what would be the drawback to give access
to dom0 to the watchdogs?
My worry with that change is what if in the future we decide to expose
watchdog to DOM0? Linux will still not be ready, unless we have Xen to
map those regions at DOM0 build time. That would break the design we
have for ACPI.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-11-30 10:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 2:59 [PATCH] arm/acpi: hide watchdog timer in GTDT table for dom0 Shanker Donthineni
2016-11-29 10:40 ` Jan Beulich
2016-11-29 11:38 ` Roger Pau Monne
2016-11-29 11:44 ` Jan Beulich
2016-11-29 12:09 ` Roger Pau Monne
2016-11-29 13:07 ` Jan Beulich
2016-11-29 14:28 ` Roger Pau Monne
2016-11-29 18:57 ` Stefano Stabellini
2016-11-29 20:19 ` Andrew Cooper
2016-11-30 8:54 ` Jan Beulich
2016-11-30 10:14 ` Roger Pau Monne
2016-11-29 19:08 ` Stefano Stabellini
2016-11-30 9:47 ` Julien Grall
2016-11-30 18:44 ` Stefano Stabellini
2016-11-30 10:29 ` Julien Grall [this message]
2016-11-30 14:31 ` Shanker Donthineni
2016-11-30 14:43 ` Julien Grall
2016-11-30 14:43 ` Shanker Donthineni
2016-11-30 15:00 ` Julien Grall
2016-11-30 15:35 ` Shanker Donthineni
2016-11-30 19:07 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4b09a50-d07c-7933-c77b-ff79da79524e@arm.com \
--to=julien.grall@arm.com \
--cc=scampbel@codeaurora.org \
--cc=shankerd@codeaurora.org \
--cc=sstabellini@kernel.org \
--cc=vikrams@codeaurora.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).