From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: Re: [PATCH v4 2/5] x86emul: generalize exception handling for rep_* hooks Date: Tue, 13 Dec 2016 15:15:42 +0000 Message-ID: References: <584FE4CA020000780012885B@prv-mh.provo.novell.com> <584FE9390200007800128882@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGozr-0005oW-Jy for xen-devel@lists.xenproject.org; Tue, 13 Dec 2016 15:28:03 +0000 In-Reply-To: <584FE9390200007800128882@prv-mh.provo.novell.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich , xen-devel Cc: Andrew Cooper List-Id: xen-devel@lists.xenproject.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+IEZyb206IEphbiBCZXVsaWNoIFttYWlsdG86 SkJldWxpY2hAc3VzZS5jb21dCj4gU2VudDogMTMgRGVjZW1iZXIgMjAxNiAxMToyOAo+IFRvOiB4 ZW4tZGV2ZWwgPHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZz4KPiBDYzogQW5kcmV3IENv b3BlciA8QW5kcmV3LkNvb3BlcjNAY2l0cml4LmNvbT47IFBhdWwgRHVycmFudAo+IDxQYXVsLkR1 cnJhbnRAY2l0cml4LmNvbT4KPiBTdWJqZWN0OiBbUEFUQ0ggdjQgMi81XSB4ODZlbXVsOiBnZW5l cmFsaXplIGV4Y2VwdGlvbiBoYW5kbGluZyBmb3IgcmVwXyoKPiBob29rcwo+IAo+IElmIGFueSBv ZiB0aG9zZSBob29rcyByZXR1cm5zIFg4NkVNVUxfRVhDRVBUSU9OLCBzb21lIHJlZ2lzdGVyIHN0 YXRlCj4gc2hvdWxkIHN0aWxsIGdldCB1cGRhdGVkIGlmIHNvbWUgaXRlcmF0aW9ucyBoYXZlIGJl ZW4gcGVyZm9ybWVkIChidXQKPiB0aGUgcklQIHVwZGF0ZSB3aWxsIGdldCBzdXBwcmVzc2VkIGlm IG5vdCBhbGwgb2YgdGhlbSBkaWQgZ2V0IGhhbmRsZWQpLgo+IFRoaXMgdXBkYXRpbmcgaXMgZG9u ZSBieSByZWdpc3Rlcl9hZGRyZXNzX2luY3JlbWVudCgpIGFuZAo+IF9fcHV0X3JlcF9wcmVmaXgo KSAod2hpY2ggaGVuY2UgbXVzdCBubyBsb25nZXIgYmUgYnlwYXNzZWQpLiBBcyBhCj4gcmVzdWx0 IHB1dF9yZXBfcHJlZml4KCkgY2FuIHRoZW4gc2tpcCBtb3N0IG9mIHRoZSB3cml0ZWJhY2ssIGJ1 dCBuZWVkcwo+IHRvIGVuc3VyZSBwcm9wZXIgY29tcGxldGlvbiBvZiB0aGUgZXhlY3V0ZWQgaW5z dHJ1Y3Rpb24uCj4gCj4gV2hpbGUgb24gdGhlIEhWTSBzaWRlIHRoZSBWQSAtPiBMQSAtPiBQQSB0 cmFuc2xhdGlvbiBwcm9jZXNzIGVuc3VyZXMKPiB0aGF0IGFuIGV4Y2VwdGlvbiB3b3VsZCBiZSBy YWlzZWQgb24gdGhlIGZpcnN0IGl0ZXJhdGlvbiBvbmx5LCBkb2luZyBzbwo+IHdvdWxkIHVuZHVs eSBjb21wbGljYXRlIHRoZSBQViBzaWRlIGNvZGUgYWJvdXQgdG8gYmUgYWRkZWQuCj4gCj4gU2ln bmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgo+IFJldmlld2VkLWJ5 OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPgoKUmV2aWV3ZWQtYnk6 IFBhdWwgRHVycmFudCA8cGF1bC5kdXJyYW50QGNpdHJpeC5jb20+Cgo+IC0tLQo+IHY0OiBNb3Zl IGNoYW5nZXMgdG8geGVuL2FyY2gveDg2L2h2bS9lbXVsYXRlLmMgaGVyZSAoZnJvbSBhIGxhdGVy Cj4gICAgIHBhdGNoKS4gUmUtYmFzZS4KPiB2MzogQnJva2VuIG91dCBmcm9tIGEgbGF0ZXIgcGF0 Y2guCj4gCj4gLS0tIGEveGVuL2FyY2gveDg2L2h2bS9lbXVsYXRlLmMKPiArKysgYi94ZW4vYXJj aC94ODYvaHZtL2VtdWxhdGUuYwo+IEBAIC00NTksNiArNDU5LDcgQEAgc3RhdGljIGludCBodm1l bXVsX2xpbmVhcl90b19waHlzKAo+ICAgICAgewo+ICAgICAgICAgIGlmICggcGZlYyAmIChQRkVD X3BhZ2VfcGFnZWQgfCBQRkVDX3BhZ2Vfc2hhcmVkKSApCj4gICAgICAgICAgICAgIHJldHVybiBY ODZFTVVMX1JFVFJZOwo+ICsgICAgICAgICpyZXBzID0gMDsKPiAgICAgICAgICB4ODZfZW11bF9w YWdlZmF1bHQocGZlYywgYWRkciwgJmh2bWVtdWxfY3R4dC0+Y3R4dCk7Cj4gICAgICAgICAgcmV0 dXJuIFg4NkVNVUxfRVhDRVBUSU9OOwo+ICAgICAgfQo+IEBAIC00NzgsNiArNDc5LDcgQEAgc3Rh dGljIGludCBodm1lbXVsX2xpbmVhcl90b19waHlzKAo+ICAgICAgICAgICAgICBpZiAoIHBmZWMg JiAoUEZFQ19wYWdlX3BhZ2VkIHwgUEZFQ19wYWdlX3NoYXJlZCkgKQo+ICAgICAgICAgICAgICAg ICAgcmV0dXJuIFg4NkVNVUxfUkVUUlk7Cj4gICAgICAgICAgICAgIGRvbmUgLz0gYnl0ZXNfcGVy X3JlcDsKPiArICAgICAgICAgICAgKnJlcHMgPSBkb25lOwo+ICAgICAgICAgICAgICBpZiAoIGRv bmUgPT0gMCApCj4gICAgICAgICAgICAgIHsKPiAgICAgICAgICAgICAgICAgIEFTU0VSVCghcmV2 ZXJzZSk7Cj4gQEAgLTQ4Niw3ICs0ODgsNiBAQCBzdGF0aWMgaW50IGh2bWVtdWxfbGluZWFyX3Rv X3BoeXMoCj4gICAgICAgICAgICAgICAgICB4ODZfZW11bF9wYWdlZmF1bHQocGZlYywgYWRkciAm IFBBR0VfTUFTSywgJmh2bWVtdWxfY3R4dC0KPiA+Y3R4dCk7Cj4gICAgICAgICAgICAgICAgICBy ZXR1cm4gWDg2RU1VTF9FWENFUFRJT047Cj4gICAgICAgICAgICAgIH0KPiAtICAgICAgICAgICAg KnJlcHMgPSBkb25lOwo+ICAgICAgICAgICAgICBicmVhazsKPiAgICAgICAgICB9Cj4gCj4gQEAg LTU3Miw2ICs1NzMsNyBAQCBzdGF0aWMgaW50IGh2bWVtdWxfdmlydHVhbF90b19saW5lYXIoCj4g ICAgICAgKiBuZWl0aGVyIGtub3cgdGhlIGV4YWN0IGVycm9yIGNvZGUgdG8gYmUgdXNlZCwgbm9y IGNhbiB3ZSBlYXNpbHkKPiAgICAgICAqIGRldGVybWluZSB0aGUga2luZCBvZiBleGNlcHRpb24g KCNHUCBvciAjVFMpIGluIHRoYXQgY2FzZS4KPiAgICAgICAqLwo+ICsgICAgKnJlcHMgPSAwOwo+ ICAgICAgaWYgKCBpc194ODZfdXNlcl9zZWdtZW50KHNlZykgKQo+ICAgICAgICAgIHg4Nl9lbXVs X2h3X2V4Y2VwdGlvbigoc2VnID09IHg4Nl9zZWdfc3MpCj4gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgID8gVFJBUF9zdGFja19lcnJvcgo+IC0tLSBhL3hlbi9hcmNoL3g4Ni94ODZfZW11 bGF0ZS94ODZfZW11bGF0ZS5jCj4gKysrIGIveGVuL2FyY2gveDg2L3g4Nl9lbXVsYXRlL3g4Nl9l bXVsYXRlLmMKPiBAQCAtOTcxLDcgKzk3MSwxMSBAQCBzdGF0aWMgdm9pZCBfX3B1dF9yZXBfcHJl Zml4KAo+IAo+ICAjZGVmaW5lIHB1dF9yZXBfcHJlZml4KHJlcHNfY29tcGxldGVkKSAoeyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBcCj4gICAgICBpZiAoIHJlcF9wcmVmaXgoKSApICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwKPiArICAgIHsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgXAo+ICAgICAgICAgIF9fcHV0X3JlcF9wcmVmaXgoJl9yZWdzLCBjdHh0LT5yZWdz LCBhZF9ieXRlcywgcmVwc19jb21wbGV0ZWQpOyBcCj4gKyAgICAgICAgaWYgKCB1bmxpa2VseShy YyA9PSBYODZFTVVMX0VYQ0VQVElPTikgKSAgICAgICAgICAgICAgICAgICAgICAgIFwKPiArICAg ICAgICAgICAgZ290byBub193cml0ZWJhY2s7ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgXAo+ICsgICAgfSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCj4gIH0pCj4gCj4gIC8qIENsaXAgbWF4 aW11bSByZXBldGl0aW9ucyBzbyB0aGF0IHRoZSBpbmRleCByZWdpc3RlciBhdCBtb3N0IGp1c3Qg d3JhcHMuICovCj4gQEAgLTI5MTksMTQgKzI5MjMsOSBAQCB4ODZfZW11bGF0ZSgKPiAgICAgICAg ICBkc3QubWVtLm9mZiA9IHRydW5jYXRlX2VhX2FuZF9yZXBzKF9yZWdzLmVkaSwgbnJfcmVwcywg ZHN0LmJ5dGVzKTsKPiAgICAgICAgICBpZiAoIChyYyA9IGlvcG9ydF9hY2Nlc3NfY2hlY2socG9y dCwgZHN0LmJ5dGVzLCBjdHh0LCBvcHMpKSAhPSAwICkKPiAgICAgICAgICAgICAgZ290byBkb25l Owo+IC0gICAgICAgIGlmICggKG5yX3JlcHMgPiAxKSAmJiAob3BzLT5yZXBfaW5zICE9IE5VTEwp ICYmCj4gKyAgICAgICAgaWYgKCAobnJfcmVwcyA9PSAxKSB8fCAhb3BzLT5yZXBfaW5zIHx8Cj4g ICAgICAgICAgICAgICAoKHJjID0gb3BzLT5yZXBfaW5zKHBvcnQsIGRzdC5tZW0uc2VnLCBkc3Qu bWVtLm9mZiwgZHN0LmJ5dGVzLAo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAm bnJfcmVwcywgY3R4dCkpICE9IFg4NkVNVUxfVU5IQU5ETEVBQkxFKSApCj4gLSAgICAgICAgewo+ IC0gICAgICAgICAgICBpZiAoIHJjICE9IDAgKQo+IC0gICAgICAgICAgICAgICAgZ290byBkb25l Owo+IC0gICAgICAgIH0KPiAtICAgICAgICBlbHNlCj4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICZucl9yZXBzLCBjdHh0KSkgPT0gWDg2RU1VTF9VTkhBTkRMRUFCTEUpICkKPiAg ICAgICAgICB7Cj4gICAgICAgICAgICAgIGZhaWxfaWYob3BzLT5yZWFkX2lvID09IE5VTEwpOwo+ ICAgICAgICAgICAgICBpZiAoIChyYyA9IG9wcy0+cmVhZF9pbyhwb3J0LCBkc3QuYnl0ZXMsICZk c3QudmFsLCBjdHh0KSkgIT0gMCApCj4gQEAgLTI5MzYsNiArMjkzNSw4IEBAIHg4Nl9lbXVsYXRl KAo+ICAgICAgICAgIH0KPiAgICAgICAgICByZWdpc3Rlcl9hZGRyZXNzX2FkanVzdChfcmVncy5l ZGksIG5yX3JlcHMgKiBkc3QuYnl0ZXMpOwo+ICAgICAgICAgIHB1dF9yZXBfcHJlZml4KG5yX3Jl cHMpOwo+ICsgICAgICAgIGlmICggcmMgIT0gWDg2RU1VTF9PS0FZICkKPiArICAgICAgICAgICAg Z290byBkb25lOwo+ICAgICAgICAgIGJyZWFrOwo+ICAgICAgfQo+IAo+IEBAIC0yOTQ2LDE0ICsy OTQ3LDkgQEAgeDg2X2VtdWxhdGUoCj4gICAgICAgICAgZWEubWVtLm9mZiA9IHRydW5jYXRlX2Vh X2FuZF9yZXBzKF9yZWdzLmVzaSwgbnJfcmVwcywgZHN0LmJ5dGVzKTsKPiAgICAgICAgICBpZiAo IChyYyA9IGlvcG9ydF9hY2Nlc3NfY2hlY2socG9ydCwgZHN0LmJ5dGVzLCBjdHh0LCBvcHMpKSAh PSAwICkKPiAgICAgICAgICAgICAgZ290byBkb25lOwo+IC0gICAgICAgIGlmICggKG5yX3JlcHMg PiAxKSAmJiAob3BzLT5yZXBfb3V0cyAhPSBOVUxMKSAmJgo+ICsgICAgICAgIGlmICggKG5yX3Jl cHMgPT0gMSkgfHwgIW9wcy0+cmVwX291dHMgfHwKPiAgICAgICAgICAgICAgICgocmMgPSBvcHMt PnJlcF9vdXRzKGVhLm1lbS5zZWcsIGVhLm1lbS5vZmYsIHBvcnQsIGRzdC5ieXRlcywKPiAtICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZucl9yZXBzLCBjdHh0KSkgIT0gWDg2RU1V TF9VTkhBTkRMRUFCTEUpICkKPiAtICAgICAgICB7Cj4gLSAgICAgICAgICAgIGlmICggcmMgIT0g MCApCj4gLSAgICAgICAgICAgICAgICBnb3RvIGRvbmU7Cj4gLSAgICAgICAgfQo+IC0gICAgICAg IGVsc2UKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZucl9yZXBzLCBjdHh0 KSkgPT0gWDg2RU1VTF9VTkhBTkRMRUFCTEUpICkKPiAgICAgICAgICB7Cj4gICAgICAgICAgICAg IGlmICggKHJjID0gcmVhZF91bG9uZyhlYS5tZW0uc2VnLCB0cnVuY2F0ZV9lYShfcmVncy5lc2kp LAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJmRzdC52YWwsIGRzdC5ieXRl cywgY3R4dCwgb3BzKSkgIT0gMCApCj4gQEAgLTI5NjUsNiArMjk2MSw4IEBAIHg4Nl9lbXVsYXRl KAo+ICAgICAgICAgIH0KPiAgICAgICAgICByZWdpc3Rlcl9hZGRyZXNzX2FkanVzdChfcmVncy5l c2ksIG5yX3JlcHMgKiBkc3QuYnl0ZXMpOwo+ICAgICAgICAgIHB1dF9yZXBfcHJlZml4KG5yX3Jl cHMpOwo+ICsgICAgICAgIGlmICggcmMgIT0gWDg2RU1VTF9PS0FZICkKPiArICAgICAgICAgICAg Z290byBkb25lOwo+ICAgICAgICAgIGJyZWFrOwo+ICAgICAgfQo+IAo+IEBAIC0zMTg3LDE1ICsz MTg1LDEwIEBAIHg4Nl9lbXVsYXRlKAo+ICAgICAgICAgIGRzdC5tZW0uc2VnID0geDg2X3NlZ19l czsKPiAgICAgICAgICBkc3QubWVtLm9mZiA9IHRydW5jYXRlX2VhX2FuZF9yZXBzKF9yZWdzLmVk aSwgbnJfcmVwcywgZHN0LmJ5dGVzKTsKPiAgICAgICAgICBzcmMubWVtLm9mZiA9IHRydW5jYXRl X2VhX2FuZF9yZXBzKF9yZWdzLmVzaSwgbnJfcmVwcywgZHN0LmJ5dGVzKTsKPiAtICAgICAgICBp ZiAoIChucl9yZXBzID4gMSkgJiYgKG9wcy0+cmVwX21vdnMgIT0gTlVMTCkgJiYKPiArICAgICAg ICBpZiAoIChucl9yZXBzID09IDEpIHx8ICFvcHMtPnJlcF9tb3ZzIHx8Cj4gICAgICAgICAgICAg ICAoKHJjID0gb3BzLT5yZXBfbW92cyhlYS5tZW0uc2VnLCBzcmMubWVtLm9mZiwKPiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRzdC5tZW0uc2VnLCBkc3QubWVtLm9mZiwgZHN0 LmJ5dGVzLAo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJm5yX3JlcHMsIGN0 eHQpKSAhPSBYODZFTVVMX1VOSEFORExFQUJMRSkgKQo+IC0gICAgICAgIHsKPiAtICAgICAgICAg ICAgaWYgKCByYyAhPSAwICkKPiAtICAgICAgICAgICAgICAgIGdvdG8gZG9uZTsKPiAtICAgICAg ICB9Cj4gLSAgICAgICAgZWxzZQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Jm5yX3JlcHMsIGN0eHQpKSA9PSBYODZFTVVMX1VOSEFORExFQUJMRSkgKQo+ICAgICAgICAgIHsK PiAgICAgICAgICAgICAgaWYgKCAocmMgPSByZWFkX3Vsb25nKGVhLm1lbS5zZWcsIHNyYy5tZW0u b2ZmLAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJmRzdC52YWwsIGRzdC5i eXRlcywgY3R4dCwgb3BzKSkgIT0gMCApCj4gQEAgLTMyMDYsNiArMzE5OSw4IEBAIHg4Nl9lbXVs YXRlKAo+ICAgICAgICAgIHJlZ2lzdGVyX2FkZHJlc3NfYWRqdXN0KF9yZWdzLmVzaSwgbnJfcmVw cyAqIGRzdC5ieXRlcyk7Cj4gICAgICAgICAgcmVnaXN0ZXJfYWRkcmVzc19hZGp1c3QoX3JlZ3Mu ZWRpLCBucl9yZXBzICogZHN0LmJ5dGVzKTsKPiAgICAgICAgICBwdXRfcmVwX3ByZWZpeChucl9y ZXBzKTsKPiArICAgICAgICBpZiAoIHJjICE9IFg4NkVNVUxfT0tBWSApCj4gKyAgICAgICAgICAg IGdvdG8gZG9uZTsKPiAgICAgICAgICBicmVhazsKPiAgICAgIH0KPiAKPiBAQCAtMzI0NCwxMSAr MzIzOSwxMiBAQCB4ODZfZW11bGF0ZSgKPiAgICAgICAgICAgICAgZHN0LnZhbCA9IHNyYy52YWw7 Cj4gICAgICAgICAgICAgIGRzdC50eXBlID0gT1BfTUVNOwo+ICAgICAgICAgICAgICBucl9yZXBz ID0gMTsKPiArICAgICAgICAgICAgcmMgPSBYODZFTVVMX09LQVk7Cj4gICAgICAgICAgfQo+IC0g ICAgICAgIGVsc2UgaWYgKCByYyAhPSBYODZFTVVMX09LQVkgKQo+IC0gICAgICAgICAgICBnb3Rv IGRvbmU7Cj4gICAgICAgICAgcmVnaXN0ZXJfYWRkcmVzc19hZGp1c3QoX3JlZ3MuZWRpLCBucl9y ZXBzICogZHN0LmJ5dGVzKTsKPiAgICAgICAgICBwdXRfcmVwX3ByZWZpeChucl9yZXBzKTsKPiAr ICAgICAgICBpZiAoIHJjICE9IFg4NkVNVUxfT0tBWSApCj4gKyAgICAgICAgICAgIGdvdG8gZG9u ZTsKPiAgICAgICAgICBicmVhazsKPiAgICAgIH0KPiAKPiAKCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1k ZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK