From: George Dunlap <george.dunlap@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Dario Faggioli <dfaggioli@suse.com>
Subject: Re: [PATCH] xen/credit2: Drop unnecessary bit test
Date: Thu, 11 Jan 2018 16:50:14 +0000 [thread overview]
Message-ID: <e5b93c38-5e8a-3fa1-ee6f-b49ebe45ba1d@citrix.com> (raw)
In-Reply-To: <1515689305-29482-1-git-send-email-andrew.cooper3@citrix.com>
On 01/11/2018 04:48 PM, Andrew Cooper wrote:
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: George Dunlap <george.dunlap@eu.citrix.com>
> CC: Dario Faggioli <dfaggioli@suse.com>
>
> Notices by chance while inspecting the disassembly delta for "x86/bitops:
> Introduce variable/constant pairs for __{set,clear,change}_bit()"
> ---
> xen/common/sched_credit2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c
> index 18f39ca..ee9768e 100644
> --- a/xen/common/sched_credit2.c
> +++ b/xen/common/sched_credit2.c
> @@ -2063,7 +2063,7 @@ csched2_vcpu_sleep(const struct scheduler *ops, struct vcpu *vc)
> update_load(ops, svc->rqd, svc, -1, NOW());
> runq_remove(svc);
> }
> - else if ( svc->flags & CSFLAG_delayed_runq_add )
> + else
> __clear_bit(__CSFLAG_delayed_runq_add, &svc->flags);
There was a reason for this at some point, I'm sure. Did this used to
be the atomic version (without the __) originally?
-George
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-01-11 16:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 16:48 [PATCH] xen/credit2: Drop unnecessary bit test Andrew Cooper
2018-01-11 16:50 ` George Dunlap [this message]
2018-01-11 17:26 ` Dario Faggioli
2018-01-11 17:36 ` Andrew Cooper
2018-01-11 17:37 ` George Dunlap
2018-01-12 8:45 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5b93c38-5e8a-3fa1-ee6f-b49ebe45ba1d@citrix.com \
--to=george.dunlap@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=dfaggioli@suse.com \
--cc=george.dunlap@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).