xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Tu Dinh <ngoc-tu.dinh@vates.tech>
Cc: Anthony PERARD <anthony.perard@vates.tech>,
	Daniel Smith <dpsmith@apertussolutions.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH for-4.22 v2] acpi: Set TPM2 LAML to actual log area size
Date: Thu, 6 Nov 2025 13:19:05 +0100	[thread overview]
Message-ID: <e66a7724-12d3-42e2-805d-b32febb3d346@suse.com> (raw)
In-Reply-To: <e3e182f1-8566-4fe5-b599-3b2f6c582782@vates.tech>

On 06.11.2025 13:13, Tu Dinh wrote:
> On 06/11/2025 13:10, Jan Beulich wrote:
>> On 05.11.2025 01:03, Tu Dinh wrote:
>>> The LAML field should follow the TCG PFP specification:
>>>
>>> The TCG ACPI specification uses the field name "Log Area Minimum
>>> Length", but the field value is the actual log area length reserved by
>>> Platform Firmware, not a lower bound.
>>
>> And this is said where? Even the field description (ACPI 6.5) reads "Identifies
>> the minimum length (in bytes) of the system’s preboot CC event log area." (I
>> agree it makes little sense that way, but the change still needs proper
>> explanation.)
> 
> The above is an exact quote from the "TCG PC Client Platform Firmware 
> Profile Specification Version 1.06 Revision 52".

Interesting. It didn't become clear to me that this actually is a quotation.
Perhaps:

The LAML field should follow the TCG PC Client Platform Firmware Profile
Specification Version. Version 1.06 Revision 52 says:

'The TCG ACPI specification uses the field name "Log Area Minimum
 Length", but the field value is the actual log area length reserved by
 Platform Firmware, not a lower bound.'

Remove the now-unused TPM_LOG_AREA_MINIMUM_SIZE.

? Then
Acked-by: Jan Beulich <jbeulich@suse.com>
and I could make the adjustment while committing (after 4.21 was branched off,
of course).

Jan


  reply	other threads:[~2025-11-06 12:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-05  0:03 [PATCH for-4.22 v2] acpi: Set TPM2 LAML to actual log area size Tu Dinh
2025-11-06 12:09 ` Jan Beulich
2025-11-06 12:13   ` Tu Dinh
2025-11-06 12:19     ` Jan Beulich [this message]
2025-11-06 12:23       ` Tu Dinh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e66a7724-12d3-42e2-805d-b32febb3d346@suse.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=anthony.perard@vates.tech \
    --cc=dpsmith@apertussolutions.com \
    --cc=ngoc-tu.dinh@vates.tech \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).