From: Julien Grall <julien.grall@linaro.org>
To: Jan Beulich <JBeulich@suse.com>, Yu Zhang <yu.c.zhang@linux.intel.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Julien Grall <julien.grall@arm.com>,
yi.z.zhang@intel.com, min.he@intel.com, xen-devel@lists.xen.org
Subject: Re: [PATCH v2 1/2] x86/mm: fix a potential race condition in map_pages_to_xen().
Date: Mon, 13 Nov 2017 11:22:31 +0000 [thread overview]
Message-ID: <e6fd91bf-652e-717b-8d9a-afacf5ed5f15@linaro.org> (raw)
In-Reply-To: <5A098AC2020000780018E4CF@prv-mh.provo.novell.com>
Hi,
On 11/13/2017 11:06 AM, Jan Beulich wrote:
>>>> On 13.11.17 at 11:34, <yu.c.zhang@linux.intel.com> wrote:
>> Our debug showed the concerned page->count_info was already(and
>> unexpectedly)
>> cleared in free_xenheap_pages(), and the call trace should be like this:
>>
>> free_xenheap_pages()
>> ^
>> |
>> free_xen_pagetable()
>> ^
>> |
>> map_pages_to_xen()
>> ^
>> |
>> update_xen_mappings()
>> ^
>> |
>> get_page_from_l1e()
>> ^
>> |
>> mod_l1_entry()
>> ^
>> |
>> do_mmu_update()
>
> This ...
>
>> Is above description convincing enough? :-)
>
> ... is indeed enough for me to suggest to Julien that we take both
> patches (once they're ready). But it's his decision in the end.
I will wait the series to be ready before giving my release-ack.
Cheers,
> Jan
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2017-11-13 11:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 7:18 [PATCH v2 1/2] x86/mm: fix a potential race condition in map_pages_to_xen() Yu Zhang
2017-11-10 7:18 ` [PATCH v2 2/2] x86/mm: fix a potential race condition in modify_xen_mappings() Yu Zhang
2017-11-10 9:57 ` Jan Beulich
2017-11-10 14:02 ` Yu Zhang
2017-11-13 9:33 ` Jan Beulich
2017-11-10 9:49 ` [PATCH v2 1/2] x86/mm: fix a potential race condition in map_pages_to_xen() Jan Beulich
2017-11-10 14:05 ` Yu Zhang
2017-11-13 9:31 ` Jan Beulich
2017-11-13 10:34 ` Yu Zhang
2017-11-13 11:06 ` Jan Beulich
2017-11-13 11:22 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6fd91bf-652e-717b-8d9a-afacf5ed5f15@linaro.org \
--to=julien.grall@linaro.org \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien.grall@arm.com \
--cc=min.he@intel.com \
--cc=xen-devel@lists.xen.org \
--cc=yi.z.zhang@intel.com \
--cc=yu.c.zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).