Re: [PATCH v4 5/7] xen: credit2: group the runq manipulating functions.

[George Dunlap <george.dunlap@citrix.com>]

On 01/03/17 14:53, Dario Faggioli wrote:
> So that they're all close among each other, and
> also near to the comment describing the runqueue
> organization (which is also moved).
> 
> No functional change intended.
> 
> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> ---
> Cc: George Dunlap <george.dunlap@eu.citrix.com>
> Cc: Anshul Makkar <anshul.makkar@citrix.com>
> ---
> Changes from v3:
> * fix a typo in the changelog.
> 
> Changes from v2:
> * don't move the 'credit2_runqueue' option parsing code, as suggested during
>   review;
> ---
>  xen/common/sched_credit2.c |  408 ++++++++++++++++++++++----------------------
>  1 file changed, 204 insertions(+), 204 deletions(-)
> 
> diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c
> index 1f57239..66b7f96 100644
> --- a/xen/common/sched_credit2.c
> +++ b/xen/common/sched_credit2.c
> @@ -569,7 +569,7 @@ static int get_fallback_cpu(struct csched2_vcpu *svc)
>  
>  /*
>   * Time-to-credit, credit-to-time.
> - * 
> + *
>   * We keep track of the "residual" time to make sure that frequent short
>   * schedules still get accounted for in the end.
>   *
> @@ -590,7 +590,7 @@ static s_time_t c2t(struct csched2_runqueue_data *rqd, s_time_t credit, struct c
>  }
>  
>  /*
> - * Runqueue related code
> + * Runqueue related code.

You realize we changed CODING_STYLE to not require a full stop if there
was only one line?  This isn't a complete sentence so I would leave the
full stop out.

But that's just for future reference -- I don't care enough about this
in general, I just wanted to raise it to your attention.  :-)

Acked-by: George Dunlap <george.dunlap@citrix.com>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel