From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manish Jaggi Subject: Re: [RFC 06/11] fwnode xen spacific changes Date: Tue, 6 Mar 2018 19:13:11 +0530 Message-ID: References: <20180102092809.1841-1-manish.jaggi@linaro.org> <20180102092809.1841-7-manish.jaggi@linaro.org> <521998b8-1179-bc87-db7b-a4e3aee0c644@linaro.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0104517590773740308==" Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1etCsF-0004b2-Ag for xen-devel@lists.xenproject.org; Tue, 06 Mar 2018 13:43:23 +0000 Received: by mail-pf0-x236.google.com with SMTP id a16so8723160pfn.9 for ; Tue, 06 Mar 2018 05:43:21 -0800 (PST) In-Reply-To: <521998b8-1179-bc87-db7b-a4e3aee0c644@linaro.org> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Julien Grall , xen-devel@lists.xenproject.org, sameer.goel@linaro.org, andre.przywara@linaro.org Cc: Jan Beulich , manish.jaggi@cavium.com List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --===============0104517590773740308== Content-Type: multipart/alternative; boundary="------------42828D510658E72ACF5E840E" Content-Language: en-US This is a multi-part message in MIME format. --------------42828D510658E72ACF5E840E Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Hi Julien, On 01/19/2018 12:21 AM, Julien Grall wrote: >> diff --git a/xen/include/asm-arm/device.h b/xen/include/asm-arm/device.h >> index 6734ae8efd..f78482ca0c 100644 >> --- a/xen/include/asm-arm/device.h >> +++ b/xen/include/asm-arm/device.h >> @@ -6,6 +6,8 @@ >> enum device_type >> { >> DEV_DT, >> + DEV_ACPI, > > You don't use DEV_ACPI in this patch. So why is there? > >> + DEV_PCI, >> }; >> struct dev_archdata { >> @@ -18,8 +20,13 @@ struct device >> enum device_type type; >> #ifdef CONFIG_HAS_DEVICE_TREE >> struct dt_device_node *of_node; /* Used by drivers imported >> from Linux */ > > As said on Sameer's patches, I was expecting a todo in the code after > the discussion about leave of_node here. I think you are referring to https://patchwork.kernel.org/patch/9963109/ Could you please add what TODO you wish to add ? I could not find any discussion on of_node in the mail chain -Regards Manish --------------42828D510658E72ACF5E840E Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit

Hi Julien,

On 01/19/2018 12:21 AM, Julien Grall wrote:

diff --git a/xen/include/asm-arm/device.h b/xen/include/asm-arm/device.h
index 6734ae8efd..f78482ca0c 100644
--- a/xen/include/asm-arm/device.h
+++ b/xen/include/asm-arm/device.h
@@ -6,6 +6,8 @@
enum device_type
{
      DEV_DT,
+    DEV_ACPI,

You don't use DEV_ACPI in this patch. So why is there?

+    DEV_PCI,
};
struct dev_archdata {
@@ -18,8 +20,13 @@ struct device
      enum device_type type;
#ifdef CONFIG_HAS_DEVICE_TREE
      struct dt_device_node *of_node; /* Used by drivers imported from Linux */

As said on Sameer's patches, I was expecting a todo in the code after the discussion about leave of_node here.

I think you are referring to https://patchwork.kernel.org/patch/9963109/
Could you please add what TODO you wish to add ?

I could not find any discussion on of_node in the mail chain

-Regards
Manish
--------------42828D510658E72ACF5E840E-- --===============0104517590773740308== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== --===============0104517590773740308==--