From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: andrew.cooper3@citrix.com, xen-devel@lists.xen.org,
wei.liu2@citrix.com, ian.jackson@eu.citrix.com,
roger.pau@citrix.com
Subject: Re: [PATCH v4 11/15] pvh: Send an SCI on VCPU hotplug event
Date: Tue, 6 Dec 2016 11:43:55 -0500 [thread overview]
Message-ID: <e931f210-a49f-9708-3b54-228bdbe7d975@oracle.com> (raw)
In-Reply-To: <5846DE510200007800125D4A@prv-mh.provo.novell.com>
On 12/06/2016 09:50 AM, Jan Beulich wrote:
>>
>> +
>> + /*
>> + * If a new bit has been set in status register and corresponding
>> + * event is enabled then an SCI is sent to the guest.
>> + */
>> + if ( !is_guest_access &&
>> + ((*sts ^ sts_orig) & ~sts_orig) && (*sts & *en))
>> + send_guest_global_virq(d, VIRQ_SCI);
> I don't think comment and condition match; namely the
> "corresponding" doesn't appear to be fulfilled - you raise
> SCI if any bit is set both in *sts and *en.
Oh, that was just wrong. Should be (taking your simplification below in
to account)
(*sts & ~sts_orig) & *en
-boris
>
> Also (a ^ b) & ~b = a & ~b afaict.
>
> Jan
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-12-06 16:43 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 15:33 [PATCH v4 00/15] PVH VCPU hotplug support Boris Ostrovsky
2016-11-29 15:33 ` [PATCH v4 01/15] x86/pmtimer: Move ACPI registers from PMTState to hvm_domain Boris Ostrovsky
2016-12-01 15:52 ` Jan Beulich
2016-12-01 16:28 ` Boris Ostrovsky
2016-12-01 16:29 ` Andrew Cooper
2016-12-01 16:45 ` Boris Ostrovsky
2016-12-12 16:24 ` Wei Liu
2016-11-29 15:33 ` [PATCH v4 02/15] acpi: Make pmtimer optional in FADT Boris Ostrovsky
2016-11-29 15:33 ` [PATCH v4 03/15] acpi: Power and Sleep ACPI buttons are not emulated for PVH guests Boris Ostrovsky
2016-11-29 15:33 ` [PATCH v4 04/15] acpi: PVH guests need _E02 method Boris Ostrovsky
2016-11-29 15:33 ` [PATCH v4 05/15] acpi/x86: Define ACPI IO registers for PVH guests Boris Ostrovsky
2016-12-01 15:57 ` Jan Beulich
2016-12-01 16:30 ` Boris Ostrovsky
2016-11-29 15:33 ` [PATCH v4 06/15] domctl: Add XEN_DOMCTL_acpi_access Boris Ostrovsky
2016-12-01 16:06 ` Jan Beulich
2016-12-01 16:43 ` Boris Ostrovsky
2016-12-02 7:48 ` Jan Beulich
2016-12-12 13:08 ` Boris Ostrovsky
2016-12-12 14:02 ` Jan Beulich
2016-12-12 16:19 ` Boris Ostrovsky
2016-12-12 16:24 ` Jan Beulich
2016-12-12 13:28 ` Julien Grall
2016-12-12 16:11 ` Boris Ostrovsky
2016-12-13 13:02 ` Julien Grall
2016-11-29 15:33 ` [PATCH v4 07/15] pvh/acpi: Install handlers for ACPI-related PVH IO accesses Boris Ostrovsky
2016-12-01 16:32 ` Jan Beulich
2016-12-01 17:03 ` Boris Ostrovsky
2016-11-29 15:33 ` [PATCH v4 08/15] pvh/acpi: Handle ACPI accesses for PVH guests Boris Ostrovsky
2016-12-06 14:34 ` Jan Beulich
2016-12-06 16:37 ` Boris Ostrovsky
2016-12-07 8:06 ` Jan Beulich
2016-11-29 15:33 ` [PATCH v4 09/15] x86/domctl: Handle ACPI access from domctl Boris Ostrovsky
2016-11-29 15:33 ` [PATCH v4 10/15] events/x86: Define SCI virtual interrupt Boris Ostrovsky
2016-12-06 14:36 ` Jan Beulich
2016-11-29 15:33 ` [PATCH v4 11/15] pvh: Send an SCI on VCPU hotplug event Boris Ostrovsky
2016-12-06 14:50 ` Jan Beulich
2016-12-06 16:43 ` Boris Ostrovsky [this message]
2016-11-29 15:33 ` [PATCH v4 12/15] tools: Call XEN_DOMCTL_acpi_access on PVH VCPU hotplug Boris Ostrovsky
2016-12-12 16:35 ` Wei Liu
2016-12-12 16:47 ` Boris Ostrovsky
2016-12-12 16:50 ` Boris Ostrovsky
2016-12-12 17:09 ` Wei Liu
2016-12-12 17:14 ` Boris Ostrovsky
2016-12-12 17:13 ` Wei Liu
2016-11-29 15:33 ` [PATCH v4 13/15] pvh: Set online VCPU map to avail_vcpus Boris Ostrovsky
2016-11-29 15:33 ` [PATCH v4 14/15] pvh/acpi: Save ACPI registers for PVH guests Boris Ostrovsky
2016-11-29 15:33 ` [PATCH v4 15/15] docs: Describe PVHv2's VCPU hotplug procedure Boris Ostrovsky
2016-12-06 20:55 ` Konrad Rzeszutek Wilk
2016-11-29 16:11 ` [PATCH v4 00/15] PVH VCPU hotplug support Jan Beulich
2016-11-29 16:40 ` Boris Ostrovsky
2016-11-29 16:43 ` Jan Beulich
2016-11-29 17:00 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e931f210-a49f-9708-3b54-228bdbe7d975@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).