From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergey Dyasli Subject: Re: [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure Date: Wed, 12 Sep 2018 09:46:31 +0000 Message-ID: References: <1536692177-15675-1-git-send-email-andrew.cooper3@citrix.com> <1536692177-15675-4-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US Content-ID: <55763095B7669B4094CF372CD6785D31@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Andrew Cooper , "xen-devel@lists.xen.org" Cc: Wei Liu , "JBeulich@suse.com" , Roger Pau Monne List-Id: xen-devel@lists.xenproject.org T24gV2VkLCAyMDE4LTA5LTEyIGF0IDEwOjEyICswMTAwLCBBbmRyZXcgQ29vcGVyIHdyb3RlOg0K PiBPbiAxMi8wOS8xOCAwOToyOSwgU2VyZ2V5IER5YXNsaSB3cm90ZToNCj4gPiBPbiBUdWUsIDIw MTgtMDktMTEgYXQgMTk6NTYgKzAxMDAsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+ID4gPiBSZW5h bWUgdGhlbSB0byBndWVzdF97cmQsd3J9bXNyX3hlbigpIGZvciBjb25zaXN0ZW5jeSwgYW5kIGJl Y2F1c2UgdGhlIF9yZWdzDQo+ID4gPiBzdWZmaXggaXNuJ3QgdmVyeSBhcHByb3ByaWF0ZS4NCj4g PiA+IA0KPiA+ID4gVXBkYXRlIHRoZW0gdG8gdGFrZSBhIHZjcHUgcG9pbnRlciByYXRoZXIgdGhh biBwcmVzdW1pbmcgdGhhdCB0aGV5IGFjdCBvbg0KPiA+ID4gY3VycmVudCwgYW5kIHN3aXRjaCB0 byB1c2luZyBYODZFTVVMXyogcmV0dXJuIHZhbHVlcy4NCj4gPiA+IA0KPiA+ID4gU2lnbmVkLW9m Zi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCj4gPiA+IC0t LQ0KPiA+ID4gQ0M6IEphbiBCZXVsaWNoIDxKQmV1bGljaEBzdXNlLmNvbT4NCj4gPiA+IENDOiBX ZWkgTGl1IDx3ZWkubGl1MkBjaXRyaXguY29tPg0KPiA+ID4gQ0M6IFJvZ2VyIFBhdSBNb25uw6kg PHJvZ2VyLnBhdUBjaXRyaXguY29tPg0KPiA+ID4gQ0M6IFNlcmdleSBEeWFzbGkgPHNlcmdleS5k eWFzbGlAY2l0cml4LmNvbT4NCj4gPiA+IA0KPiA+ID4gdjM6DQo+ID4gPiAgKiBDbGVhbiB1cCBh ZnRlciBzcGxpdHRpbmcgdGhlIHNlcmllcy4NCj4gPiA+IC0tLQ0KPiA+ID4gIHhlbi9hcmNoL3g4 Ni9tc3IuYyAgICAgICAgICAgICAgfCAgNiArKy0tLS0NCj4gPiA+ICB4ZW4vYXJjaC94ODYvdHJh cHMuYyAgICAgICAgICAgIHwgMjkgKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0NCj4gPiA+ ICB4ZW4vaW5jbHVkZS9hc20teDg2L3Byb2Nlc3Nvci5oIHwgIDQgKystLQ0KPiA+ID4gIDMgZmls ZXMgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgMjIgZGVsZXRpb25zKC0pDQo+ID4gPiANCj4g PiA+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvbXNyLmMgYi94ZW4vYXJjaC94ODYvbXNyLmMN Cj4gPiA+IGluZGV4IGNmMGRjMjcuLjhmMDJhODkgMTAwNjQ0DQo+ID4gPiAtLS0gYS94ZW4vYXJj aC94ODYvbXNyLmMNCj4gPiA+ICsrKyBiL3hlbi9hcmNoL3g4Ni9tc3IuYw0KPiA+ID4gQEAgLTE1 Niw4ICsxNTYsNyBAQCBpbnQgZ3Vlc3RfcmRtc3IoY29uc3Qgc3RydWN0IHZjcHUgKnYsIHVpbnQz Ml90IG1zciwgdWludDY0X3QgKnZhbCkNCj4gPiA+ICANCj4gPiA+ICAgICAgICAgIC8qIEZhbGx0 aHJvdWdoLiAqLw0KPiA+ID4gICAgICBjYXNlIDB4NDAwMDAyMDAgLi4uIDB4NDAwMDAyZmY6DQo+ ID4gPiAtICAgICAgICByZXQgPSAocmRtc3JfaHlwZXJ2aXNvcl9yZWdzKG1zciwgdmFsKQ0KPiA+ ID4gLSAgICAgICAgICAgICAgID8gWDg2RU1VTF9PS0FZIDogWDg2RU1VTF9FWENFUFRJT04pOw0K PiA+ID4gKyAgICAgICAgcmV0ID0gZ3Vlc3RfcmRtc3JfeGVuKHYsIG1zciwgdmFsKTsNCj4gPiA+ ICAgICAgICAgIGJyZWFrOw0KPiA+ID4gIA0KPiA+ID4gICAgICBkZWZhdWx0Og0KPiA+ID4gQEAg LTI3Nyw4ICsyNzYsNyBAQCBpbnQgZ3Vlc3Rfd3Jtc3Ioc3RydWN0IHZjcHUgKnYsIHVpbnQzMl90 IG1zciwgdWludDY0X3QgdmFsKQ0KPiA+ID4gIA0KPiA+ID4gICAgICAgICAgLyogRmFsbHRocm91 Z2guICovDQo+ID4gPiAgICAgIGNhc2UgMHg0MDAwMDIwMCAuLi4gMHg0MDAwMDJmZjoNCj4gPiA+ IC0gICAgICAgIHJldCA9ICh3cm1zcl9oeXBlcnZpc29yX3JlZ3MobXNyLCB2YWwpID09IDENCj4g PiA+IC0gICAgICAgICAgICAgICA/IFg4NkVNVUxfT0tBWSA6IFg4NkVNVUxfRVhDRVBUSU9OKTsN Cj4gPiA+ICsgICAgICAgIHJldCA9IGd1ZXN0X3dybXNyX3hlbih2LCBtc3IsIHZhbCk7DQo+ID4g PiAgICAgICAgICBicmVhazsNCj4gPiA+ICANCj4gPiA+ICAgICAgZGVmYXVsdDoNCj4gPiA+IGRp ZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvdHJhcHMuYyBiL3hlbi9hcmNoL3g4Ni90cmFwcy5jDQo+ ID4gPiBpbmRleCA3YzE3ODA2Li4zOTg4NzUzIDEwMDY0NA0KPiA+ID4gLS0tIGEveGVuL2FyY2gv eDg2L3RyYXBzLmMNCj4gPiA+ICsrKyBiL3hlbi9hcmNoL3g4Ni90cmFwcy5jDQo+ID4gPiBAQCAt NzY4LDI5ICs3NjgsMjUgQEAgc3RhdGljIHZvaWQgZG9fdHJhcChzdHJ1Y3QgY3B1X3VzZXJfcmVn cyAqcmVncykNCj4gPiA+ICAgICAgICAgICAgdHJhcG5yLCB0cmFwc3RyKHRyYXBuciksIHJlZ3Mt PmVycm9yX2NvZGUpOw0KPiA+ID4gIH0NCj4gPiA+ICANCj4gPiA+IC0vKiBSZXR1cm5zIDAgaWYg bm90IGhhbmRsZWQsIGFuZCBub24tMCBmb3Igc3VjY2Vzcy4gKi8NCj4gPiA+IC1pbnQgcmRtc3Jf aHlwZXJ2aXNvcl9yZWdzKHVpbnQzMl90IGlkeCwgdWludDY0X3QgKnZhbCkNCj4gPiA+ICtpbnQg Z3Vlc3RfcmRtc3JfeGVuKGNvbnN0IHN0cnVjdCB2Y3B1ICp2LCB1aW50MzJfdCBpZHgsIHVpbnQ2 NF90ICp2YWwpDQo+ID4gPiAgew0KPiA+ID4gLSAgICBzdHJ1Y3QgZG9tYWluICpkID0gY3VycmVu dC0+ZG9tYWluOw0KPiA+ID4gKyAgICBjb25zdCBzdHJ1Y3QgZG9tYWluICpkID0gdi0+ZG9tYWlu Ow0KPiA+ID4gICAgICAvKiBPcHRpb25hbGx5IHNoaWZ0IG91dCBvZiB0aGUgd2F5IG9mIFZpcmlk aWFuIGFyY2hpdGVjdHVyYWwgTVNScy4gKi8NCj4gPiA+ICAgICAgdWludDMyX3QgYmFzZSA9IGlz X3ZpcmlkaWFuX2RvbWFpbihkKSA/IDB4NDAwMDAyMDAgOiAweDQwMDAwMDAwOw0KPiA+ID4gIA0K PiA+ID4gICAgICBzd2l0Y2ggKCBpZHggLSBiYXNlICkNCj4gPiA+ICAgICAgew0KPiA+ID4gICAg ICBjYXNlIDA6IC8qIFdyaXRlIGh5cGVyY2FsbCBwYWdlIE1TUi4gIFJlYWQgYXMgemVyby4gKi8N Cj4gPiA+IC0gICAgew0KPiA+ID4gICAgICAgICAgKnZhbCA9IDA7DQo+ID4gPiAtICAgICAgICBy ZXR1cm4gMTsNCj4gPiA+IC0gICAgfQ0KPiA+ID4gKyAgICAgICAgcmV0dXJuIFg4NkVNVUxfT0tB WTsNCj4gPiA+ICAgICAgfQ0KPiA+ID4gIA0KPiA+ID4gLSAgICByZXR1cm4gMDsNCj4gPiA+ICsg ICAgcmV0dXJuIFg4NkVNVUxfRVhDRVBUSU9OOw0KPiA+ID4gIH0NCj4gPiA+ICANCj4gPiA+IC0v KiBSZXR1cm5zIDEgaWYgaGFuZGxlZCwgMCBpZiBub3QgYW5kIC1FeHggZm9yIGVycm9yLiAqLw0K PiA+ID4gLWludCB3cm1zcl9oeXBlcnZpc29yX3JlZ3ModWludDMyX3QgaWR4LCB1aW50NjRfdCB2 YWwpDQo+ID4gPiAraW50IGd1ZXN0X3dybXNyX3hlbihzdHJ1Y3QgdmNwdSAqdiwgdWludDMyX3Qg aWR4LCB1aW50NjRfdCB2YWwpDQo+ID4gPiAgew0KPiA+ID4gLSAgICBzdHJ1Y3QgZG9tYWluICpk ID0gY3VycmVudC0+ZG9tYWluOw0KPiA+ID4gKyAgICBzdHJ1Y3QgZG9tYWluICpkID0gdi0+ZG9t YWluOw0KPiA+ID4gICAgICAvKiBPcHRpb25hbGx5IHNoaWZ0IG91dCBvZiB0aGUgd2F5IG9mIFZp cmlkaWFuIGFyY2hpdGVjdHVyYWwgTVNScy4gKi8NCj4gPiA+ICAgICAgdWludDMyX3QgYmFzZSA9 IGlzX3ZpcmlkaWFuX2RvbWFpbihkKSA/IDB4NDAwMDAyMDAgOiAweDQwMDAwMDAwOw0KPiA+ID4g IA0KPiA+ID4gQEAgLTgwOSw3ICs4MDUsNyBAQCBpbnQgd3Jtc3JfaHlwZXJ2aXNvcl9yZWdzKHVp bnQzMl90IGlkeCwgdWludDY0X3QgdmFsKQ0KPiA+ID4gICAgICAgICAgICAgIGdkcHJpbnRrKFhF TkxPR19XQVJOSU5HLA0KPiA+ID4gICAgICAgICAgICAgICAgICAgICAgICJ3cm1zciBoeXBlcmNh bGwgcGFnZSBpbmRleCAlI3ggdW5zdXBwb3J0ZWRcbiIsDQo+ID4gPiAgICAgICAgICAgICAgICAg ICAgICAgcGFnZV9pbmRleCk7DQo+ID4gPiAtICAgICAgICAgICAgcmV0dXJuIDA7DQo+ID4gPiAr ICAgICAgICAgICAgcmV0dXJuIFg4NkVNVUxfRVhDRVBUSU9OOw0KPiA+ID4gICAgICAgICAgfQ0K PiA+ID4gIA0KPiA+ID4gICAgICAgICAgcGFnZSA9IGdldF9wYWdlX2Zyb21fZ2ZuKGQsIGdtZm4s ICZ0LCBQMk1fQUxMT0MpOw0KPiA+ID4gQEAgLTgyMiwxMyArODE4LDEzIEBAIGludCB3cm1zcl9o eXBlcnZpc29yX3JlZ3ModWludDMyX3QgaWR4LCB1aW50NjRfdCB2YWwpDQo+ID4gPiAgICAgICAg ICAgICAgaWYgKCBwMm1faXNfcGFnaW5nKHQpICkNCj4gPiA+ICAgICAgICAgICAgICB7DQo+ID4g PiAgICAgICAgICAgICAgICAgIHAybV9tZW1fcGFnaW5nX3BvcHVsYXRlKGQsIGdtZm4pOw0KPiA+ ID4gLSAgICAgICAgICAgICAgICByZXR1cm4gLUVSRVNUQVJUOw0KPiA+ID4gKyAgICAgICAgICAg ICAgICByZXR1cm4gWDg2RU1VTF9SRVRSWTsNCj4gPiANCj4gPiBQcmV2aW91c2x5IC1FUkVTVEFS VCB3b3VsZCd2ZSBiZWVuIGNvbnZlcnRlZCB0byBYODZFTVVMX0VYQ0VQVElPTi4gQnV0DQo+ID4g d2l0aCB0aGlzIHBhdGNoLCBYODZFTVVMX1JFVFJZIHdpbGwgYWN0dWFsbHkgYmUgcmV0dXJuZWQu IEkgZG9uJ3QgdGhpbmsNCj4gPiB0aGF0IGNhbGxlcnMgY2FuIGhhbmRsZSB0aGlzIHNpdHVhdGlv bi4NCj4gPiANCj4gPiBFLmcuIHRoZSBjb2RlIGZyb20gdm14X3ZtZXhpdF9oYW5kbGVyKCk6DQo+ ID4gDQo+ID4gICAgIGNhc2UgRVhJVF9SRUFTT05fTVNSX1dSSVRFOg0KPiA+ICAgICAgICAgc3dp dGNoICggaHZtX21zcl93cml0ZV9pbnRlcmNlcHQocmVncy0+ZWN4LCBtc3JfZm9sZChyZWdzKSwg MSkgKQ0KPiA+ICAgICAgICAgew0KPiA+ICAgICAgICAgY2FzZSBYODZFTVVMX09LQVk6DQo+ID4g ICAgICAgICAgICAgdXBkYXRlX2d1ZXN0X2VpcCgpOyAvKiBTYWZlOiBXUk1TUiAqLw0KPiA+ICAg ICAgICAgICAgIGJyZWFrOw0KPiA+IA0KPiA+ICAgICAgICAgY2FzZSBYODZFTVVMX0VYQ0VQVElP TjoNCj4gPiAgICAgICAgICAgICBodm1faW5qZWN0X2h3X2V4Y2VwdGlvbihUUkFQX2dwX2ZhdWx0 LCAwKTsNCj4gPiAgICAgICAgICAgICBicmVhazsNCj4gPiAgICAgICAgIH0NCj4gPiAgICAgICAg IGJyZWFrOw0KPiANCj4gSG1tIGxvdmVseSwgc28gaXQgd2FzIGJyb2tlbiBiZWZvcmUsIGJ1dCBz aG91bGQgYmUgY29ycmVjdCBub3cuDQo+IA0KPiBSRVRSWSBoYXMgY2F1c2VkIGFuIGVudHJ5IHRv IGdvIG9udG8gdGhlIHBhZ2luZyByaW5nLCB3aGljaCB3aWxsIHBhdXNlDQo+IHRoZSB2Y3B1IHVu dGlsIGEgcmVwbHkgb2NjdXJzLCBhZnRlciB3aGljaCB3ZSB3aWxsIHJlLWVudGVyIHRoZSBndWVz dA0KPiB3aXRob3V0IGhhdmluZyBtb3ZlZCBSSVAgZm9yd2FyZHMsIHJlLWV4ZWN1dGUgdGhlIHdy bXNyIGluc3RydWN0aW9uLCBhbmQNCj4gdGhpcyB0aW1lIHN1Y2NlZWQgYmVjYXVzZSB0aGUgZnJh bWUgaGFzIGJlZW4gcGFnZWQgaW4uDQoNCkFjdHVhbGx5LCB0aGUgY3VycmVudCBWTVgvU1ZNIChi dXQgbm90IFBWKSBjb2RlIGRvZXM6DQoNCiAgICAgICAgc3dpdGNoICggd3Jtc3JfaHlwZXJ2aXNv cl9yZWdzKG1zciwgbXNyX2NvbnRlbnQpICkNCiAgICAgICAgew0KICAgICAgICBjYXNlIC1FUkVT VEFSVDoNCiAgICAgICAgICAgIHJldHVybiBYODZFTVVMX1JFVFJZOw0KDQpUaGlzIGNvZGUgaXMg cmVtb3ZlZCBpbiAxLzMgcGF0Y2ggYnV0IEkgd2Fzbid0IENDZWQuDQoNCi0tIA0KVGhhbmtzLA0K U2VyZ2V5Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhl bi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBz Oi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw=