From: Julien Grall <julien.grall@arm.com>
To: Zhongze Liu <blackskygg@gmail.com>, Wei Liu <wei.liu2@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v4 5/7] libxl: support unmapping static shared memory areas during domain destruction
Date: Mon, 12 Feb 2018 15:09:43 +0000 [thread overview]
Message-ID: <ebd7c9f4-4a71-365e-cbb6-05c20b9042b7@arm.com> (raw)
In-Reply-To: <CAHrd_jpTGxOnjphH1wk8NJSpiw2FhAMNDGnGL2YYKpJ=wca0BQ@mail.gmail.com>
Hi,
On 12/02/18 14:52, Zhongze Liu wrote:
> 2018-02-08 0:54 GMT+08:00 Julien Grall <julien.grall@arm.com>:
>> On 07/02/18 16:27, Zhongze Liu wrote:
> It seems that I mistakenly use transaction as a global lock. Now I don't have
> any reasons not putting the unmap out of the transaction, but this will break
> the original transaction into two, and I do think that we need some explicit
> locking here.
Can you explain why you need specific locking here? What are you trying
to protect? Are you trying to protect against two process doing the unmap?
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-02-12 15:09 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 17:50 [PATCH v4 0/7] Allow setting up shared memory areas between VMs from xl config files Zhongze Liu
2018-01-30 17:50 ` [PATCH v4 1/7] libxc: add xc_domain_remove_from_physmap to wrap XENMEM_remove_from_physmap Zhongze Liu
2018-01-30 17:50 ` [PATCH v4 2/7] xen: xsm: flask: introduce XENMAPSPACE_gmfn_share for memory sharing Zhongze Liu
2018-02-01 10:23 ` Jan Beulich
2018-02-01 18:11 ` Zhongze Liu
2018-02-02 8:32 ` Jan Beulich
2018-02-05 9:59 ` Zhongze Liu
2018-02-13 15:15 ` Zhongze Liu
2018-02-13 15:26 ` Jan Beulich
2018-02-14 7:15 ` Zhongze Liu
2018-02-14 8:37 ` Jan Beulich
2018-02-14 17:02 ` Zhongze Liu
2018-02-15 8:58 ` Jan Beulich
2018-02-24 2:50 ` Zhongze Liu
2018-02-24 5:37 ` Zhongze Liu
2018-02-26 7:53 ` Jan Beulich
2018-02-06 11:04 ` Julien Grall
2018-01-30 17:50 ` [PATCH v4 3/7] libxl: introduce a new structure to represent static shared memory regions Zhongze Liu
2018-02-06 11:27 ` Julien Grall
2018-02-06 15:41 ` Zhongze Liu
2018-02-06 15:46 ` Julien Grall
2018-02-06 16:06 ` Zhongze Liu
2018-02-06 17:23 ` Julien Grall
2018-01-30 17:50 ` [PATCH v4 4/7] libxl: support mapping static shared memory areas during domain creation Zhongze Liu
2018-02-06 13:07 ` Julien Grall
2018-02-06 15:59 ` Zhongze Liu
2018-02-06 17:30 ` Julien Grall
2018-02-06 17:47 ` Wei Liu
2018-02-12 15:08 ` Zhongze Liu
2018-02-14 14:26 ` Wei Liu
2018-01-30 17:50 ` [PATCH v4 5/7] libxl: support unmapping static shared memory areas during domain destruction Zhongze Liu
2018-02-06 13:24 ` Julien Grall
2018-02-06 18:06 ` Wei Liu
2018-02-07 16:27 ` Zhongze Liu
2018-02-07 16:54 ` Julien Grall
2018-02-12 14:52 ` Zhongze Liu
2018-02-12 15:09 ` Julien Grall [this message]
2018-02-12 15:17 ` Zhongze Liu
2018-02-12 15:24 ` Julien Grall
2018-02-14 14:35 ` Wei Liu
2018-02-14 14:39 ` Wei Liu
2018-02-26 12:08 ` Ian Jackson
2018-01-30 17:50 ` [PATCH v4 6/7] libxl:xl: add parsing code to parse "libxl_static_sshm" from xl config files Zhongze Liu
2018-01-30 17:50 ` [PATCH v4 7/7] docs: documentation about static shared memory regions Zhongze Liu
2018-02-06 13:28 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebd7c9f4-4a71-365e-cbb6-05c20b9042b7@arm.com \
--to=julien.grall@arm.com \
--cc=blackskygg@gmail.com \
--cc=ian.jackson@eu.citrix.com \
--cc=sstabellini@kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).