From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andre Przywara Subject: Re: [PATCH 2/2] gnttab: improve GNTTABOP_cache_flush locking Date: Fri, 1 Dec 2017 15:31:45 +0000 Message-ID: References: <5A20232B02000078001938F3@prv-mh.provo.novell.com> <5A20247B020000780019390F@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <5A20247B020000780019390F@prv-mh.provo.novell.com> Content-Language: en-GB List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Jan Beulich , xen-devel@lists.xen.org Cc: Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Julien Grall List-Id: xen-devel@lists.xenproject.org SGksCgpPbiAzMC8xMS8xNyAxNDozMiwgSmFuIEJldWxpY2ggd3JvdGU6Cj4gRHJvcHBpbmcgdGhl IGxvY2sgYmVmb3JlIHJldHVybmluZyBmcm9tIGdyYW50X21hcF9leGlzdHMoKSBtZWFucyBoYW5k aW5nCj4gcG9zc2libHkgc3RhbGUgaW5mb3JtYXRpb24gYmFjayB0byB0aGUgY2FsbGVyLiBSZXR1 cm4gYmFjayB0aGUgcG9pbnRlcgo+IHRvIHRoZSBhY3RpdmUgZW50cnkgaW5zdGVhZCwgZm9yIHRo ZSBjYWxsZXIgdG8gcmVsZWFzZSB0aGUgbG9jayBvbmNlCj4gZG9uZS4KCkkgZG9uJ3Qga25vdyBl bm91Z2ggYWJvdXQgZ3JhbnQgdGFibGVzIHRvIHJlYXNvbiBhYm91dCB0aGUgZGVlcGVyCm1lYW5p bmcgb2YgdGhpcyBwYXRjaCwgYnV0IGF0IGxlYXN0IEkgY2FuIGNvbmZpcm0gdGhhdCB0aGUgYW1l bmRlZApsb2NraW5nIHNjaGVtZSBzZWVtcyB0byBiZSBjb3JyZWN0IChub3cpLgpJIGp1c3Qgd29u ZGVyIGlmIGl0J3Mgd29ydGh3aGlsZSB0byBhZGQgYSBjb21tZW50IHRoYXQgdGhlIGZ1bmN0aW9u CnRha2VzIGEgbG9jaywgYnV0IGxlYXZlcyBpdCB1cCB0byB0aGUgY2FsbGVyIHRvIGRyb3AgaXQu IFNpbmNlIHRoZXJlIGlzCm9ubHkgb25lIGNhbGxlciwgdGhpcyBtaWdodCBiZSBvdmVya2lsbCwg dGhvdWdoLgoKPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+ CgpSZXZpZXdlZC1ieTogQW5kcmUgUHJ6eXdhcmEgPGFuZHJlLnByenl3YXJhQGxpbmFyby5vcmc+ CgpDaGVlcnMsCkFuZHJlLgoKPiAKPiAtLS0gYS94ZW4vY29tbW9uL2dyYW50X3RhYmxlLmMKPiAr KysgYi94ZW4vY29tbW9uL2dyYW50X3RhYmxlLmMKPiBAQCAtNzg2LDEwICs3ODYsMTAgQEAgc3Rh dGljIGludCBfc2V0X3N0YXR1cyh1bnNpZ25lZCBndF92ZXJzaQo+ICAgICAgICAgIHJldHVybiBf c2V0X3N0YXR1c192Mihkb21pZCwgcmVhZG9ubHksIG1hcGZsYWcsIHNoYWgsIGFjdCwgc3RhdHVz KTsKPiAgfQo+ICAKPiAtc3RhdGljIGludCBncmFudF9tYXBfZXhpc3RzKGNvbnN0IHN0cnVjdCBk b21haW4gKmxkLAo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGdyYW50X3Rh YmxlICpyZ3QsCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBsb25nIG1m biwKPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdyYW50X3JlZl90ICpjdXJfcmVmKQo+ ICtzdGF0aWMgc3RydWN0IGFjdGl2ZV9ncmFudF9lbnRyeSAqZ3JhbnRfbWFwX2V4aXN0cyhjb25z dCBzdHJ1Y3QgZG9tYWluICpsZCwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgc3RydWN0IGdyYW50X3RhYmxlICpyZ3QsCj4gKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcgbWZu LAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBn cmFudF9yZWZfdCAqY3VyX3JlZikKPiAgewo+ICAgICAgZ3JhbnRfcmVmX3QgcmVmLCBtYXhfaXRl cjsKPiAgCj4gQEAgLTgwNSwyOCArODA1LDIwIEBAIHN0YXRpYyBpbnQgZ3JhbnRfbWFwX2V4aXN0 cyhjb25zdCBzdHJ1Y3QKPiAgICAgICAgICAgICAgICAgICAgIG5yX2dyYW50X2VudHJpZXMocmd0 KSk7Cj4gICAgICBmb3IgKCByZWYgPSAqY3VyX3JlZjsgcmVmIDwgbWF4X2l0ZXI7IHJlZisrICkK PiAgICAgIHsKPiAtICAgICAgICBzdHJ1Y3QgYWN0aXZlX2dyYW50X2VudHJ5ICphY3Q7Cj4gLSAg ICAgICAgYm9vbF90IGV4aXN0czsKPiAtCj4gLSAgICAgICAgYWN0ID0gYWN0aXZlX2VudHJ5X2Fj cXVpcmUocmd0LCByZWYpOwo+IC0KPiAtICAgICAgICBleGlzdHMgPSBhY3QtPnBpbgo+IC0gICAg ICAgICAgICAmJiBhY3QtPmRvbWlkID09IGxkLT5kb21haW5faWQKPiAtICAgICAgICAgICAgJiYg YWN0LT5mcmFtZSA9PSBtZm47Cj4gKyAgICAgICAgc3RydWN0IGFjdGl2ZV9ncmFudF9lbnRyeSAq YWN0ID0gYWN0aXZlX2VudHJ5X2FjcXVpcmUocmd0LCByZWYpOwo+ICAKPiArICAgICAgICBpZiAo IGFjdC0+cGluICYmIGFjdC0+ZG9taWQgPT0gbGQtPmRvbWFpbl9pZCAmJiBhY3QtPmZyYW1lID09 IG1mbiApCj4gKyAgICAgICAgICAgIHJldHVybiBhY3Q7Cj4gICAgICAgICAgYWN0aXZlX2VudHJ5 X3JlbGVhc2UoYWN0KTsKPiAtCj4gLSAgICAgICAgaWYgKCBleGlzdHMgKQo+IC0gICAgICAgICAg ICByZXR1cm4gMDsKPiAgICAgIH0KPiAgCj4gICAgICBpZiAoIHJlZiA8IG5yX2dyYW50X2VudHJp ZXMocmd0KSApCj4gICAgICB7Cj4gICAgICAgICAgKmN1cl9yZWYgPSByZWY7Cj4gLSAgICAgICAg cmV0dXJuIDE7Cj4gKyAgICAgICAgcmV0dXJuIE5VTEw7Cj4gICAgICB9Cj4gIAo+IC0gICAgcmV0 dXJuIC1FSU5WQUw7Cj4gKyAgICByZXR1cm4gRVJSX1BUUigtRUlOVkFMKTsKPiAgfQo+ICAKPiAg I2RlZmluZSBNQVBLSU5EX1JFQUQgMQo+IEBAIC0zMjEzLDYgKzMyMDUsNyBAQCBzdGF0aWMgaW50 IGNhY2hlX2ZsdXNoKGNvbnN0IGdudHRhYl9jYWNoCj4gICAgICBzdHJ1Y3QgZG9tYWluICpkLCAq b3duZXI7Cj4gICAgICBzdHJ1Y3QgcGFnZV9pbmZvICpwYWdlOwo+ICAgICAgdW5zaWduZWQgbG9u ZyBtZm47Cj4gKyAgICBzdHJ1Y3QgYWN0aXZlX2dyYW50X2VudHJ5ICphY3QgPSBOVUxMOwo+ICAg ICAgdm9pZCAqdjsKPiAgICAgIGludCByZXQ7Cj4gIAo+IEBAIC0zMjUwLDEzICszMjQzLDEzIEBA IHN0YXRpYyBpbnQgY2FjaGVfZmx1c2goY29uc3QgZ250dGFiX2NhY2gKPiAgICAgIHsKPiAgICAg ICAgICBncmFudF9yZWFkX2xvY2sob3duZXItPmdyYW50X3RhYmxlKTsKPiAgCj4gLSAgICAgICAg cmV0ID0gZ3JhbnRfbWFwX2V4aXN0cyhkLCBvd25lci0+Z3JhbnRfdGFibGUsIG1mbiwgY3VyX3Jl Zik7Cj4gLSAgICAgICAgaWYgKCByZXQgIT0gMCApCj4gKyAgICAgICAgYWN0ID0gZ3JhbnRfbWFw X2V4aXN0cyhkLCBvd25lci0+Z3JhbnRfdGFibGUsIG1mbiwgY3VyX3JlZik7Cj4gKyAgICAgICAg aWYgKCBJU19FUlJfT1JfTlVMTChhY3QpICkKPiAgICAgICAgICB7Cj4gICAgICAgICAgICAgIGdy YW50X3JlYWRfdW5sb2NrKG93bmVyLT5ncmFudF90YWJsZSk7Cj4gICAgICAgICAgICAgIHJjdV91 bmxvY2tfZG9tYWluKGQpOwo+ICAgICAgICAgICAgICBwdXRfcGFnZShwYWdlKTsKPiAtICAgICAg ICAgICAgcmV0dXJuIHJldDsKPiArICAgICAgICAgICAgcmV0dXJuIGFjdCA/IFBUUl9FUlIoYWN0 KSA6IDE7Cj4gICAgICAgICAgfQo+ICAgICAgfQo+ICAKPiBAQCAtMzI3Myw3ICszMjY2LDExIEBA IHN0YXRpYyBpbnQgY2FjaGVfZmx1c2goY29uc3QgZ250dGFiX2NhY2gKPiAgICAgICAgICByZXQg PSAwOwo+ICAKPiAgICAgIGlmICggZCAhPSBvd25lciApCj4gKyAgICB7Cj4gKyAgICAgICAgYWN0 aXZlX2VudHJ5X3JlbGVhc2UoYWN0KTsKPiAgICAgICAgICBncmFudF9yZWFkX3VubG9jayhvd25l ci0+Z3JhbnRfdGFibGUpOwo+ICsgICAgfQo+ICsKPiAgICAgIHVubWFwX2RvbWFpbl9wYWdlKHYp Owo+ICAgICAgcHV0X3BhZ2UocGFnZSk7Cj4gIAoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlz dHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xp c3RpbmZvL3hlbi1kZXZlbA==