From: Julien Grall <julien.grall@arm.com>
To: Volodymyr Babchuk <volodymyr_babchuk@epam.com>, xen-devel@lists.xen.org
Cc: Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH 3/4] arm: traps: handle unknown exceptions in check_conditional_instr()
Date: Fri, 28 Jul 2017 21:31:39 +0100 [thread overview]
Message-ID: <ed77bb5e-ed13-ab0f-2b38-1b0738d756bf@arm.com> (raw)
In-Reply-To: <1501271035-8592-4-git-send-email-volodymyr_babchuk@epam.com>
Hi,
On 07/28/2017 08:43 PM, Volodymyr Babchuk wrote:
> According to ARM architecture reference manual, exception with
version + paragraph
> unknown reason (HSR.EC == 0) have no valid bits in HSR
> (apart from HSR.EC), so we can't check if that was caused by
> conditional instruction. We need assume that it is uncoditional.
unconditional
>
> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
> ---
> xen/arch/arm/traps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
> index c07999b..eae2212 100644
> --- a/xen/arch/arm/traps.c
> +++ b/xen/arch/arm/traps.c
> @@ -1717,7 +1717,7 @@ static int check_conditional_instr(struct cpu_user_regs *regs,
> int cond;
>
> /* Unconditional Exception classes */
> - if ( hsr.ec >= 0x10 )
> + if ( hsr.ec == HSR_EC_UNKNOWN || hsr.ec >= 0x10 )
> return 1;
>
> /* Check for valid condition in hsr */
>
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-07-28 20:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 19:43 [PATCH 0/4] arm: allign check_conditional_instr() with ARM64 requirements Volodymyr Babchuk
2017-07-28 19:43 ` [PATCH 1/4] arm: processor: rename iss to res0 in hsr_cond union Volodymyr Babchuk
2017-07-28 20:29 ` Julien Grall
2017-07-28 19:43 ` [PATCH 2/4] arm: processor: add ccknownpass field into " Volodymyr Babchuk
2017-07-28 20:31 ` Julien Grall
2017-07-28 20:40 ` Julien Grall
2017-07-28 19:43 ` [PATCH 3/4] arm: traps: handle unknown exceptions in check_conditional_instr() Volodymyr Babchuk
2017-07-28 20:31 ` Julien Grall [this message]
2017-07-28 19:43 ` [PATCH 4/4] arm: traps: handle SMC32 " Volodymyr Babchuk
2017-07-28 20:37 ` Julien Grall
2017-08-08 20:42 ` Volodymyr Babchuk
2017-08-09 9:47 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed77bb5e-ed13-ab0f-2b38-1b0738d756bf@arm.com \
--to=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=volodymyr_babchuk@epam.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).