From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergej Proskurin Subject: Re: [PATCH v2] xen/arm: p2m: Prevent deadlock when using memaccess Date: Wed, 14 Mar 2018 10:21:35 +0100 Message-ID: References: <20180312153452.24314-1-julien.grall@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ew2bX-0006us-Fl for xen-devel@lists.xenproject.org; Wed, 14 Mar 2018 09:21:51 +0000 In-Reply-To: <20180312153452.24314-1-julien.grall@arm.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: julien.grall@arm.com, xen-devel@lists.xenproject.org Cc: andre.przywara@arm.com, sstabellini@kernel.org, tamas@tklengyel.com, rcojocaru@bitdefender.com List-Id: xen-devel@lists.xenproject.org SGkgSnVsaWVuLAoKCk9uIDAzLzEyLzIwMTggMDQ6MzQgUE0sIGp1bGllbi5ncmFsbEBhcm0uY29t IHdyb3RlOgo+IEZyb206IEp1bGllbiBHcmFsbCA8anVsaWVuLmdyYWxsQGFybS5jb20+Cj4KPiBD b21taXQgN2Q2MjNiMzU4YTQgImFybS9tZW1fYWNjZXNzOiBBZGQgbG9uZy1kZXNjcmlwdG9yIGJh c2VkIGdwdCIKPiBhc3N1bWVkIHRoZSByZWFkLXdyaXRlIGxvY2sgY2FuIGJlIHRha2VuIHJlY3Vy c2l2ZWx5LiBIb3dldmVyLCB0aGlzCj4gYXNzdW1wdGlvbiBpcyB3cm9uZyBhbmQgd2lsbCBsZWFk IHRvIGRlYWRsb2NrIHdoZW4gdGhlIGxvY2sgaXMKPiBjb250ZW5kZWQuCj4KPiBUaGUgcmVhZCBs b2NrIGlzIHRha2VuIHJlY3Vyc2l2ZWx5IGluIHRoZSBmb2xsb3dpbmcgY2FzZToKPiAgICAgMSkg Z2V0X3BhZ2VfZnJvbV9ndmEKPiAgICAgICAgID0+IFRha2UgdGhlIHJlYWQgbG9jayAoZmlyc3Qg cmVhZCBsb2NrKQo+ICAgICAgICAgPT4gQ2FsbCBwMm1fbWVtX2FjY2Vzc19jaGVja19hbmRfZ2V0 X3BhZ2Ugb24gZmFpbHVyZSB3aGVuCj4gICAgICAgICBtZW1hY2Nlc3MgaXMgZW5hYmxlZAo+ICAg ICAyKSBwMm1fbWVtX2FjY2Vzc19jaGVja19hbmRfZ2V0X3BhZ2UKPiAgICAgICAgID0+IElmIGhh cmR3YXJlIHRyYW5zbGF0aW9uIGZhaWxlZCBmYWxsYmFjayB0byBzb2Z0d2FyZSBsb29rdXAKPiAg ICAgICAgID0+IENhbGwgZ3Vlc3Rfd2Fsa190YWJsZXMKPiAgICAgMykgZ3Vlc3Rfd2Fsa190YWJs ZXMKPiAgICAgICAgID0+IFdpbGwgdXNlIGFjY2Vzc19ndWVzdF9tZW1vcnlfaXBhIHRvIGFjY2Vz cyBzdGFnZS0xIHBhZ2UtdGFibGUKPiAgICAgNCkgYWNjZXNzX2d1ZXN0X21lbW9yeV9pcGEKPiAg ICAgICAgID0+IEJlY2F1c2UgQXJtIGRvZXMgbm90IGhhdmUgaGFyZHdhcmUgaW5zdHJ1Y3Rpb24g dG8gb25seSBkbwo+ICAgICAgICAgc3RhZ2UtMiBwYWdlLXRhYmxlLCB0aGlzIGlzIGRvbmUgaW4g c29mdHdhcmUuCj4gICAgICAgICA9PiBUYWtlIHRoZSByZWFkIGxvY2sgKHNlY29uZCByZWFkIGxv Y2spCj4KPiBUbyBhdm9pZCB0aGUgbmVzdGVkIGxvY2ssIHJld29yayB0aGUgbG9ja2luZyBpbiBn ZXRfcGFnZV9mcm9tX2d2YSBhbmQKPiBwMm1fbWVtX2FjY2Vzc19jaGVja19hbmRfZ2V0X3BhZ2Uu IFRoZSBsYXR0ZXIgd2lsbCBub3cgYmUgY2FsbGVkIHdpdGhvdXQKPiB0aGUgcDJtIGxvY2suIFRo ZSBuZXcgbG9ja2luZyBpbiBwMm1fbWVtX2FjY2Nlc19jaGVja19hbmRfZ2V0X3BhZ2Ugd2lsbAo+ IG5vdCBjb3ZlciB0aGUgdHJhbnNsYXRpb24gb2YgdGhlIFZBIHRvIGFuIElQQS4KPgo+IFRoaXMg aXMgZmluZSBiZWNhdXNlIHdlIGNhbid0IHByb21pc2UgdGhhdCB0aGUgc3RhZ2UtMSBwYWdlLXRh YmxlIGhhdmUKPiBjaGFuZ2VkIGJlaGluZCBvdXIgYmFjayAodGhleSBhcmUgdW5kZXIgZ3Vlc3Qg Y29udHJvbCkuIE1vZGlmaWNhdGlvbiBpbgo+IHRoZSBzdGFnZS0yIHBhZ2UtdGFibGUgY2FuIG5v dyBoYXBwZW4sIGJ1dCBJIGNhbid0IGlzc3VlIGFueSBwb3RlbnRpYWwKPiBpc3N1ZSBoZXJlIGV4 Y2VwdCB3aXRoIHRoZSBicmVhay1iZWZvcmUtbWFrZSBzZXF1ZW5jZSB1c2VkIHdoZW4gdXBkYXRp bmcKPiBwYWdlLXRhYmxlLiBndmFfdG9faXBhIG1heSBmYWlsIGlmIHRoZSBzZXF1ZW5jZSBpcyBl eGVjdXRlZCBhdCB0aGUgc2FtZQo+IG9uIGFub3RoZXIgQ1BVLiBJbiB0aGF0IGNhc2Ugd2Ugd291 bGQgZmFsbGJhY2sgaW4gdGhlIHNvZnR3YXJlIGxvb2t1cAo+IHBhdGguCj4KPiBTaWduZWQtb2Zm LWJ5OiBKdWxpZW4gR3JhbGwgPGp1bGllbi5ncmFsbEBhcm0uY29tPgoKClRoYW5rcyBmb3IgZml4 aW5nIHRoZSBuZXN0ZWQgbG9ja2luZyBpc3N1ZSA6KQoKUmV2aWV3ZWQtYnk6IFNlcmdlaiBQcm9z a3VyaW4gPHByb3NrdXJpbkBzZWMuaW4udHVtLmRlPgoKPgo+IC0tLQo+ICAgICBUaGlzIHBhdGNo IHNob3VsZCBiZSBiYWNrcG9ydGVkIHRvIFhlbiA0LjEwLiBUaGVyZSBhcmUgb3RoZXIKPiAgICAg cG90ZW50aWFsIG9wdGltaXphdGlvbiB0aGF0IEkgYW0gd29ya2luZyBvbi4gQWx0aG91Z2gsIEkg ZG9uJ3QgdGhpbmsKPiAgICAgdGhleSBhcmUgYmFja3BvcnQgbWF0ZXJpYWwuCj4KPiAgICAgQ2hh bmdlcyBpbiB2MjoKPiAgICAgICAgIC0gVXBkYXRlIHRoZSBjb21taXQgbWVzc2FnZSB0byBleHBs YWluIHdoZXJlIHRoZSBsb2NrIGlzIHRha2VuCj4gICAgICAgICByZWN1cnNpdmVseS4KPiAtLS0K PiAgeGVuL2FyY2gvYXJtL21lbV9hY2Nlc3MuYyB8IDggKysrKysrLS0KPiAgeGVuL2FyY2gvYXJt L3AybS5jICAgICAgICB8IDQgKystLQo+ICB4ZW4vaW5jbHVkZS9hc20tYXJtL3AybS5oIHwgNCAt LS0tCj4gIDMgZmlsZXMgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQo+ Cj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9tZW1fYWNjZXNzLmMgYi94ZW4vYXJjaC9hcm0v bWVtX2FjY2Vzcy5jCj4gaW5kZXggMGYyY2JiODFkMy4uMTFjMmIwM2I3YiAxMDA2NDQKPiAtLS0g YS94ZW4vYXJjaC9hcm0vbWVtX2FjY2Vzcy5jCj4gKysrIGIveGVuL2FyY2gvYXJtL21lbV9hY2Nl c3MuYwo+IEBAIC0xMjYsNyArMTI2LDcgQEAgcDJtX21lbV9hY2Nlc3NfY2hlY2tfYW5kX2dldF9w YWdlKHZhZGRyX3QgZ3ZhLCB1bnNpZ25lZCBsb25nIGZsYWcsCj4gICAgICAgICAgICogaXMgbm90 IG1hcHBlZC4KPiAgICAgICAgICAgKi8KPiAgICAgICAgICBpZiAoIGd1ZXN0X3dhbGtfdGFibGVz KHYsIGd2YSwgJmlwYSwgJnBlcm1zKSA8IDAgKQo+IC0gICAgICAgICAgICBnb3RvIGVycjsKPiAr ICAgICAgICAgICAgcmV0dXJuIE5VTEw7Cj4gIAo+ICAgICAgICAgIC8qCj4gICAgICAgICAgICog Q2hlY2sgcGVybWlzc2lvbnMgdGhhdCBhcmUgYXNzdW1lZCBieSB0aGUgY2FsbGVyLiBGb3IgaW5z dGFuY2UgaW4KPiBAQCAtMTM5LDExICsxMzksMTMgQEAgcDJtX21lbV9hY2Nlc3NfY2hlY2tfYW5k X2dldF9wYWdlKHZhZGRyX3QgZ3ZhLCB1bnNpZ25lZCBsb25nIGZsYWcsCj4gICAgICAgICAgICog dGVzdCBmb3IgZXhlY3V0ZSBwZXJtaXNzaW9ucyB0aGlzIGNoZWNrIGNhbiBiZSBsZWZ0IG91dC4K PiAgICAgICAgICAgKi8KPiAgICAgICAgICBpZiAoIChmbGFnICYgR1YyTV9XUklURSkgJiYgIShw ZXJtcyAmIEdWMk1fV1JJVEUpICkKPiAtICAgICAgICAgICAgZ290byBlcnI7Cj4gKyAgICAgICAg ICAgIHJldHVybiBOVUxMOwo+ICAgICAgfQo+ICAKPiAgICAgIGdmbiA9IGdhZGRyX3RvX2dmbihp cGEpOwo+ICAKPiArICAgIHAybV9yZWFkX2xvY2socDJtKTsKPiArCj4gICAgICAvKgo+ICAgICAg ICogV2UgZG8gdGhpcyBmaXJzdCBhcyB0aGlzIGlzIGZhc3RlciBpbiB0aGUgZGVmYXVsdCBjYXNl IHdoZW4gbm8KPiAgICAgICAqIHBlcm1pc3Npb24gaXMgc2V0IG9uIHRoZSBwYWdlLgo+IEBAIC0y MTYsNiArMjE4LDggQEAgcDJtX21lbV9hY2Nlc3NfY2hlY2tfYW5kX2dldF9wYWdlKHZhZGRyX3Qg Z3ZhLCB1bnNpZ25lZCBsb25nIGZsYWcsCj4gICAgICAgICAgcGFnZSA9IE5VTEw7Cj4gIAo+ICBl cnI6Cj4gKyAgICBwMm1fcmVhZF91bmxvY2socDJtKTsKPiArCj4gICAgICByZXR1cm4gcGFnZTsK PiAgfQo+ICAKPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL3AybS5jIGIveGVuL2FyY2gvYXJt L3AybS5jCj4gaW5kZXggNjVlOGI5YzZlYS4uNWRlODJhYWZlMSAxMDA2NDQKPiAtLS0gYS94ZW4v YXJjaC9hcm0vcDJtLmMKPiArKysgYi94ZW4vYXJjaC9hcm0vcDJtLmMKPiBAQCAtMTQ0OSwxMSAr MTQ0OSwxMSBAQCBzdHJ1Y3QgcGFnZV9pbmZvICpnZXRfcGFnZV9mcm9tX2d2YShzdHJ1Y3QgdmNw dSAqdiwgdmFkZHJfdCB2YSwKPiAgICAgIH0KPiAgCj4gIGVycjoKPiArICAgIHAybV9yZWFkX3Vu bG9jayhwMm0pOwo+ICsKPiAgICAgIGlmICggIXBhZ2UgJiYgcDJtLT5tZW1fYWNjZXNzX2VuYWJs ZWQgKQo+ICAgICAgICAgIHBhZ2UgPSBwMm1fbWVtX2FjY2Vzc19jaGVja19hbmRfZ2V0X3BhZ2Uo dmEsIGZsYWdzLCB2KTsKPiAgCj4gLSAgICBwMm1fcmVhZF91bmxvY2socDJtKTsKPiAtCj4gICAg ICByZXR1cm4gcGFnZTsKPiAgfQo+ICAKPiBkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLWFy bS9wMm0uaCBiL3hlbi9pbmNsdWRlL2FzbS1hcm0vcDJtLmgKPiBpbmRleCBhMGFiYzg0ZWQ4Li40 NWVmMmNkNThiIDEwMDY0NAo+IC0tLSBhL3hlbi9pbmNsdWRlL2FzbS1hcm0vcDJtLmgKPiArKysg Yi94ZW4vaW5jbHVkZS9hc20tYXJtL3AybS5oCj4gQEAgLTIzLDEwICsyMyw2IEBAIGV4dGVybiB2 b2lkIG1lbW9yeV90eXBlX2NoYW5nZWQoc3RydWN0IGRvbWFpbiAqKTsKPiAgc3RydWN0IHAybV9k b21haW4gewo+ICAgICAgLyoKPiAgICAgICAqIExvY2sgdGhhdCBwcm90ZWN0cyB1cGRhdGVzIHRv IHRoZSBwMm0uCj4gLSAgICAgKgo+IC0gICAgICogUGxlYXNlIG5vdGUgdGhhdCB3ZSB1c2UgdGhp cyBsb2NrIGluIGEgbmVzdGVkIHdheSBieSBjYWxsaW5nCj4gLSAgICAgKiBhY2Nlc3NfZ3Vlc3Rf bWVtb3J5X2J5X2lwYSBpbiBndWVzdF93YWxrXyhzZHxsZCkuIFRoaXMgbXVzdCBiZQo+IC0gICAg ICogY29uc2lkZXJlZCBpbiB0aGUgZnV0dXJlIGltcGxlbWVudGF0aW9uLgo+ICAgICAgICovCj4g ICAgICByd2xvY2tfdCBsb2NrOwo+ICAKCi0tIApTZXJnZWogUHJvc2t1cmluLCBNLlNjLgpXaXNz ZW5zY2hhZnRsaWNoZXIgTWl0YXJiZWl0ZXIKClRlY2huaXNjaGUgVW5pdmVyc2l0w6R0IE3DvG5j aGVuCkZha3VsdMOkdCBmw7xyIEluZm9ybWF0aWsKTGVocnN0dWhsIGbDvHIgU2ljaGVyaGVpdCBp biBkZXIgSW5mb3JtYXRpawoKQm9sdHptYW5uc3RyYcOfZSAzCjg1NzQ4IEdhcmNoaW5nIChiZWkg TcO8bmNoZW4pCgpUZWwuICs0OSAoMCk4OSAyODktMTg1OTIKRmF4ICs0OSAoMCk4OSAyODktMTg1 NzkKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4t ZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczov L2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs