From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: Re: [PATCH 8/8] xen: Swich parameter in get_page_from_gfn to use typesafe gfn Date: Wed, 7 Nov 2018 08:57:46 +0000 Message-ID: References: <20181106191454.22143-1-julien.grall@arm.com> <20181106191454.22143-9-julien.grall@arm.com> <479bb855-0bb7-dd30-a7a4-692b189cc7c5@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gKJen-0001C0-QC for xen-devel@lists.xenproject.org; Wed, 07 Nov 2018 08:57:49 +0000 In-Reply-To: <479bb855-0bb7-dd30-a7a4-692b189cc7c5@citrix.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Andrew Cooper , Julien Grall , "sstabellini@kernel.org" , "xen-devel@lists.xenproject.org" Cc: Kevin Tian , Wei Liu , Suravee Suthikulpanit , Konrad Rzeszutek Wilk , Jun Nakajima , "Tim (Xen.org)" , George Dunlap , Julien Grall , Jan Beulich , Ian Jackson , Boris Ostrovsky , Brian Woods List-Id: xen-devel@lists.xenproject.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBBbmRyZXcgQ29vcGVyDQo+IFNl bnQ6IDA2IE5vdmVtYmVyIDIwMTggMjA6MTINCj4gVG86IEp1bGllbiBHcmFsbCA8anVsaWVuLmdy YWxsQGFybS5jb20+OyBzc3RhYmVsbGluaUBrZXJuZWwub3JnOyB4ZW4tDQo+IGRldmVsQGxpc3Rz LnhlbnByb2plY3Qub3JnDQo+IENjOiBHZW9yZ2UgRHVubGFwIDxHZW9yZ2UuRHVubGFwQGNpdHJp eC5jb20+OyBJYW4gSmFja3Nvbg0KPiA8SWFuLkphY2tzb25AY2l0cml4LmNvbT47IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT47IEtvbnJhZA0KPiBSemVzenV0ZWsgV2lsayA8a29ucmFk LndpbGtAb3JhY2xlLmNvbT47IFRpbSAoWGVuLm9yZykgPHRpbUB4ZW4ub3JnPjsgV2VpDQo+IExp dSA8d2VpLmxpdTJAY2l0cml4LmNvbT47IEJvcmlzIE9zdHJvdnNreSA8Ym9yaXMub3N0cm92c2t5 QG9yYWNsZS5jb20+Ow0KPiBTdXJhdmVlIFN1dGhpa3VscGFuaXQgPHN1cmF2ZWUuc3V0aGlrdWxw YW5pdEBhbWQuY29tPjsgQnJpYW4gV29vZHMNCj4gPGJyaWFuLndvb2RzQGFtZC5jb20+OyBQYXVs IER1cnJhbnQgPFBhdWwuRHVycmFudEBjaXRyaXguY29tPjsgSnVuDQo+IE5ha2FqaW1hIDxqdW4u bmFrYWppbWFAaW50ZWwuY29tPjsgS2V2aW4gVGlhbiA8a2V2aW4udGlhbkBpbnRlbC5jb20+Ow0K PiBKdWxpZW4gR3JhbGwgPGp1bGllLmdyYWxsQGFybS5jb20+DQo+IFN1YmplY3Q6IFJlOiBbUEFU Q0ggOC84XSB4ZW46IFN3aWNoIHBhcmFtZXRlciBpbiBnZXRfcGFnZV9mcm9tX2dmbiB0byB1c2UN Cj4gdHlwZXNhZmUgZ2ZuDQo+IA0KPiBIaSAtIGp1c3Qgc29tZSBjb3NtZXRpYyBzdWdnZXN0aW9u cy4NCj4gDQo+IFN1YmplY3Qgcy9Td2ljaC9Td2l0Y2gvDQo+IA0KPiA+IGRpZmYgLS1naXQgYS94 ZW4vYXJjaC94ODYvcHYvZW11bC1wcml2LW9wLmMgYi94ZW4vYXJjaC94ODYvcHYvZW11bC1wcml2 LQ0KPiBvcC5jDQo+ID4gaW5kZXggZjczZWE0YTE2My4uYTUyOWViY2MzZiAxMDA2NDQNCj4gPiAt LS0gYS94ZW4vYXJjaC94ODYvcHYvZW11bC1wcml2LW9wLmMNCj4gPiArKysgYi94ZW4vYXJjaC94 ODYvcHYvZW11bC1wcml2LW9wLmMNCj4gPiBAQCAtNzYwLDEyICs3NjAsMTIgQEAgc3RhdGljIGlu dCB3cml0ZV9jcih1bnNpZ25lZCBpbnQgcmVnLCB1bnNpZ25lZA0KPiBsb25nIHZhbCwNCj4gPiAg ICAgIGNhc2UgMzogLyogV3JpdGUgQ1IzICovDQo+ID4gICAgICB7DQo+ID4gICAgICAgICAgc3Ry dWN0IGRvbWFpbiAqY3VycmQgPSBjdXJyLT5kb21haW47DQo+ID4gLSAgICAgICAgdW5zaWduZWQg bG9uZyBnZm47DQo+ID4gKyAgICAgICAgZ2ZuX3QgZ2ZuOw0KPiA+ICAgICAgICAgIHN0cnVjdCBw YWdlX2luZm8gKnBhZ2U7DQo+ID4gICAgICAgICAgaW50IHJjOw0KPiA+DQo+ID4gLSAgICAgICAg Z2ZuID0gIWlzX3B2XzMyYml0X2RvbWFpbihjdXJyZCkNCj4gPiAtICAgICAgICAgICAgICA/IHhl bl9jcjNfdG9fcGZuKHZhbCkgOiBjb21wYXRfY3IzX3RvX3Bmbih2YWwpOw0KPiA+ICsgICAgICAg IGdmbiA9IF9nZm4oIWlzX3B2XzMyYml0X2RvbWFpbihjdXJyZCkNCj4gPiArICAgICAgICAgICAg ICA/IHhlbl9jcjNfdG9fcGZuKHZhbCkgOiBjb21wYXRfY3IzX3RvX3Bmbih2YWwpKTsNCj4gDQo+ IFBsZWFzZSByZS1pbmRlbnQuDQo+IA0KPiA+ICAgICAgICAgIHBhZ2UgPSBnZXRfcGFnZV9mcm9t X2dmbihjdXJyZCwgZ2ZuLCBOVUxMLCBQMk1fQUxMT0MpOw0KPiA+ICAgICAgICAgIGlmICggIXBh Z2UgKQ0KPiA+ICAgICAgICAgICAgICBicmVhazsNCj4gPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gv eDg2L3RyYXBzLmMgYi94ZW4vYXJjaC94ODYvdHJhcHMuYw0KPiA+IGluZGV4IDk0NzFkODkwMjIu LmQ5NjdlNDk0MzIgMTAwNjQ0DQo+ID4gLS0tIGEveGVuL2FyY2gveDg2L3RyYXBzLmMNCj4gPiAr KysgYi94ZW4vYXJjaC94ODYvdHJhcHMuYw0KPiA+IEBAIC04MTcsMTMgKzgxNywxNCBAQCBpbnQg Z3Vlc3Rfd3Jtc3JfeGVuKHN0cnVjdCB2Y3B1ICp2LCB1aW50MzJfdCBpZHgsDQo+IHVpbnQ2NF90 IHZhbCkNCj4gPg0KPiA+ICAgICAgICAgICAgICBpZiAoIHAybV9pc19wYWdpbmcodCkgKQ0KPiA+ ICAgICAgICAgICAgICB7DQo+ID4gLSAgICAgICAgICAgICAgICBwMm1fbWVtX3BhZ2luZ19wb3B1 bGF0ZShkLCBnbWZuKTsNCj4gPiArICAgICAgICAgICAgICAgIHAybV9tZW1fcGFnaW5nX3BvcHVs YXRlKGQsIGdmbl94KGdmbikpOw0KPiA+ICAgICAgICAgICAgICAgICAgcmV0dXJuIFg4NkVNVUxf UkVUUlk7DQo+ID4gICAgICAgICAgICAgIH0NCj4gPg0KPiA+ICAgICAgICAgICAgICBnZHByaW50 ayhYRU5MT0dfV0FSTklORywNCj4gPiAtICAgICAgICAgICAgICAgICAgICAgIkJhZCBHTUZOICVs eCAoTUZOICUjIlBSSV9tZm4iKSB0byBNU1IgJTA4eFxuIiwNCj4gPiAtICAgICAgICAgICAgICAg ICAgICAgZ21mbiwgbWZuX3gocGFnZSA/IHBhZ2VfdG9fbWZuKHBhZ2UpIDoNCj4gSU5WQUxJRF9N Rk4pLCBiYXNlKTsNCj4gPiArICAgICAgICAgICAgICAgICAgICAgIkJhZCBHTUZOICUjIlBSSV9n Zm4iIChNRk4gJSMiUFJJX21mbiIpIHRvIE1TUg0KPiAlMDh4XG4iLA0KPiANCj4gR01GTiA9PiBH Rk4uDQo+IA0KPiA+ICsgICAgICAgICAgICAgICAgICAgICBnZm5feChnZm4pLCBtZm5feChwYWdl ID8gcGFnZV90b19tZm4ocGFnZSkgOg0KPiBJTlZBTElEX01GTiksDQo+ID4gKyAgICAgICAgICAg ICAgICAgICAgIGJhc2UpOw0KPiA+ICAgICAgICAgICAgICByZXR1cm4gWDg2RU1VTF9FWENFUFRJ T047DQo+ID4gICAgICAgICAgfQ0KPiA+DQo+ID4gZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRlL2Fz bS14ODYvcDJtLmggYi94ZW4vaW5jbHVkZS9hc20teDg2L3AybS5oDQo+ID4gaW5kZXggZDA4YzU5 NTg4Ny4uZGIxZWMzNzYxMCAxMDA2NDQNCj4gPiAtLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L3Ay bS5oDQo+ID4gKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9wMm0uaA0KPiA+IEBAIC00ODksMTgg KzQ4OSwyMSBAQCBzdHJ1Y3QgcGFnZV9pbmZvICpwMm1fZ2V0X3BhZ2VfZnJvbV9nZm4oc3RydWN0 DQo+IHAybV9kb21haW4gKnAybSwgZ2ZuX3QgZ2ZuLA0KPiA+ICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgcDJtX3F1ZXJ5X3QgcSk7DQo+ID4NCj4gPiAgc3RhdGljIGlu bGluZSBzdHJ1Y3QgcGFnZV9pbmZvICpnZXRfcGFnZV9mcm9tX2dmbigNCj4gPiAtICAgIHN0cnVj dCBkb21haW4gKmQsIHVuc2lnbmVkIGxvbmcgZ2ZuLCBwMm1fdHlwZV90ICp0LCBwMm1fcXVlcnlf dCBxKQ0KPiA+ICsgICAgc3RydWN0IGRvbWFpbiAqZCwgZ2ZuX3QgZ2ZuLCBwMm1fdHlwZV90ICp0 LCBwMm1fcXVlcnlfdCBxKQ0KPiA+ICB7DQo+ID4gICAgICBzdHJ1Y3QgcGFnZV9pbmZvICpwYWdl Ow0KPiA+ICsgICAgbWZuX3QgbWZuOw0KPiA+DQo+ID4gICAgICBpZiAoIHBhZ2luZ19tb2RlX3Ry YW5zbGF0ZShkKSApDQo+ID4gLSAgICAgICAgcmV0dXJuIHAybV9nZXRfcGFnZV9mcm9tX2dmbihw Mm1fZ2V0X2hvc3RwMm0oZCksIF9nZm4oZ2ZuKSwgdCwNCj4gTlVMTCwgcSk7DQo+ID4gKyAgICAg ICAgcmV0dXJuIHAybV9nZXRfcGFnZV9mcm9tX2dmbihwMm1fZ2V0X2hvc3RwMm0oZCksIGdmbiwg dCwgTlVMTCwNCj4gcSk7DQo+ID4NCj4gPiAgICAgIC8qIE5vbi10cmFuc2xhdGVkIGd1ZXN0cyBz ZWUgMS0xIFJBTSAvIE1NSU8gbWFwcGluZ3MgZXZlcnl3aGVyZSAqLw0KPiA+ICAgICAgaWYgKCB0 ICkNCj4gPiAgICAgICAgICAqdCA9IGxpa2VseShkICE9IGRvbV9pbykgPyBwMm1fcmFtX3J3IDog cDJtX21taW9fZGlyZWN0Ow0KPiA+IC0gICAgcGFnZSA9IG1mbl90b19wYWdlKF9tZm4oZ2ZuKSk7 DQo+ID4gLSAgICByZXR1cm4gbWZuX3ZhbGlkKF9tZm4oZ2ZuKSkgJiYgZ2V0X3BhZ2UocGFnZSwg ZCkgPyBwYWdlIDogTlVMTDsNCj4gPiArDQo+ID4gKyAgICBtZm4gPSBfbWZuKGdmbl94KGdmbikp Ow0KPiA+ICsgICAgcGFnZSA9IG1mbl90b19wYWdlKG1mbik7DQo+ID4gKyAgICByZXR1cm4gbWZu X3ZhbGlkKG1mbikgJiYgZ2V0X3BhZ2UocGFnZSwgZCkgPyBwYWdlIDogTlVMTDsNCj4gDQo+IFRo aXMgbG9va3MgbGlrZSBpdCB3b3VsZCBiZSBjbGVhbmVyIGJ5IG5vdCBzcGxpdHRpbmcgbWZuIG91 dCBpbnRvIGENCj4gc2VwYXJhdGUgdmFyaWFibGUuDQo+IA0KPiBwYWdlID0gbWZuX3RvX3BhZ2Uo X21mbihnZm5feChnZm4pKSk7DQo+IA0KPiByZXR1cm4gbWZuX3ZhbGlkKG1mbikgJiYgZ2V0X3Bh Z2UocGFnZSwgZCkgPyBwYWdlIDogTlVMTDsNCg0KXl4gZXIuLi4gaG93J3MgdGhhdCBtZm5fdmFs aWQoKSBnb2luZyB0byB3b3JrPyBZb3UnZCBuZWVkIG1mbl92YWxpZChwYWdlX3RvX21mbihwYWhn ZSkpLCBvciBzb21lc3VjaC4NCg0KICBQYXVsDQoNCj4gDQo+IFRoZSBvbmx5IHJlYXNvbiB0aGlz IGxvb2tzIG9kZCBpcyBiZWNhdXNlIG9mIHRoZSBtZm4gPT4gZ2ZuIGVxdWFsaXR5LA0KPiBidXQg d2UgYXJlIGp1c3QgYmVzaWRlIGEgY29tbWVudCBleHBsYWluaW5nIHRoYXQgd2UgYXJlIG5vbi10 cmFuc2xhdGVkLg0KPiANCj4gfkFuZHJldw0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMu eGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3Rp bmZvL3hlbi1kZXZlbA==