From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: Re: [PATCH] amd-iommu: Fix Guest CR3 Table following c/s 3a7947b6901 Date: Thu, 4 Apr 2019 10:59:22 +0000 Message-ID: References: <1554314899-16357-1-git-send-email-andrew.cooper3@citrix.com> <6ec03dbc-3b75-8718-bdf7-b379cd84ee53@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <6ec03dbc-3b75-8718-bdf7-b379cd84ee53@citrix.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Andrew Cooper , Xen-devel Cc: Brian Woods , Wei Liu , Jan Beulich , Roger Pau Monne List-Id: xen-devel@lists.xenproject.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBBbmRyZXcgQ29vcGVyDQo+IFNl bnQ6IDA0IEFwcmlsIDIwMTkgMTE6NDYNCj4gVG86IFBhdWwgRHVycmFudCA8UGF1bC5EdXJyYW50 QGNpdHJpeC5jb20+OyBYZW4tZGV2ZWwgPHhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnPg0KPiBDYzog SmFuIEJldWxpY2ggPEpCZXVsaWNoQHN1c2UuY29tPjsgV2VpIExpdSA8d2VpLmxpdTJAY2l0cml4 LmNvbT47IFJvZ2VyIFBhdSBNb25uZQ0KPiA8cm9nZXIucGF1QGNpdHJpeC5jb20+OyBCcmlhbiBX b29kcyA8YnJpYW4ud29vZHNAYW1kLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSF0gYW1kLWlv bW11OiBGaXggR3Vlc3QgQ1IzIFRhYmxlIGZvbGxvd2luZyBjL3MgM2E3OTQ3YjY5MDENCj4gDQo+ IE9uIDA0LzA0LzIwMTkgMTE6MzksIFBhdWwgRHVycmFudCB3cm90ZToNCj4gPj4gLS0tLS1Pcmln aW5hbCBNZXNzYWdlLS0tLS0NCj4gPj4gRnJvbTogQW5kcmV3IENvb3BlciBbbWFpbHRvOmFuZHJl dy5jb29wZXIzQGNpdHJpeC5jb21dDQo+ID4+IFNlbnQ6IDAzIEFwcmlsIDIwMTkgMTk6MDgNCj4g Pj4gVG86IFhlbi1kZXZlbCA8eGVuLWRldmVsQGxpc3RzLnhlbi5vcmc+DQo+ID4+IENjOiBBbmRy ZXcgQ29vcGVyIDxBbmRyZXcuQ29vcGVyM0BjaXRyaXguY29tPjsgSmFuIEJldWxpY2ggPEpCZXVs aWNoQHN1c2UuY29tPjsgV2VpIExpdQ0KPiA+PiA8d2VpLmxpdTJAY2l0cml4LmNvbT47IFJvZ2Vy IFBhdSBNb25uZSA8cm9nZXIucGF1QGNpdHJpeC5jb20+OyBCcmlhbiBXb29kcyA8YnJpYW4ud29v ZHNAYW1kLmNvbT47DQo+IFBhdWwNCj4gPj4gRHVycmFudCA8UGF1bC5EdXJyYW50QGNpdHJpeC5j b20+DQo+ID4+IFN1YmplY3Q6IFtQQVRDSF0gYW1kLWlvbW11OiBGaXggR3Vlc3QgQ1IzIFRhYmxl IGZvbGxvd2luZyBjL3MgM2E3OTQ3YjY5MDENCj4gPj4NCj4gPj4gImFtZC1pb21tdTogdXNlIGEg Yml0ZmllbGQgZm9yIERURSIgcmVuYW1lZCBpb21tdV9kdGVfc2V0X2d1ZXN0X2NyMygpJ3MgZ2Ny Mw0KPiA+PiBwYXJhbWV0ZXIgdG8gZ2NyM19tZm4gYnV0IGVuZGVkIHVwIHdpdGggYW4gb2ZmLWJ5 LVBBR0VfU0laRSBlcnJvciB3aGVuDQo+ID4+IGV4dHJhY3RpbmcgYml0cyBmcm9tIHRoZSBhZGRy ZXNzLg0KPiA+Pg0KPiA+PiBGaXJzdCBvZiBhbGwsIGdldF9ndWVzdF9jcjNfZnJvbV9kdGUoKSBh bmQgaW9tbXVfZHRlX3NldF9ndWVzdF9jcjMoKQ0KPiA+PiBhcmUgKGFsbW9zdCkgZ2V0dGVycyBh bmQgc2V0dGVycyBmb3IgdGhlIHNhbWUgZmllbGQsIHNvIHNob3VsZCBsaXZlIHRvZ2V0aGVyLg0K PiA+Pg0KPiA+PiBSZW5hbWUgdGhlbSB0byBkdGVfe2dldCxzZXR9X2djcjNfdGFibGUoKSB0byBz cGVjaWZpY2FsbHkgYXZvaWQgJ2d1ZXN0X2NyMycgaW4NCj4gPj4gdGhlIG5hbWUuICBUaGlzIGZp ZWxkIGFjdHVhbGx5IHBvaW50cyB0byBhIHRhYmxlIGluIG1lbW9yeSBjb250YWluaW5nIGFuIGFy cmF5DQo+ID4+IG9mIGd1ZXN0IENSMyB2YWx1ZXMuICBBcyB0aGVzZSBmdW5jdGlvbnMgYXJlIHVz ZWQgZm9yIGRpZmZlcmVudCBsb2dpY2FsDQo+ID4+IGluZGlyZWN0aW9ucywgdGhleSBzaG91bGRu J3QgdXNlIGdmbi9tZm4gdGVybWlub2xvZ3kgZm9yIHRoZWlyIHBhcmFtZXRlcnMuDQo+ID4+IFN3 aXRjaCB0aGVtIHRvIHVzZSBzdHJhaWdodCB1aW50NjRfdCBmdWxsIGFkZHJlc3Nlcy4NCj4gPj4N Cj4gPj4gRmluYWxseSwgY29ycmVjdCB0aGUgZHRlX3NldF9nY3IzX3RhYmxlKCkgdG8gdXNlIHRo ZSBwcm9wZXIgc2hpZnQuICBFeHByZXNzDQo+ID4+IHRoZSBzaGlmdHMgdmlzdWFsbHkgdXNpbmcg TUFTS19FWFRSKCkgYW5kIGxpdGVyYWwgbWFza3MsIHdoaWNoIElNTyBpcyB0aGUNCj4gPj4gY2xl YXJlc3Qgd2F5IHRvIGV4cHJlc3MgdGhlIGxvZ2ljLg0KPiA+Pg0KPiA+PiBTaWduZWQtb2ZmLWJ5 OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPiA+PiAtLS0NCj4g Pj4gQ0M6IEphbiBCZXVsaWNoIDxKQmV1bGljaEBzdXNlLmNvbT4NCj4gPj4gQ0M6IFdlaSBMaXUg PHdlaS5saXUyQGNpdHJpeC5jb20+DQo+ID4+IENDOiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5w YXVAY2l0cml4LmNvbT4NCj4gPj4gQ0M6IEJyaWFuIFdvb2RzIDxicmlhbi53b29kc0BhbWQuY29t Pg0KPiA+PiBDQzogUGF1bCBEdXJyYW50IDxwYXVsLmR1cnJhbnRAY2l0cml4LmNvbT4NCj4gPj4N Cj4gPj4gVGhpcyBjb2RlIGlzIHVucmVhY2hhYmxlLCBzbyBjb21wbGV0ZWx5IHVudGVzdGFibGUs IGJ1dCBJIHRoaW5rIHRoZSBlbmQgcmVzdWx0DQo+ID4+IGlzIGJldHRlciB0aGFuIGl0IHdhcyBw cmV2aW91c2x5Lg0KPiA+PiAtLS0NCj4gPj4gIHhlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9p b21tdV9ndWVzdC5jICAgICB8IDMyICsrKysrKysrKysrKysrKysrKysrKysrLS0tLQ0KPiA+PiAg eGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X21hcC5jICAgICAgIHwgMjEgLS0tLS0t LS0tLS0tLS0tLS0tDQo+ID4+ICB4ZW4vaW5jbHVkZS9hc20teDg2L2h2bS9zdm0vYW1kLWlvbW11 LXByb3RvLmggfCAgMiAtLQ0KPiA+PiAgMyBmaWxlcyBjaGFuZ2VkLCAyOCBpbnNlcnRpb25zKCsp LCAyNyBkZWxldGlvbnMoLSkNCj4gPj4NCj4gPj4gZGlmZiAtLWdpdCBhL3hlbi9kcml2ZXJzL3Bh c3N0aHJvdWdoL2FtZC9pb21tdV9ndWVzdC5jIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1k L2lvbW11X2d1ZXN0LmMNCj4gPj4gaW5kZXggMzI4ZTc1MC4uNDY5MWU4ZiAxMDA2NDQNCj4gPj4g LS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X2d1ZXN0LmMNCj4gPj4gKysr IGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X2d1ZXN0LmMNCj4gPj4gQEAgLTc2 LDEwICs3NiwzNCBAQCBzdGF0aWMgdm9pZCBndWVzdF9pb21tdV9kaXNhYmxlKHN0cnVjdCBndWVz dF9pb21tdSAqaW9tbXUpDQo+ID4+ICAgICAgaW9tbXUtPmVuYWJsZWQgPSAwOw0KPiA+PiAgfQ0K PiA+Pg0KPiA+PiAtc3RhdGljIHVpbnQ2NF90IGdldF9ndWVzdF9jcjNfZnJvbV9kdGUoc3RydWN0 IGFtZF9pb21tdV9kdGUgKmR0ZSkNCj4gPj4gKy8qDQo+ID4+ICsgKiBUaGUgR3Vlc3QgQ1IzIFRh YmxlIGlzIGEgdGFibGUgd3JpdHRlbiBieSB0aGUgZ3Vlc3Qga2VybmVsLCBwb2ludGluZyBhdA0K PiA+PiArICogZ0NSMyB2YWx1ZXMgZm9yIFBBU0lEIHRyYW5zYWN0aW9ucyB0byB1c2UuICBUaGUg RGV2aWNlIFRhYmxlIEVudHJ5IHBvaW50cw0KPiA+PiArICogYXQgYSBzeXN0ZW0gcGh5c2ljYWwg YWRkcmVzcy4NCj4gPj4gKyAqDQo+ID4+ICsgKiBIb3dldmVyLCB0aGVzZSBoZWxwZXJzIGRlbGli ZXJhdGVseSB1c2UgdW50eXBlZCBwYXJhbWV0ZXJzIHdpdGhvdXQNCj4gPj4gKyAqIHJlZmVyZW5j ZSB0byBnZm4vbWZuIGJlY2F1c2UgdGhleSBhcmUgdXNlZCBib3RoIGZvciBwcm9ncmFtbWluZyB0 aGUgcmVhbA0KPiA+PiArICogSU9NTVUsIGFuZCBpbnRlcnByZXRpbmcgYSBndWVzdHMgcHJvZ3Jh bW1pbmcgb2YgaXRzIHZJT01NVS4NCj4gPj4gKyAqLw0KPiA+PiArc3RhdGljIHVpbnQ2NF90IGR0 ZV9nZXRfZ2NyM190YWJsZShjb25zdCBzdHJ1Y3QgYW1kX2lvbW11X2R0ZSAqZHRlKQ0KPiA+PiAg ew0KPiA+PiAgICAgIHJldHVybiAoKGR0ZS0+Z2NyM190cnBfNTFfMzEgPDwgMzEpIHwgKGR0ZS0+ Z2NyM190cnBfMzBfMTUgPDwgMTUpIHwNCj4gPj4gLSAgICAgICAgICAgIChkdGUtPmdjcjNfdHJw XzE0XzEyIDw8IDEyKSkgPj4gUEFHRV9TSElGVDsNCj4gPj4gKyAgICAgICAgICAgIChkdGUtPmdj cjNfdHJwXzE0XzEyIDw8IDEyKSk7DQo+ID4+ICt9DQo+ID4+ICsNCj4gPj4gK3N0YXRpYyB2b2lk IGR0ZV9zZXRfZ2NyM190YWJsZShzdHJ1Y3QgYW1kX2lvbW11X2R0ZSAqZHRlLCB1aW50MTZfdCBk b21faWQsDQo+ID4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdWludDY0X3QgYWRk ciwgdWludDhfdCBndiwgdWludDhfdCBnbHgpDQo+ID4+ICt7DQo+ID4+ICsgICAgLyogSSBiaXQg bXVzdCBiZSBzZXQgd2hlbiBnY3IzIGlzIGVuYWJsZWQgKi8NCj4gPj4gKyAgICBkdGUtPmkgPSAx Ow0KPiA+PiArDQo+ID4+ICsgICAgZHRlLT5nY3IzX3RycF8xNF8xMiA9IE1BU0tfRVhUUihhZGRy LCAweDAwMDAwMDAwMDAwMDcwMDB1bGwpOw0KPiA+PiArICAgIGR0ZS0+Z2NyM190cnBfMzBfMTUg PSBNQVNLX0VYVFIoYWRkciwgMHgwMDAwMDAwMDdmZmY4MDAwdWxsKTsNCj4gPj4gKyAgICBkdGUt PmdjcjNfdHJwXzUxXzMxID0gTUFTS19FWFRSKGFkZHIsIDB4MDAwZmZmZmY4MDAwMDAwMHVsbCk7 DQo+ID4gSSdtIG5vdCBhIGZhbiBvZiB0aGUgYmlnIGhleCB2YWx1ZXMNCj4gDQo+IEV4Y2VwdCB0 aGV5IGFyZSB2ZXJ5IHZlcnkgZGVsaWJlcmF0ZSB0byBhdm9pZCB0aGUgcG9zc2liaWxpdHkgb2YN Cj4gcmVwZWF0aW5nIHRoZSBwcmV2aW91cyBtaXN0YWtlLCBhbmQgYXZvaWQgYW55IGNvbmZ1c2lv biBhYm91dCBob3cgYWRkcg0KPiBzaG91bGQgYmUgaW50ZXJwcmV0ZWQuDQoNClRoZSBwcm9ibGVt IGlzIHRoYXQgbG9va2luZyBhdCAweDAwMDAwMDAwN2ZmZjgwMDAsIGl0IGRvZXNuJ3QgaW1tZWRp YXRlbHkgc3ByaW5nIG91dCBhdCB5b3UgdGhhdCB0aGUgdG9wIGJpdCBpcyAzMCAoYWx0aG91Z2gg aXQncyBhIGJpdCBtb3JlIG9idmlvdXMgdGhhdCB0aGUgYm90dG9tIGJpdCBpcyAxNSkuIElNTyBh IG1hY3JvIHRoYXQgdGFrZXMgdGhlIHN0YXRlZCBoaWdoIGFuZCBsb3cgYml0cyBhbmQgaGFuZHMg eW91IGJhY2sgYW4gaW5jbHVzaXZlIG1hc2sgY2FuIGJlIG1vcmUgZWFzaWx5IHJlYXNvbmVkIGFi b3V0LiBMZXQncyBzZWUgd2hhdCBvdGhlcnMgdGhpbmsuLi4NCg0KICBQYXVsDQoNCj4gDQo+IH5B bmRyZXcNCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhl bi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBz Oi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw=