xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Paul Durrant <Paul.Durrant@citrix.com>
To: 'Jan Beulich' <JBeulich@suse.com>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>,
	Wei Liu <wei.liu2@citrix.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 5/9] viridian: separate interrupt related enlightenment implementations...
Date: Mon, 5 Nov 2018 13:22:38 +0000	[thread overview]
Message-ID: <f103289eeb0d4eecb7b1ce2782c252e9@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <5BE03CC002000078001F7FE7@prv1-mh.provo.novell.com>



> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@suse.com]
> Sent: 05 November 2018 12:51
> To: Paul Durrant <Paul.Durrant@citrix.com>
> Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>; Wei Liu
> <wei.liu2@citrix.com>; xen-devel <xen-devel@lists.xenproject.org>
> Subject: Re: [PATCH v2 5/9] viridian: separate interrupt related
> enlightenment implementations...
> 
> >>> On 31.10.18 at 13:43, <paul.durrant@citrix.com> wrote:
> > --- /dev/null
> > +++ b/xen/arch/x86/hvm/viridian/synic.c
> > @@ -0,0 +1,225 @@
> >
> +/************************************************************************
> **
> > *
> > + * synic.c
> > + *
> > + * An implementation of some interrupt related Viridian enlightenments.
> > + * See Microsoft's Hypervisor Top Level Functional Specification.
> > + * for more information.
> > + */
> > +
> > +#include <xen/domain_page.h>
> > +#include <xen/hypercall.h>
> > +#include <xen/sched.h>
> > +#include <xen/version.h>
> > +
> > +#include <asm/apic.h>
> > +#include <asm/hvm/support.h>
> > +
> > +static void dump_vp_assist(const struct vcpu *v)
> 
> With the name change to synic, is the _vp_ infix here and in a few
> other places retained intentionally?

Yes, it's meant to dump after programming the VP assist MSR, so I think the name is still correct.

> 
> > --- a/xen/include/asm-x86/hvm/viridian.h
> > +++ b/xen/include/asm-x86/hvm/viridian.h
> > @@ -9,6 +9,74 @@
> >  #ifndef __ASM_X86_HVM_VIRIDIAN_H__
> >  #define __ASM_X86_HVM_VIRIDIAN_H__
> >
> > +#include <asm/hvm/save.h>
> > +
> > +/* Viridian MSR numbers. */
> > +#define HV_X64_MSR_GUEST_OS_ID                   0x40000000
> 
> Are these needed outside of xen/arch/x86/hvm/viridian/ ? If not,
> please introduce a local header there rather than polluting
> every CU's name space. Other definitions and declaration local
> to the Viridian implementation should then go there too, rather
> than here.

Ok. They are only needed under that sub-dir so I'll add the extra header.

  Paul

> 
> Jan
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-11-05 13:23 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-31 12:43 [PATCH v2 0/9] viridian cleanup Paul Durrant
2018-10-31 12:43 ` [PATCH v2 1/9] viridian: move the code into its own sub-directory Paul Durrant
2018-10-31 12:43 ` [PATCH v2 2/9] viridian: remove MSR perf counters Paul Durrant
2018-10-31 12:43 ` [PATCH v2 3/9] viridian: remove comments referencing section number in the spec Paul Durrant
2018-10-31 12:43 ` [PATCH v2 4/9] viridian: remove duplicate union types Paul Durrant
2018-10-31 12:43 ` [PATCH v2 5/9] viridian: separate interrupt related enlightenment implementations Paul Durrant
2018-10-31 15:40   ` Wei Liu
2018-11-05 12:51   ` Jan Beulich
2018-11-05 13:22     ` Paul Durrant [this message]
2018-10-31 12:43 ` [PATCH v2 6/9] viridian: separate time " Paul Durrant
2018-10-31 15:43   ` Wei Liu
2018-11-05 12:56   ` Jan Beulich
2018-11-05 13:26     ` Paul Durrant
2018-11-05 13:36       ` Jan Beulich
2018-11-05 13:54         ` Paul Durrant
2018-11-05 14:56           ` Jan Beulich
2018-10-31 12:43 ` [PATCH v2 7/9] viridian: define type for the 'virtual VP assist page' Paul Durrant
2018-10-31 15:45   ` Wei Liu
2018-11-05 12:59   ` Jan Beulich
2018-11-05 13:19     ` Paul Durrant
2018-10-31 12:43 ` [PATCH v2 8/9] tools/misc: fix hard tabs in xen-hvmctx.c Paul Durrant
2018-10-31 14:00   ` Wei Liu
2018-10-31 12:43 ` [PATCH v2 9/9] viridian: introduce struct viridian_page Paul Durrant
2018-10-31 15:50   ` Wei Liu
2018-11-05 13:05   ` Jan Beulich
2018-11-05 13:18     ` Paul Durrant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f103289eeb0d4eecb7b1ce2782c252e9@AMSPEX02CL03.citrite.net \
    --to=paul.durrant@citrix.com \
    --cc=Andrew.Cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).